Skip to content

Commit 1f63a3c

Browse files
changing vale off flags
1 parent 2792501 commit 1f63a3c

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

CONTRIBUTING.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ not work as intended). This can either be done locally or via a pipeline/workflo
5050

5151
When we create new tests, or significantly change the functionality of a test, we should demonstrate these tests work
5252
by [recording the trace using Playwright](https://playwright.dev/python/docs/trace-viewer-intro) and attaching the
53-
generated trace file to the associated ticket within <!-- vale off -->Jira<!-- vale on -->.
53+
<!-- vale off -->
54+
generated trace file to the associated ticket within Jira.
55+
<!-- vale on -->
5456

5557
> NOTE: If the trace file exceeds the maximum file attachment size for <!-- vale off -->Jira<!-- vale on -->, we should
5658
> upload the file to a Confluence page instead and link this back to the ticket.
@@ -67,7 +69,9 @@ attach this to the ticket in <!-- vale off -->Jira<!-- vale on -->.
6769

6870
We then decide to refactor the test so that it uses a page object model for the send a kit page, but this does not change
6971
the behaviour of the test in any way (just makes the elements reusable). In this instance, we should upload the HTML report
70-
to the <!-- vale off -->Jira<!-- vale on --> ticket showing the test passing as the logic of the test has not changed in any way.
72+
<!-- vale off -->
73+
to the Jira ticket showing the test passing as the logic of the test has not changed in any way.
74+
<!-- vale on -->
7175

7276
We then decide to create a utility that loops through several subjects at once and apply this to the previously created send
7377
a kit test. In this instance, we should turn tracing on again and generate a trace file from Playwright and attach this to the

0 commit comments

Comments
 (0)