Addressing sonarqube issue and removing wip marker

Author: adrianoaru-nhs

tests/regression/subject/episodes/datasets/investigation/endoscopy/polypcategories/test_advanced_colorectal_polyp.py

@@ -43,7 +43,7 @@
     get_subject_with_investigation_dataset_ready,
     go_from_investigation_dataset_complete_to_a259_status,
     get_subject_with_a99_status,
-    go_from_a99_Status_to_a259_status,
+    go_from_a99_status_to_a259_status,
 )
 from utils.user_tools import UserTools
 
@@ -916,7 +916,7 @@ def test_identify_advanced_colorectal_polyp_from_histology_r(page: Page) -> None
     logging.info(f"NHS Number: {nhs_no}")
 
     UserTools.user_login(page, "Screening Centre Manager at BCS001")
-    go_from_a99_Status_to_a259_status(page, nhs_no)
+    go_from_a99_status_to_a259_status(page, nhs_no)
 
     SubjectScreeningSummaryPage(page).click_datasets_link()
     SubjectDatasetsPage(page).click_investigation_show_datasets()

tests/regression/subject/episodes/datasets/investigation/endoscopy/polypcategories/test_diminutive_rectal_hyperplastic_polyp.py

@@ -39,7 +39,7 @@
     get_subject_with_investigation_dataset_ready,
     go_from_investigation_dataset_complete_to_a259_status,
     get_subject_with_a99_status,
-    go_from_a99_Status_to_a259_status,
+    go_from_a99_status_to_a259_status,
 )
 
 general_information = {
@@ -254,7 +254,6 @@ def test_identify_diminutive_rectal_hyperplastic_polyp_from_histology_a(
     LogoutPage(page).log_out()
 
 
-@pytest.mark.wip
 @pytest.mark.vpn_required
 @pytest.mark.regression
 @pytest.mark.investigation_dataset_tests
@@ -270,7 +269,7 @@ def test_identify_diminutive_rectal_hyperplastic_polyp_from_histology_b(
 
     UserTools.user_login(page, "Screening Centre Manager at BCS001")
 
-    go_from_a99_Status_to_a259_status(page, nhs_no)
+    go_from_a99_status_to_a259_status(page, nhs_no)
 
     SubjectScreeningSummaryPage(page).click_datasets_link()
     SubjectDatasetsPage(page).click_investigation_show_datasets()

tests/regression/subject/episodes/datasets/investigation/endoscopy/polypcategories/test_setup.py

@@ -58,7 +58,7 @@
     verify_subject_event_status_by_nhs_no,
 )
 from utils.user_tools import UserTools
-from utils.datasets.investigation_datasets import go_from_a99_Status_to_a259_status
+from utils.datasets.investigation_datasets import go_from_a99_status_to_a259_status
 
 
 @pytest.fixture(scope="function", autouse=True)
@@ -168,7 +168,7 @@ def test_setup_subjects_as_a259(page: Page, subjects_to_run_for: int) -> None:
     for _, row in df.iterrows():
         nhs_no = row["nhs_number"]
         BasePage(page).click_main_menu_link()
-        go_from_a99_Status_to_a259_status(page, nhs_no)
+        go_from_a99_status_to_a259_status(page, nhs_no)
 
     LogoutPage(page).log_out()
 

utils/datasets/investigation_datasets.py

@@ -81,7 +81,7 @@ def get_subject_with_a99_status() -> pd.DataFrame:
     return df
 
 
-def go_from_a99_Status_to_a259_status(page: Page, nhs_no: str) -> None:
+def go_from_a99_status_to_a259_status(page: Page, nhs_no: str) -> None:
     """
     Takes a subject who has the latest episode status A99 - Suitable for Endoscopic Test
     and takes them to A259 - Attended Diagnostic Test.