Skip to content

Commit 28e4462

Browse files
vale amendments to fix formatting
1 parent b61d154 commit 28e4462

File tree

1 file changed

+4
-12
lines changed

1 file changed

+4
-12
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,29 +59,21 @@ generated trace file to the associated ticket within Jira.
5959
6060
When we modify existing tests (including any page objects or utilities used by these tests) but the behaviour of the test
6161
has not fundamentally changed, we should upload the generated HTML report from the Playwright execution to the
62-
<!-- vale off -->
63-
Jira ticket.
64-
<!-- vale on -->
62+
<!-- vale off --> Jira ticket. <!-- vale on -->
6563

6664
#### Example
6765

6866
We introduce a new test that covers the send a kit functionality for a single subject using `codegen` in the first instance.
6967
To demonstrate this test has worked as intended, we should turn tracing on and generate a trace file from Playwright and
70-
<!-- vale off -->
71-
attach this to the ticket in Jira.
72-
<!-- vale on -->
68+
<!-- vale off --> attach this to the ticket in Jira. <!-- vale on -->
7369

7470
We then decide to refactor the test so that it uses a page object model for the send a kit page, but this does not change
7571
the behaviour of the test in any way (just makes the elements reusable). In this instance, we should upload the HTML report
76-
<!-- vale off -->
77-
to the Jira ticket showing the test passing as the logic of the test has not changed in any way.
78-
<!-- vale on -->
72+
<!-- vale off --> to the Jira ticket showing the test passing as the logic of the test has not changed in any way. <!-- vale on -->
7973

8074
We then decide to create a utility that loops through several subjects at once and apply this to the previously created send
8175
a kit test. In this instance, we should turn tracing on again and generate a trace file from Playwright and attach this to the
82-
<!-- vale off -->
83-
ticket in Jira, because the logic of the test has fundamentally changed.
84-
<!-- vale on -->
76+
<!-- vale off --> ticket in Jira, because the logic of the test has fundamentally changed. <!-- vale on -->
8577

8678
## Coding Practices
8779

0 commit comments

Comments
 (0)