Skip to content

Commit 371f40e

Browse files
committed
format errors
1 parent 469a466 commit 371f40e

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

pages/screening_subject_search/subject_events_notes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ def select_additional_care_note_type(self, option: str) -> None:
4848
- AdditionalCareNoteTypeOptions.LANGUAGE
4949
- AdditionalCareNoteTypeOptions.OTHER
5050
"""
51-
self.additional_care_note_type.select_option(option)
51+
self.additional_care_note_type.select_option(option)
5252

5353
def fill_notes(self, notes: str) -> None:
5454
"""Fills the notes field with the provided text."""
55-
self.notes_upto_500_char.fill(notes)
55+
self.notes_upto_500_char.fill(notes)
5656

5757
def dismiss_dialog_and_update_notes(self) -> None:
5858
"""Clicks the 'Update Notes' button and handles the dialog by clicking 'OK'."""

tests/regression/notes/test_additional_care_notes_regression.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,7 @@ def test_add_additional_care_note_for_subject_with_existing_note(page: Page, smo
199199

200200
def test_identify_subject_with_additional_care_note(page: Page, smokescreen_properties: dict) -> None:
201201
"""
202-
Test to identify if a subject has an Additional Care note.
203-
202+
Test to identify if a subject has an Additional Care note.
204203
"""
205204
logging.info("Starting test: Verify subject has an additional care note.")
206205
logging.info("Logging in as 'ScreeningAssistant at BCS02'.")
@@ -267,3 +266,4 @@ def test_view_active_additional_care_note(page: Page, smokescreen_properties: di
267266
# Filter the DataFrame to only include rows where type_id == 4112
268267
filtered_notes_df = notes_df[notes_df["type_id"] == type_id]
269268
# Verify title and note match the UI values
269+

utils/oracle/oracle_specific_functions.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -438,8 +438,7 @@ def get_subjects_by_note_count(type_id: int, note_count: int = 0) -> pd.DataFram
438438
SELECT ss.screening_subject_id, ss.subject_nhs_number, :type_id AS type_id
439439
FROM screening_subject_t ss
440440
INNER JOIN sd_contact_t c ON ss.subject_nhs_number = c.nhs_number
441-
WHERE
442-
(
441+
WHERE (
443442
(:note_count = 0 AND NOT EXISTS (
444443
SELECT 1
445444
FROM supporting_notes_t sn
@@ -482,12 +481,10 @@ def get_supporting_notes(screening_subject_id: int, type_id: int) -> pd.DataFram
482481
SELECT *
483482
FROM supporting_notes_t sn
484483
WHERE sn.screening_subject_id = :screening_subject_id
485-
AND sn.type_id = :type_id
486-
AND sn.status_id = 4100
484+
AND sn.type_id = :type_id
485+
AND sn.status_id = 4100
487486
ORDER BY NVL(sn.updated_datestamp, sn.created_datestamp) DESC
488487
"""
489-
490488
params = {"screening_subject_id": screening_subject_id, "type_id": type_id}
491489
notes_df = OracleDB().execute_query(query, params)
492-
493490
return notes_df

0 commit comments

Comments
 (0)