Fixing errors listed by pytest and adding utils to use the book appointments calendar

Author: adrianoaru-nhs

pages/gfobt_test_kits/gfobt_test_kit_logging_page.py

@@ -2,7 +2,7 @@
 from pages.base_page import BasePage
 
 
-class TestKitLogging(BasePage):
+class GFOBTTestKitLogging(BasePage):
     def __init__(self, page: Page):
         super().__init__(page)
         self.page = page

pages/gfobt_test_kits/gfobt_test_kit_quality_control_reading_page.py

@@ -2,7 +2,7 @@
 from pages.base_page import BasePage
 
 
-class TestKitQualityControlReading(BasePage):
+class GFOBTTestKitQualityControlReading(BasePage):
     def __init__(self, page: Page):
         super().__init__(page)
         self.page = page

pages/screening_practitioner_appointments/book_appointment_page.py

@@ -12,12 +12,16 @@ def __init__(self, page: Page):
         self.site_dropdown = page.locator("#UI_NEW_SITE")
         self.day_with_available_slots = page.locator(
             'input.twoColumnCalendar[style*="background-color: rgb(102, 255, 153);"]'
-        ).last
+        )
+        self.day_with_some_available_slots = page.locator(
+            'input.twoColumnCalendar[style*="background-color: rgb(255, 220, 144);"]'
+        )
         self.appointment_time_radio_button = page.locator(
             page.get_by_role("radio", name="UI_NEW_SLOT_SELECTION_ID")
         )
         self.save_button = page.get_by_role("button", name="Save")
         self.appointments_table = TableUtils(self.page, "#displayRS")
+        self.current_month_displayed = self.page.locator("#MONTH_AND_YEAR")
 
     def select_screening_centre_dropdown_option(self, screening_centre: str) -> None:
         self.screening_center_dropdown.select_option(label=screening_centre)
@@ -37,3 +41,9 @@ def click_save_button(self) -> None:
 
     def appointment_booked_confirmation_is_displayed(self, message: str) -> None:
         expect(self.page.get_by_text(message)).to_be_visible()
+
+    def accept_dialog(self) -> None:
+        self.page.once("dialog", lambda dialog: dialog.accept())
+
+    def get_current_month_displayed(self) -> str:
+        return self.current_month_displayed.text_content()

pages/screening_practitioner_appointments/colonoscopy_assessment_appointments_page.py

@@ -16,6 +16,7 @@ def verify_page_header(self) -> None:
         )
 
     def filter_by_nhs_number(self, nhs_number: str) -> None:
+        self.click(self.nhs_number_filter_text_field)
         self.nhs_number_filter_text_field.fill(nhs_number)
         self.nhs_number_filter_text_field.press("Enter")
 

pytest.ini

@@ -32,4 +32,6 @@ markers =
     compartment1: only for compartment 1
     compartment2: only for compartment 2
     compartment3: only for compartment 3
+    compartment4: only for compartment 4
+    compartment1_plan_creation: to run the plan creation for compartment 1
     vpn_required: for tests that require a VPN connection

tests/smokescreen/test_compartment_4.py

@@ -30,6 +30,7 @@
 from datetime import datetime
 from utils.oracle.oracle_specific_functions import get_subjects_for_appointments
 from utils.nhs_number_tools import NHSNumberTools
+import logging
 
 
 @pytest.fixture
@@ -54,6 +55,7 @@ def test_compartment_4(page: Page, smokescreen_properties: dict) -> None:
         smokescreen_properties["c4_eng_number_of_appointments_to_book"]
     )
 
+    logging.info("Setting up appointments")
     UserTools.user_login(page, "Screening Centre Manager at BCS001")
     BasePage(page).go_to_screening_practitioner_appointments_page()
     ScreeningPractitionerAppointmentsPage(page).go_to_set_availability_page()
@@ -65,9 +67,7 @@ def test_compartment_4(page: Page, smokescreen_properties: dict) -> None:
         "Astonish, Ethanol"
     )
     PractitionerAvailabilityPage(page).click_calendar_button()
-    CalendarPicker(page).select_day(
-        datetime.today()
-    )  # This will make it so that we can only run this test once a day, or we need to restore the DB back to the snapshot
+    CalendarPicker(page).select_day(datetime.today())
     PractitionerAvailabilityPage(page).click_show_button()
     PractitionerAvailabilityPage(page).enter_start_time("09:00")
     PractitionerAvailabilityPage(page).enter_end_time("17:15")
@@ -81,25 +81,43 @@ def test_compartment_4(page: Page, smokescreen_properties: dict) -> None:
 
     ScreeningPractitionerAppointmentsPage(page).go_to_log_in_page()
     UserTools.user_login(page, "Hub Manager State Registered at BCS01")
+
     BasePage(page).go_to_screening_practitioner_appointments_page()
     ScreeningPractitionerAppointmentsPage(page).go_to_patients_that_require_page()
-    # Add for loop to loop x times (depends on how many we want to run it for) 70 - 79
-    nhs_number = subjects_df["subject_nhs_number"].iloc[0]
-    nhs_number_spaced = NHSNumberTools().spaced_nhs_number(nhs_number)
-    ColonoscopyAssessmentAppointments(page).filter_by_nhs_number(nhs_number)
-    ColonoscopyAssessmentAppointments(page).click_nhs_number_link(nhs_number_spaced)
-    BookAppointmentPage(page).select_screening_centre_dropdown_option(
-        "BCS001 - Wolverhampton Bowel Cancer Screening Centre"
-    )
-    BookAppointmentPage(page).select_site_dropdown_option("Holly Hall Clinic (? km)")
-    BookAppointmentPage(page).choose_day_with_available_slots()
-    BookAppointmentPage(page).appointments_table.click_first_input_in_column(
-        "Appt/Slot Time"
-    )
-    BookAppointmentPage(page).click_save_button()
-    BookAppointmentPage(page).appointment_booked_confirmation_is_displayed(
-        "Appointment booked"
-    )
+
+    for subject_num in range(
+        int(smokescreen_properties["c4_eng_number_of_appointments_to_book"])
+    ):
+        nhs_number = subjects_df["subject_nhs_number"].iloc[subject_num]
+        logging.info(f"Booking appointment for: {nhs_number}")
+
+        nhs_number_spaced = NHSNumberTools().spaced_nhs_number(nhs_number)
+        ColonoscopyAssessmentAppointments(page).filter_by_nhs_number(nhs_number)
+        ColonoscopyAssessmentAppointments(page).click_nhs_number_link(nhs_number_spaced)
+        BookAppointmentPage(page).select_screening_centre_dropdown_option(
+            "BCS001 - Wolverhampton Bowel Cancer Screening Centre"
+        )
+        BookAppointmentPage(page).select_site_dropdown_option(
+            "The Royal Hospital (Wolverhampton) (? km)"
+        )
+        current_month_displayed = BookAppointmentPage(
+            page
+        ).get_current_month_displayed()
+        CalendarPicker(page).select_first_eligble_appointment(
+            current_month_displayed,
+            BookAppointmentPage(page).day_with_available_slots,
+            BookAppointmentPage(page).day_with_some_available_slots,
+        )
+        BookAppointmentPage(page).appointments_table.click_first_input_in_column(
+            "Appt/Slot Time"
+        )
+        BookAppointmentPage(page).accept_dialog()
+        BookAppointmentPage(page).click_save_button()
+        BookAppointmentPage(page).appointment_booked_confirmation_is_displayed(
+            "Appointment booked"
+        )
+        BasePage(page).click_back_button()
+    BasePage(page).click_main_menu_link()
 
     batch_processing(
         page,

tests/test_gfobt_test_kits_page.py

@@ -3,9 +3,9 @@
 
 from pages.base_page import BasePage
 from pages.gfobt_test_kits.gfobt_test_kits_page import GFOBTTestKits
-from pages.gfobt_test_kits.gfobt_test_kit_logging_page import TestKitLogging
+from pages.gfobt_test_kits.gfobt_test_kit_logging_page import GFOBTTestKitLogging
 from pages.gfobt_test_kits.gfobt_test_kit_quality_control_reading_page import (
-    TestKitQualityControlReading,
+    GFOBTTestKitQualityControlReading,
 )
 from pages.gfobt_test_kits.gfobt_view_test_kit_result import ViewTestKitResult
 from pages.gfobt_test_kits.gfobt_create_qc_kit_page import (
@@ -27,6 +27,7 @@ def before_each(page: Page):
     # Go to gFOBT test kits page
     BasePage(page).go_to_gfobt_test_kits_page()
 
+
 @pytest.mark.smoke
 def test_gfobt_test_kit_page_navigation(page: Page) -> None:
     """
@@ -35,12 +36,12 @@ def test_gfobt_test_kit_page_navigation(page: Page) -> None:
     """
     # Test kit logging page opens as expected
     GFOBTTestKits(page).go_to_test_kit_logging_page()
-    TestKitLogging(page).verify_test_kit_logging_title()
+    GFOBTTestKitLogging(page).verify_test_kit_logging_title()
     BasePage(page).click_back_button()
 
     # Test kit reading page opens as expected
     GFOBTTestKits(page).go_to_test_kit_reading_page()
-    TestKitQualityControlReading(page).verify_test_kit_logging_tile()
+    GFOBTTestKitQualityControlReading(page).verify_test_kit_logging_tile()
     BasePage(page).click_back_button()
 
     # View test kit result page opens as expected

utils/calendar_picker.py

@@ -3,6 +3,8 @@
 from playwright.sync_api import Page, Locator
 from pages.base_page import BasePage
 from sys import platform
+import logging
+import pytest
 
 
 class CalendarPicker(BasePage):
@@ -14,6 +16,13 @@ def __init__(self, page: Page):
         self.v1_prev_month = self.page.get_by_role("cell", name="‹").locator("div")
         self.v1_next_month = self.page.get_by_role("cell", name="›").locator("div")
         self.v1_next_year = self.page.get_by_role("cell", name="»").locator("div")
+        # Book Appointment picker locators
+        self.appointments_prev_month = self.page.get_by_role(
+            "link", name="<-", exact=True
+        )
+        self.appointments_next_month = self.page.get_by_role(
+            "link", name="->", exact=True
+        )
 
     # Calendar Methods
     def calendar_picker_ddmmyyyy(self, date: datetime, locator: Locator) -> None:
@@ -276,3 +285,83 @@ def v2_calendar_picker(self, date: datetime) -> None:
         )
 
         self.select_day(date)
+
+    def month_string_to_number(self, string: str) -> None:
+        """
+        This is used to convert a month from a string to an integer.
+        It accepts the full month or the short version and is not case sensitive
+        """
+        months = {
+            "jan": 1,
+            "feb": 2,
+            "mar": 3,
+            "apr": 4,
+            "may": 5,
+            "jun": 6,
+            "jul": 7,
+            "aug": 8,
+            "sep": 9,
+            "oct": 10,
+            "nov": 11,
+            "dec": 12,
+        }
+        month_short = string.strip()[:3].lower()
+
+        try:
+            out = months[month_short]
+            return out
+        except Exception:
+            raise ValueError("Not a month")
+
+    def select_first_eligble_appointment(
+        self,
+        current_month_displayed: str,
+        avialble_locator: Locator,
+        some_available_locator: Locator,
+    ) -> None:
+        """
+        This is used to select the first eligible appointment date
+        It first gets all available dates, and then clicks on the first one starting from today's date
+        """
+        current_month_displayed_int = self.month_string_to_number(
+            current_month_displayed
+        )
+        if platform == "win32":  # Windows
+            current_month_int = int(datetime.now().strftime("%#d"))
+        else:  # Linux or Mac
+            current_month_int = int(datetime.now().strftime("%-d"))
+
+        if current_month_displayed_int != current_month_int:
+            self.click(self.appointments_prev_month)
+
+        months_looped = 0
+        appointment_clicked = False
+        while (
+            months_looped < 3 and not appointment_clicked
+        ):  # This loops through this month + next two months to find available appointments. If none found it has failed
+            appointment_clicked = self.check_for_eligible_appointment_dates(
+                avialble_locator
+            )
+
+            if not appointment_clicked:
+                appointment_clicked = self.check_for_eligible_appointment_dates(
+                    some_available_locator
+                )
+
+            if not appointment_clicked:
+                self.click(self.appointments_next_month)
+                months_looped += 1
+
+        if not appointment_clicked:
+            pytest.fail("No available appointments found for the current month")
+
+    def check_for_eligible_appointment_dates(self, locator: Locator) -> bool:
+
+        locator_count = locator.count()
+
+        for i in range(locator_count):
+            locator_number = locator_count - i - 1
+            value = locator.nth(locator_number).get_attribute("name")
+            if len(value) < 5:
+                self.click(locator.nth(locator_number))
+                return True