Skip to content

Commit 3aab996

Browse files
Restructure Project (#16)
<!-- markdownlint-disable-next-line first-line-heading --> ## Description <!-- Describe your changes in detail. --> This covers restructuring the project so it can be used from the base level. ## Context <!-- Why is this change required? What problem does it solve? --> It was causing confusion for new people adopting the project. ## Type of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [x] Refactoring (non-breaking change) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would change existing functionality) - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [ ] I am familiar with the [contributing guidelines](../docs/CONTRIBUTING.md) - [x] I have followed the code style of the project - [ ] I have added tests to cover my changes - [x] I have updated the documentation accordingly - [ ] This PR is a result of pair or mob programming --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
1 parent e55f08b commit 3aab996

File tree

12 files changed

+11
-16
lines changed

12 files changed

+11
-16
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,7 @@
1111
!project.code-workspace
1212

1313
# Please, add your custom content below!
14+
15+
__pycache__/
16+
.pytest_cache/
17+
test-results/

README.md

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
This project is designed to provide a blueprint to allow for development teams to start quickly developing UI tests using [Playwright Python](https://playwright.dev/python/), providing the base framework and utilities to allow for initial focus on writing tests, rather than configuration of the framework itself.
66

7-
NOTE: This project is currently under initial development.
7+
NOTE: This project is currently under initial development so isn't finalised, but should work if you want to experiment with Playwright Python.
88

9-
> **NOTE: When considering this project, please be advised that currently Playwright is a "proposed" tool within the [NHS England Tech Radar](https://radar.engineering.england.nhs.uk/). Whilst we are taking steps to get Playwright moved to the "mainstream" section of the radar, as it has not yet been formally adopted it is possible that Playwright may not be fully endorsed by NHS England as a standard tool going forward and using this framework for an NHS England project is at your own risk.**
9+
> **NOTE: When considering this project, please be advised that currently Playwright is a "proposed" tool within the [NHS England Tech Radar](https://radar.engineering.england.nhs.uk/). Whilst we are taking steps to get Playwright moved to the "mainstream" section of the radar, as it has not yet been formally adopted it is possible that Playwright may not be fully endorsed by NHS England as a standard tool going forward, and using this framework for an NHS England project is currently at your own risk.**
1010
1111
## Table of Contents
1212

@@ -27,12 +27,6 @@ You can clone this whole repository using the code below:
2727
git clone https://github.com/nhs-england-tools/playwright-python-blueprint.git
2828
```
2929

30-
The code for actually working in Playwright is contained in the blueprint directory, so it's best to do the following to move straight into that working directory:
31-
32-
```shell
33-
cd nhs-england-tools/playwright-python-blueprint/blueprint
34-
```
35-
3630
### Prerequisites
3731

3832
To utilise the blueprint code, you will need to have the following installed:

blueprint/.gitignore

Lines changed: 0 additions & 3 deletions
This file was deleted.

blueprint/run_tests.sh

Lines changed: 0 additions & 5 deletions
This file was deleted.
File renamed without changes.

run_tests.sh

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
#!/bin/sh
2+
3+
BASE_URL=${1:-${BASE_URL}}
4+
5+
pytest --base-url $1
File renamed without changes.

0 commit comments

Comments
 (0)