Skip to content

Commit 4b4a491

Browse files
committed
code smells
1 parent f67cd12 commit 4b4a491

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

pages/reports/operational/subjects_to_be_invited_with_temporary_address_page.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,34 +37,34 @@ def filter_by_nhs_number(self, search_text: str) -> None:
3737
self.nhs_filter.fill(search_text)
3838
self.nhs_filter.press("Enter")
3939

40-
def assertRecordsVisible(self, nhs_no: str, expectedVisible: bool) -> None:
41-
logging.info(f"Attempting to check if records for {nhs_no} are visible : {expectedVisible}")
40+
def assertRecordsVisible(self, nhs_no: str, expected_visible: bool) -> None:
41+
logging.info(f"Attempting to check if records for {nhs_no} are visible : {expected_visible}")
4242

4343
subject_summary_link = self.page.get_by_role(
4444
"link", name = NHSNumberTools().spaced_nhs_number(nhs_no)
4545
)
4646

4747
logging.info(f"subject_summary_link.is_visible() : {subject_summary_link.is_visible()}")
4848
if (
49-
expectedVisible != subject_summary_link.is_visible()
49+
expected_visible != subject_summary_link.is_visible()
5050
):
5151
raise ValueError(
52-
f"Record for {NHSNumberTools().spaced_nhs_number(nhs_no)} does not have expected visibility : {expectedVisible}. Was in fact {subject_summary_link.is_visible()}."
52+
f"Record for {NHSNumberTools().spaced_nhs_number(nhs_no)} does not have expected visibility : {expected_visible}. Was in fact {subject_summary_link.is_visible()}."
5353
)
5454

55-
def filterByReviewed(self, filterValue: str) -> None:
56-
logging.info(f"Filter reviewed column by : {filterValue}")
55+
def filterByReviewed(self, filter_value: str) -> None:
56+
logging.info(f"Filter reviewed column by : {filter_value}")
5757

58-
filterBox = self.page.locator("#reviewedFilter")
59-
filterBox.click()
60-
filterBox.select_option(filterValue)
58+
filter_box = self.page.locator("#reviewedFilter")
59+
filter_box.click()
60+
filter_box.select_option(filter_value)
6161

6262
def reviewSubject(self, nhs_no: str, reviewed: bool) -> None:
6363
logging.info(f"Mark subject {nhs_no} as reviewed: {reviewed}")
6464

6565
row = self.page.locator(f'tr:has-text("{NHSNumberTools().spaced_nhs_number(nhs_no)}")')
66-
lastCell = row.get_by_role("cell").nth(-1)
67-
checkbox = lastCell.get_by_role("checkbox")
66+
last_cell = row.get_by_role("cell").nth(-1)
67+
checkbox = last_cell.get_by_role("checkbox")
6868
checkbox.set_checked(reviewed)
6969

7070
def click_subject_link(self, nhs_no: str) -> None:

0 commit comments

Comments
 (0)