Added docstrings and addressed PR comments

Author: Andyg79

pages/datasets/colonoscopy_dataset_page.py

@@ -4,13 +4,15 @@
 
 
 class ColonoscopyDatasetsPage(BasePage):
+    """
+    This class contains locators and methods to interact with the Colonoscopy Datasets page.
+    """
+
     def __init__(self, page: Page):
         super().__init__(page)
         self.page = page
 
         # Colonoscopy datasets page locators
-        self.show_dataset_button = self.page.get_by_role("link", name="Show Dataset")
-
         self.save_dataset_button = self.page.locator(
             "#UI_DIV_BUTTON_SAVE1"
         ).get_by_role("button", name="Save Dataset")
@@ -29,16 +31,29 @@ def __init__(self, page: Page):
             "radio", name="No"
         )
 
-    def click_show_datasets(self) -> None:
-        self.click(self.show_dataset_button)
-
     def save_dataset(self) -> None:
         self.click(self.save_dataset_button)
 
     def select_asa_grade_option(self, option: str) -> None:
+        """
+        This method is designed to select a specific grade option from the colonoscopy dataset page, ASA Grade dropdown menu.
+        Args:
+        option (str): The ASA grade option to be selected. This should be a string that matches one of the available options in the dropdown menu.
+            Valid options are: "FIT", "RELEVANT_DISEASE", "UNABLE_TO_ASSESS", RESTRICTIVE_DISEASE, "LIFE_THREATENING_DISEASE", "MORIBUND", "NOT_APPLICABLE", or "NOT_KNOWN".
+        Returns:
+        None
+        """
         self.select_asa_grade_dropdowen.select_option(option)
 
     def select_fit_for_colonoscopy_option(self, option: str) -> None:
+        """
+        This method is designed to select a specific option from the colonoscopy dataset page, Fit for Colonoscopy (SSP) dropdown menu.
+        Args:
+        option (str): The option to be selected. This should be a string that matches one of the available options in the dropdown menu.
+            Valid options are: "YES", "NO", or "UNABLE_TO_ASSESS".
+        Returns:
+        None
+        """
         self.select_fit_for_colonoscopy_dropdown.select_option(option)
 
     def click_dataset_complete_radio_button_yes(self) -> None:

pages/datasets/subject_datasets_page.py

@@ -3,6 +3,10 @@
 
 
 class SubjectDatasetsPage(BasePage):
+    """
+    This class contains locators and methods to interact with the Subject Datasets page.
+    """
+
     def __init__(self, page: Page):
         super().__init__(page)
         self.page = page

tests/smokescreen/test_compartment_5.py

@@ -76,11 +76,11 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
 
     AppointmentCalendar(page).click_view_appointments_on_this_day_button()
     ScreeningPractitionerDayView(page).click_calendar_button()
-    date_from_util = datetime(2025, 4, 29)
+    date_from_util = datetime(2025, 5, 1)
     CalendarPicker(page).v1_calender_picker(date_from_util)
 
     # Select subject from inital test data util
-    ScreeningPractitionerDayView(page).click_patient_link("REFUSE CRUMBLE")
+    ScreeningPractitionerDayView(page).click_patient_link("CRUMBLE REFUSE")
 
     # Select Attendance radio button, tick Attended checkbox, set Attended Date to yesterday's (system) date and then press Save
     AppointmentDetail(page).check_attendance_radio()
@@ -93,7 +93,7 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
     # Repeat for x Abnormal  patients
 
     # Navigate to the 'Subject Screening Summary' screen for the 1st Abnormal patient
-    nhs_no = "9724560430"  # Test NHS NO for Scaliding Cod
+    nhs_no = "9724560430"  # Test NHS NO for CRUMBLE REFUSE
     verify_subject_event_status_by_nhs_no(
         page, nhs_no, "J10 - Attended Colonoscopy Assessment Appointment"
     )