Skip to content

Commit 5a7af62

Browse files
Making Changes to scenario 13 and classes as per release 2025.06 (#152)
<!-- markdownlint-disable-next-line first-line-heading --> ## Description <!-- Describe your changes in detail. --> Updating scenario 13 do address the recent SSPI changes as part of release 2025.06 ## Context <!-- Why is this change required? What problem does it solve? --> Updating scenario 13 do address the recent SSPI changes as part of release 2025.06 ## Type of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [x] Refactoring (non-breaking change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [x] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I am familiar with the [contributing guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md) - [x] I have followed the code style of the project - [x] I have added tests to cover my changes (where appropriate) - [x] I have updated the documentation accordingly - [ ] This PR is a result of pair or mob programming --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
1 parent 6db2c7f commit 5a7af62

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

classes/lynch/lynch_sdd_reason_for_change_type.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ class LynchSDDReasonForChangeType(Enum):
2929
)
3030
REVERSAL_OF_DEATH_NOTIFICATION = (305713, "Reversal of Death Notification")
3131
SELECTED_FOR_LYNCH_SURVEILLANCE = (307071, "Selected for Lynch Surveillance")
32+
WITHDRAWN_FROM_LYNCH_SURVEILLANCE = (307119, "Withdrawn from Lynch Surveillance")
3233
NULL = (None, "null")
3334
NOT_NULL = (None, "not null")
3435
UNCHANGED = (None, "unchanged")

classes/surveillance/sdd_reason_for_change_type.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ class SDDReasonForChangeType(Enum):
126126
REVERSAL_OF_DEATH_NOTIFICATION = (11565, "Reversal of Death Notification")
127127
ROLLOUT_IMPLEMENTATION = (11337, "Rollout Implementation")
128128
SELFREFERRAL = (11332, "Self-Referral")
129+
WITHDRAWN_FROM_LYNCH_SURVEILLANCE = (307123, "Withdrawn from Lynch Surveillance")
129130

130131
# Special values (no valid_value_id)
131132
NULL = (None, "null")

tests/regression/regression_tests/fobt_regression_tests/test_scenario_13.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def test_scenario_13(page: Page) -> None:
139139

140140
query, bind_vars = SubjectSelectionQueryBuilder().build_subject_selection_query(
141141
criteria=criteria,
142-
user=User(),
142+
user=User().from_user_role_type(user_role),
143143
subject=Subject(),
144144
subjects_to_retrieve=1,
145145
)
@@ -536,7 +536,7 @@ def test_scenario_13(page: Page) -> None:
536536
# Then my subject has been updated as follows:
537537
criteria = {
538538
"which diagnostic test": "Latest not-void test in latest episode",
539-
"calculated FOBT Due Date": "Unchanged",
539+
"calculated FOBT Due Date": "2 years from episode end",
540540
"calculated Lynch due date": "Null",
541541
"calculated Surveillance Due Date": "3 years from episode end",
542542
"ceased confirmation date": "Today",
@@ -554,6 +554,7 @@ def test_scenario_13(page: Page) -> None:
554554
"lynch due date reason": "Unchanged",
555555
"lynch due date date of change": "Unchanged",
556556
"pre-interrupt event status": "A259 Attended Diagnostic Test",
557+
"previous screening status": "Surveillance",
557558
"screening Due Date": "Null",
558559
"screening Due Date Date of change": "Today",
559560
"screening Due Date Reason": "Ceased",
@@ -562,7 +563,7 @@ def test_scenario_13(page: Page) -> None:
562563
"screening status reason": "Individual has left the country",
563564
"surveillance Due Date": "Null",
564565
"surveillance due date date of change": "Unchanged",
565-
"surveillance due date reason": "Unchanged",
566+
"surveillance due date reason": "Ceased",
566567
"symptomatic procedure date": "Null",
567568
"symptomatic procedure result": "Null",
568569
"screening referral type": "Null",
@@ -634,8 +635,8 @@ def test_scenario_13(page: Page) -> None:
634635
"screening status date of change": "Today",
635636
"screening status reason": "Reopened episode",
636637
"surveillance due date": "Null",
637-
"surveillance due date date of change": "Unchanged",
638-
"surveillance due date reason": "Unchanged",
638+
"surveillance due date date of change": "Null",
639+
"surveillance due date reason": "Null",
639640
"symptomatic procedure date": "Null",
640641
"symptomatic procedure result": "Null",
641642
"screening referral type": "Null",

0 commit comments

Comments
 (0)