Skip to content

Commit 734e30e

Browse files
Additional Extension Recommendations (#53)
<!-- markdownlint-disable-next-line first-line-heading --> ## Description <!-- Describe your changes in detail. --> This adds a couple of additional recommended extensions for use with this blueprint: * Black (formatter) * SonarQube for IDE (code quality and directly linked to NHS England engineering red lines) This change also makes a minor amendment to how the users.json file is located (using `os.getcwd()` instead). ## Context <!-- Why is this change required? What problem does it solve? --> This ensures tools are available for linting code and checking code quality by default. ## Type of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply. --> - [x] Refactoring (non-breaking change) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would change existing functionality) - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I am familiar with the [contributing guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md) - [x] I have followed the code style of the project - [ ] I have added tests to cover my changes (where appropriate) - [ ] I have updated the documentation accordingly - [ ] This PR is a result of pair or mob programming --- ## Sensitive Information Declaration To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including [PII (Personal Identifiable Information) / PID (Personal Identifiable Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter. - [x] I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.
1 parent 9732e72 commit 734e30e

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.vscode/extensions.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,15 @@
1515
"johnpapa.vscode-peacock",
1616
"mhutchie.git-graph",
1717
"ms-azuretools.vscode-docker",
18+
"ms-python.black-formatter",
1819
"ms-python.python",
1920
"ms-vscode-remote.remote-containers",
2021
"ms-vscode-remote.remote-wsl",
2122
"ms-vscode.hexeditor",
2223
"ms-vscode.live-server",
2324
"ms-vsliveshare.vsliveshare",
2425
"redhat.vscode-xml",
26+
"sonarsource.sonarlint-vscode",
2527
"streetsidesoftware.code-spell-checker-british-english",
2628
"tamasfe.even-better-toml",
2729
"tomoki1207.pdf",

utils/axe.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77

88
logger = logging.getLogger(__name__)
9-
109
PATH_FOR_REPORT = Path(os.getcwd()) / "axe-reports"
1110

1211

utils/user_tools.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import json
2+
import os
23
import logging
34
from pathlib import Path
45

56

67
logger = logging.getLogger(__name__)
7-
USERS_FILE = Path(__file__).parent.parent / "users.json"
8+
USERS_FILE = Path(os.getcwd()) / "users.json"
89

910

1011
class UserTools:

0 commit comments

Comments
 (0)