Skip to content

Commit 741111b

Browse files
As per PR#65 review comments, code change is implemented.
1 parent a682caa commit 741111b

File tree

2 files changed

+23
-10
lines changed

2 files changed

+23
-10
lines changed

pages/screening_subject_search/handover_into_symptomatic_care_page.py

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,37 @@ def __init__(self, page: Page):
1515
self.save_button = self.page.get_by_role("button", name="Save")
1616

1717
def select_referral_dropdown_option(self, value: str) -> None:
18-
"""Select a given option from the Referral dropdown."""
18+
"""
19+
Select a given option from the Referral dropdown.
20+
21+
Args:
22+
value (str): The value of the option you want to select
23+
"""
1924
self.referral_dropdown.select_option(value)
2025

2126
def click_calendar_button(self) -> None:
2227
"""Click the calendar button to open the calendar picker."""
2328
self.click(self.calendar_button)
2429

2530
def select_consultant(self, value: str) -> None:
26-
"""Select a consultant from the dropdown."""
31+
"""
32+
Select a consultant from the consultant dropdown using the given value.
33+
34+
Args:
35+
value (str): The value attribute of the consultant option to select.
36+
"""
2737
self.consultant_link.click()
2838
option_locator = self.page.locator(f'[value="{value}"]:visible')
2939
option_locator.wait_for(state="visible")
3040
self.click(option_locator)
3141

3242
def fill_notes(self, notes: str) -> None:
33-
"""Fill the notes textbox with the given text."""
43+
"""
44+
Fill the 'Notes' textbox with the provided text.
45+
46+
Args:
47+
notes (str): The text to enter into the notes textbox.
48+
"""
3449
self.notes_textbox.click()
3550
self.notes_textbox.fill(notes)
3651

tests/smokescreen/test_compartment_6.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22
from playwright.sync_api import Page, expect
33
from pages.base_page import BasePage
44
from utils.user_tools import UserTools
5-
from utils.calendar_picker import CalendarPicker
6-
from datetime import datetime
75
from utils.screening_subject_page_searcher import verify_subject_event_status_by_nhs_no
86
from pages.screening_subject_search.subject_screening_summary_page import (
97
SubjectScreeningSummaryPage,
@@ -279,7 +277,7 @@ def test_compartment_6(page: Page, smokescreen_properties: dict) -> None:
279277

280278
# This needs to be repeated for two subjects, one old and one not - High Risk Result
281279
# Older patient
282-
nhs_no = "9109877185"
280+
nhs_no = "9577049095"
283281
go_to_investigation_datasets_page(page, nhs_no)
284282

285283
# The following code is on the investigation datasets page
@@ -294,7 +292,7 @@ def test_compartment_6(page: Page, smokescreen_properties: dict) -> None:
294292
handover_subject_to_symptomatic_care(page)
295293

296294
# Younger patient
297-
nhs_no = "9624131880"
295+
nhs_no = "9567180636"
298296
go_to_investigation_datasets_page(page, nhs_no)
299297

300298
# The following code is on the investigation datasets page
@@ -324,7 +322,7 @@ def test_compartment_6(page: Page, smokescreen_properties: dict) -> None:
324322

325323
# This needs to be repeated for two subjects, one old and one not - LNPCP Result
326324
# Older patient
327-
nhs_no = "9648064792"
325+
nhs_no = "9237051190"
328326
go_to_investigation_datasets_page(page, nhs_no)
329327

330328
# The following code is on the investigation datasets page
@@ -339,7 +337,7 @@ def test_compartment_6(page: Page, smokescreen_properties: dict) -> None:
339337
handover_subject_to_symptomatic_care(page)
340338

341339
# Younger patient
342-
nhs_no = "9627060208"
340+
nhs_no = "9564243211"
343341
go_to_investigation_datasets_page(page, nhs_no)
344342

345343
# The following code is on the investigation datasets page
@@ -367,7 +365,7 @@ def test_compartment_6(page: Page, smokescreen_properties: dict) -> None:
367365
)
368366

369367
# This needs to be repeated for 1 subject, age does not matter - Normal Result
370-
nhs_no_normal = "9965184321"
368+
nhs_no_normal = "9648226105"
371369
go_to_investigation_datasets_page(page, nhs_no_normal)
372370

373371
# The following code is on the investigation datasets page

0 commit comments

Comments
 (0)