Update screening_subject_search_page.py

Changed the dropdown option value numbers in the functions to class variables.

Author: Andyg79

pages/screening_subject_search_page.py

@@ -2,6 +2,18 @@
 
 
 class ScreeningStatusSearchOptions:
+    CALL_STATUS = "4001"
+    INACTIVE_STATUS = "4002"
+    RECALL_STATUS = "4004"
+    OPT_IN_STATUS = "4003"
+    SELF_REFERRAL_STATUS = "4005"
+    SURVEILLANCE_STATUS = "4006"
+    SEEKING_FURTHER_DATA_STATUS = "4007"
+    CEASED_STATUS = "4008"
+    BOWEL_SCOPE_STATUS = "4009"
+    LYNCH_SURVEILLANCE_STATUS = "306442"
+    LYNCH_SELF_REFERRAL_STATUS = "307129"
+
     def __init__(self, page: Page):
         self.page = page
 
@@ -10,40 +22,44 @@ def __init__(self, page: Page):
 
     # Select screening status options
     def select_status_call(self):
-        self.select_status.select_option("4001")
+        self.select_status.select_option(self.CALL_STATUS)
 
     def select_status_inactive(self):
-        self.select_status.select_option("4002")
+        self.select_status.select_option(self.INACTIVE_STATUS)
 
     def select_status_recall(self):
-        self.select_status.select_option("4004")
+        self.select_status.select_option(self.RECALL_STATUS)
 
     def select_status_opt_in(self):
-        self.select_status.select_option("4003")
+        self.select_status.select_option(self.OPT_IN_STATUS)
 
     def select_status_self_referral(self):
-        self.select_status.select_option("4005")
+        self.select_status.select_option(self.SELF_REFERRAL_STATUS)
 
     def select_status_surveillance(self):
-        self.select_status.select_option("4006")
+        self.select_status.select_option(self.SURVEILLANCE_STATUS)
 
     def select_status_seeking_further_data(self):
-        self.select_status.select_option("4007")
+        self.select_status.select_option(self.SEEKING_FURTHER_DATA_STATUS)
 
     def select_status_ceased(self):
-        self.select_status.select_option("4008")
+        self.select_status.select_option(self.CEASED_STATUS)
 
     def select_status_bowel_scope(self):
-        self.select_status.select_option("4009")
+        self.select_status.select_option(self.BOWEL_SCOPE_STATUS)
 
     def select_status_lynch_surveillance(self):
-        self.select_status.select_option("306442")
+        self.select_status.select_option(self.LYNCH_SURVEILLANCE_STATUS)
 
     def select_status_lynch_self_referral(self):
-        self.select_status.select_option("307129")
+        self.select_status.select_option(self.LYNCH_SELF_REFERRAL_STATUS)
 
 
 class LatestEpisodeStatusSearchOptions:
+    OPEN_PAUSED_STATUS = "1"
+    CLOSED_STATUS = "2"
+    NO_EPISODE_STATUS = "3"
+
     def __init__(self, page: Page):
         self.page = page
 
@@ -52,16 +68,23 @@ def __init__(self, page: Page):
 
     # Select latest episode status options
     def select_status_open_paused(self):
-        self.select_status.select_option("1")
+        self.select_status.select_option(self.OPEN_PAUSED_STATUS)
 
     def select_status_closed(self):
-        self.select_status.select_option("2")
+        self.select_status.select_option(self.CLOSED_STATUS)
 
     def select_status_no_episode(self):
-        self.select_status.select_option("3")
+        self.select_status.select_option(self.NO_EPISODE_STATUS)
 
 
 class SearchAreaSearchOptions:
+    SEARCH_AREA_HOME_HUB = "01"
+    SEARCH_AREA_GP_PRACTICE = "02"
+    SEARCH_AREA_CCG = "03"
+    SEARCH_AREA_SCREENING_CENTRE = "05"
+    SEARCH_AREA_OTHER_HUB = "06"
+    SEARCH_AREA_WHOLE_DATABASE = "07"
+
     def __init__(self, page: Page):
         self.page = page
 
@@ -70,19 +93,19 @@ def __init__(self, page: Page):
 
     # Select search area options
     def select_search_area_home_hub(self):
-        self.select_area.select_option("01")
+        self.select_area.select_option(self.SEARCH_AREA_HOME_HUB)
 
     def select_search_area_gp_practice(self):
-        self.select_area.select_option("02")
+        self.select_area.select_option(self.SEARCH_AREA_GP_PRACTICE)
 
     def select_search_area_ccg(self):
-        self.select_area.select_option("03")
+        self.select_area.select_option(self.SEARCH_AREA_CCG)
 
     def select_search_area_screening_centre(self):
-        self.select_area.select_option("05")
+        self.select_area.select_option(self.SEARCH_AREA_SCREENING_CENTRE)
 
     def select_search_area_other_hub(self):
-        self.select_area.select_option("06")
+        self.select_area.select_option(self.SEARCH_AREA_OTHER_HUB)
 
     def select_search_area_whole_database(self):
-        self.select_area.select_option("07")
+        self.select_area.select_option(self.SEARCH_AREA_WHOLE_DATABASE)