Added pom for Attend Diagnostic test (#40)

<!-- markdownlint-disable-next-line first-line-heading -->
## Description

Added POM for Attend Diagnostic test page and updated Compartment 5
tests accordingly

## Context

We had some hard coded locators/values in our compartment 5 tests that
have been refactored to use a POM

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [ x] Refactoring (non-breaking change)
- [ x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [ x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [ x] I have followed the code style of the project
- [ ] I have added tests to cover my changes (where appropriate)
- [ ] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x ] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

Author: mepr1

pages/screening_practitioner_appointments/appointment_detail_page.py

@@ -8,15 +8,15 @@ def __init__(self, page: Page):
         self.page = page
         # Appointment Detail - page filters
         self.attendance_radio = self.page.get_by_role("radio", name="Attendance")
-        self.attendented_check_box = self.page.locator("#UI_ATTENDED")
+        self.attended_check_box = self.page.locator("#UI_ATTENDED")
         self.calendar_button = self.page.get_by_role("button", name="Calendar")
-        self.save_button = self.page.get_by_role("button", name="Save").click()
+        self.save_button = self.page.get_by_role("button", name="Save")
 
     def check_attendance_radio(self) -> None:
         self.attendance_radio.check()
 
-    def check_attendented_check_box(self) -> None:
-        self.attendented_check_box.check()
+    def check_attended_check_box(self) -> None:
+        self.attended_check_box.check()
 
     def click_calendar_button(self) -> None:
         self.click(self.calendar_button)

pages/screening_subject_search/attend_diagnostic_test_page.py

@@ -0,0 +1,21 @@
+from playwright.sync_api import Page
+from pages.base_page import BasePage
+
+
+class AttendDiagnosticTest(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        # Advance Diagnostic Test - page locators
+        self.actual_type_of_test_dropdown = self.page.locator("#UI_CONFIRMED_TYPE_OF_TEST")
+        self.calendar_button = self.page.get_by_role("button", name="Calendar")
+        self.save_button =self.page.get_by_role("button", name="Save")
+
+    def select_actual_type_of_test_dropdown_option(self, text: str) -> None:
+        self.actual_type_of_test_dropdown.select_option(label=text)
+
+    def click_calendar_button(self) -> None:
+        self.click(self.calendar_button)
+
+    def click_save_button(self) -> None:
+        self.click(self.save_button)

tests/smokescreen/test_compartment_5.py

@@ -25,6 +25,9 @@
 from pages.screening_practitioner_appointments.appointment_calendar_page import (
     AppointmentCalendar,
 )
+from pages.screening_subject_search.attend_diagnostic_test_page import (
+    AttendDiagnosticTest,
+)
 from utils.user_tools import UserTools
 from utils.load_properties_file import PropertiesFile
 from utils.screening_subject_page_searcher import verify_subject_event_status_by_nhs_no
@@ -81,7 +84,7 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
 
     # Select Attendance radio button, tick Attended checkbox, set Attended Date to yesterday's (system) date and then press Save
     AppointmentDetail(page).check_attendance_radio()
-    AppointmentDetail(page).check_attendented_check_box()
+    AppointmentDetail(page).check_attended_check_box()
     AppointmentDetail(page).click_calendar_button()
     CalendarPicker(page).v1_calender_picker(datetime.today() - timedelta(1))
     AppointmentDetail(page).click_save_button()
@@ -145,10 +148,10 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
     AdvanceFOBTScreeningEpisode(page).click_attend_diagnostic_test_button()
 
     # Select Colonoscopy from drop down list. Enter the actual appointment date as today's date and select 'Save'
-    page.locator("#UI_CONFIRMED_TYPE_OF_TEST").select_option(label="Colonoscopy")
-    page.get_by_role("button", name="Calendar").click()
+    AttendDiagnosticTest.select_actual_type_of_test_dropdown_option("Colonoscopy")
+    AttendDiagnosticTest.click_calendar_button()
     CalendarPicker(page).v1_calender_picker(datetime.today())
-    page.get_by_role("button", name="Save").click()
+    AttendDiagnosticTest.click_save_button()
     SubjectScreeningSummary(page).verify_latest_event_status_value(
         "A259 - Attended Diagnostic Test"
     )