Fixing the calendar util to select the correct day. (#61)

Incresing the performance of the select_day method. Making selecting
today's date a lot quicker.

<!-- markdownlint-disable-next-line first-line-heading -->
## Description

<!-- Describe your changes in detail. -->
Fixing the calendar util to select the correct day.
Incresing the performance of the select_day method.
Making selecting today's date a lot quicker.

## Context

<!-- Why is this change required? What problem does it solve? -->
Increases reliability and performance of the util.

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [x] Refactoring (non-breaking change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [x] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [x] I have followed the code style of the project
- [x] I have added tests to cover my changes (where appropriate)
- [ ] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

Author: adrianoaru-nhs

tests/test_calendar_picker_methods.py

@@ -28,8 +28,8 @@ def test_calender_picker_v1(page: Page) -> None:
     SubjectScreeningPage(page).select_dob_using_calendar_picker(datetime(2020, 3, 30))
     SubjectScreeningPage(page).verify_date_of_birth_filter_input("30/03/2020")
     SubjectScreeningPage(page).click_clear_filters_button()
-    SubjectScreeningPage(page).select_dob_using_calendar_picker(datetime(2020, 6, 15))
-    SubjectScreeningPage(page).verify_date_of_birth_filter_input("15/06/2020")
+    SubjectScreeningPage(page).select_dob_using_calendar_picker(datetime(2019, 11, 27))
+    SubjectScreeningPage(page).verify_date_of_birth_filter_input("27/11/2019")
     SubjectScreeningPage(page).click_clear_filters_button()
     SubjectScreeningPage(page).select_dob_using_calendar_picker(datetime.today())
     SubjectScreeningPage(page).verify_date_of_birth_filter_input(

utils/calendar_picker.py

@@ -18,6 +18,7 @@ def __init__(self, page: Page):
         self.v1_calendar_current_date = self.page.locator(
             'td.title[colspan="5"][style="cursor: move;"]'
         )
+        self.v1_today_button = self.page.get_by_text("Today", exact=True)
         # V2 Calendar picker locators
         self.v2date_picker_switch = self.page.locator(
             'th.datepicker-switch[colspan="5"]:visible'
@@ -127,18 +128,20 @@ def select_day(self, date: datetime) -> None:
             "cell", name=day_to_select
         ).count()
 
-        all_days = self.page.locator(".day").all()
+        all_matching_days = self.page.get_by_role(
+            "cell", name=day_to_select, exact=True
+        ).all()
 
         matching_days = [
             day
-            for day in all_days
+            for day in all_matching_days
             if day.evaluate("el => el.textContent.trim()") == day_to_select
         ]
 
         if int(day_to_select) < 15 and number_of_cells_with_day > 1:
             self.click(matching_days[0].first)
         elif int(day_to_select) > 15 and number_of_cells_with_day > 1:
-            self.click(matching_days[0].last)
+            self.click(matching_days[-1].last)
         else:
             self.click(matching_days[0])
 
@@ -150,6 +153,13 @@ def v1_calender_picker(self, date: datetime) -> None:
         Args:
             date (datetime): The date we want to select
         """
+
+        if DateTimeUtils.format_date(date, "%d/%m/%Y") == DateTimeUtils.format_date(
+            datetime.today(), "%d/%m/%Y"
+        ):
+            self.click(self.v1_today_button)
+            return
+
         current_date = datetime.strptime(
             self.v1_calendar_current_date.inner_text(), "%B, %Y"
         )