moved a few values into the properties file

Author: adrianoaru-nhs

tests/smokescreen/bcss_smokescreen_tests.properties

@@ -32,6 +32,13 @@
     c4_eng_site_name2=The Royal Hospital (Wolverhampton)
     c4_eng_practitioner_name=Astonish, Ethanol
 
+# ----------------------------------
+#   compartment 5
+# ----------------------------------
+    c5_eng_appointment_type=Colonoscopy Assessment
+    c5_eng_screening_centre=BCS001 - Wolverhampton Bowel Cancer Screening Centre
+    c5_eng_site=(all)
+
 # ----------------------------------
 #   compartment 6
 # ----------------------------------
@@ -78,7 +85,7 @@
 # ----------------------------------
 #   compartment 5
 # ----------------------------------
-#    c5_eng_number_of_screening_appts_to_attend=6
+#    c5_eng_number_of_screening_appts_to_attend=5
 
 # ----------------------------------
 #   compartment 6

tests/smokescreen/test_compartment_5.py

@@ -56,11 +56,15 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
     ScreeningPractitionerAppointmentsPage(page).go_to_view_appointments_page()
 
     # Select the Appointment Type, Site, Screening Practitioner and required date of the appointment and click 'View appointments on this day' button
-    AppointmentCalendar(page).select_appointment_type_dropdown("Colonoscopy Assessment")
+    AppointmentCalendar(page).select_appointment_type_dropdown(
+        smokescreen_properties["c5_eng_appointment_type"]
+    )
     AppointmentCalendar(page).select_screening_centre_dropdown(
-        "BCS001 - Wolverhampton Bowel Cancer Screening Centre"
+        smokescreen_properties["c5_eng_screening_centre"]
+    )
+    AppointmentCalendar(page).select_site_dropdown(
+        smokescreen_properties["c5_eng_site"]
     )
-    AppointmentCalendar(page).select_site_dropdown("(all)")
 
     AppointmentCalendar(page).click_view_appointments_on_this_day_button()
     ScreeningPractitionerDayView(page).click_calendar_button()