Added POM for Subject Datasets and updated Compartment 5 tests accord… (#39)

<!-- markdownlint-disable-next-line first-line-heading -->
## Description
Added POM for Subject Datasets and updated Compartment 5 tests
accordingly

<!-- Describe your changes in detail. -->

## Context
We had some hard coded locators/values in our compartment 5 tests that
have been refactored to use a POM

<!-- Why is this change required? What problem does it solve? -->

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [x] Refactoring (non-breaking change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [x] I have followed the code style of the project
- [ ] I have added tests to cover my changes (where appropriate)
- [ ] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

---------

Signed-off-by: AndyG <[email protected]>
Co-authored-by: adrianoaru-nhs <[email protected]>

Author: Andyg79

pages/screening_practitioner_appointments/subject_datasets.py

@@ -0,0 +1,55 @@
+from playwright.sync_api import Page, expect
+from pages.base_page import BasePage
+from enum import Enum
+
+
+class SubjectDatasets(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+
+        self.show_dataset_button = self.page.get_by_role("link", name="Show Dataset")
+
+        self.save_dataset_button = self.page.locator(
+            "#UI_DIV_BUTTON_SAVE1"
+        ).get_by_role("button", name="Save Dataset")
+
+        self.select_asa_grade_dropdown = self.page.get_by_label("ASA Grade")
+
+        self.select_fit_for_colonoscopy_dropdown = self.page.get_by_label(
+            "Fit for Colonoscopy (SSP)"
+        )
+
+        self.dataset_complete_radio_button_yes = self.page.get_by_role(
+            "radio", name="Yes"
+        )
+
+        self.dataset_complete_radio_button_no = self.page.get_by_role(
+            "radio", name="No"
+        )
+
+    def click_show_datasets(self) -> None:
+        self.click(self.show_dataset_button)
+
+    def save_dataset(self) -> None:
+        self.click(self.save_dataset_button)
+
+    def select_asa_grade_option(self, option: str) -> None:
+        self.select_asa_grade_dropdowen.select_option(option)
+
+    def select_fit_for_colonoscopy_option(self, option: str) -> None:
+        self.select_fit_for_colonoscopy_dropdown.select_option(option)
+
+    def click_dataset_complete_radio_button_yes(self) -> None:
+        self.dataset_complete_radio_button_yes.check()
+
+    def click_dataset_complete_radio_button_no(self) -> None:
+        self.dataset_complete_radio_button_no.check()
+
+
+class AsaGradeOptions(Enum):
+    FIT = "17009"
+
+
+class FitForColonoscopySspOptions(Enum):
+    YES = "17058"

tests/smokescreen/test_compartment_5.py

@@ -5,6 +5,11 @@
 from pages.screening_practitioner_appointments.screening_practitioner_appointments import (
     ScreeningPractitionerAppointmentsPage,
 )
+from pages.screening_practitioner_appointments.subject_datasets import (
+    SubjectDatasets,
+    FitForColonoscopySspOptions,
+    AsaGradeOptions,
+)
 from pages.screening_subject_search.subject_screening_summary import (
     SubjectScreeningSummary,
 )
@@ -94,22 +99,25 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
     SubjectScreeningSummary(page).click_datasets_link()
 
     # Click on 'Show Dataset' next to the Colonoscopy Assessment
+    SubjectDatasets(page).click_show_datasets()
 
     # Populate Colonoscopy Assessment Details fields
 
     # ASA Grade  - I - Fit
+    SubjectDatasets(page).select_asa_grade_option(AsaGradeOptions.FIT.value)
+
     # Fit for Colonoscopy (SSP) - Yes
+    SubjectDatasets(page).select_fit_for_colonoscopy_option(
+        FitForColonoscopySspOptions.YES.value
+    )
 
     # Click 'Yes' for Dataset Complete?
+    SubjectDatasets(page).click_dataset_complete_radio_button_yes()
+
     # Click Save Dataset button
+    SubjectDatasets(page).save_dataset()
+
     # Click Back
-    page.get_by_role("link", name="Show Dataset").click()
-    page.get_by_label("ASA Grade").select_option("17009")
-    page.get_by_label("Fit for Colonoscopy (SSP)").select_option("17058")
-    page.get_by_role("radio", name="Yes").check()
-    page.locator("#UI_DIV_BUTTON_SAVE1").get_by_role(
-        "button", name="Save Dataset"
-    ).click()
     BasePage(page).click_back_button()
     BasePage(page).click_back_button()
     # This brings you back to the subject screening summary page