Converting hard coded locators in tests/test_lynch_surveillance_page.py into POMs

Author: adrianoaru-nhs

pages/lynch_invitation_page.py

@@ -0,0 +1,12 @@
+from playwright.sync_api import Page, expect
+from pages.base_page import BasePage
+
+class LynchInvitationPage(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        # Lynch Invitation Page - Links
+        self.set_lynch_invitation_rates_link = self.page.get_by_role("link", name="Set Lynch Invitation Rates")
+
+    def click_set_lynch_invitation_rates_link(self)->None:
+        self.click(self.set_lynch_invitation_rates_link)

pages/set_lynch_invitation_rates_page.py

@@ -0,0 +1,12 @@
+from playwright.sync_api import Page, expect
+from pages.base_page import BasePage
+
+class SetLynchInvitationRatesPage(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        # Lynch Invitation Page - Links
+        self.set_lynch_invitation_rates_title = self.page.locator("#page-title")
+
+    def verify_set_lynch_invitation_rates_title(self)->None:
+        expect(self.set_lynch_invitation_rates_title).to_contain_text("Set Lynch Surveillance Invitation Rates")

tests/test_lynch_surveillance_page.py

@@ -1,10 +1,10 @@
 import pytest
-from playwright.sync_api import Page, expect
-from utils.click_helper import click
+from playwright.sync_api import Page
 from pages.base_page import BasePage
+from pages.lynch_invitation_page import LynchInvitationPage
+from pages.set_lynch_invitation_rates_page import SetLynchInvitationRatesPage
 from utils.user_tools import UserTools
 
-
 @pytest.fixture(scope="function", autouse=True)
 def before_each(page: Page):
     """
@@ -17,17 +17,16 @@ def before_each(page: Page):
     # Go to Lynch Surveillance page
     BasePage(page).go_to_lynch_surveillance_page()
 
-
 @pytest.mark.smoke
 def test_lynch_surveillance_page_navigation(page: Page) -> None:
     """
     Confirms that the 'set lynch invitation rates' link is visible and clickable, and navigates to the
     expected page when clicked
     """
     # 'Set lynch invitation rates' page loads as expected
-    click(page, page.get_by_role("link", name="Set Lynch Invitation Rates"))
-    expect(page.locator("#page-title")).to_contain_text("Set Lynch Surveillance Invitation Rates")
+    LynchInvitationPage(page).click_set_lynch_invitation_rates_link()
+    SetLynchInvitationRatesPage(page).verify_set_lynch_invitation_rates_title()
 
     # Return to main menu
-    click(page, page.get_by_role("link", name="Main Menu"))
-    expect(page.locator("#ntshPageTitle")).to_contain_text("Main Menu")
+    BasePage(page).click_main_menu_link()
+    BasePage(page).main_menu_header_is_displayed()