Feature/bcss 20023–write an if statement for page title contains text functions (#18)

<!-- markdownlint-disable-next-line first-line-heading -->
## Description

<!-- Describe your changes in detail. -->

## Context

Refactored both methods that verify the text of the bcss screening page
titles into one method.

<!-- Why is this change required? What problem does it solve? -->

## Type of changes

Removes repetition as two methods are doing the same thing.

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [x] Refactoring (non-breaking change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [x] I have followed the code style of the project
- [ ] I have added tests to cover my changes (where appropriate)
- [ ] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

---------

Co-authored-by: adrianoaru-nhs <[email protected]>
Co-authored-by: Adriano Aru <[email protected]>

Author: victor-soares-ibm

pages/base_page.py

@@ -95,17 +95,17 @@ def bowel_cancer_screening_page_title_contains_text(self, text: str) -> None:
         """Asserts that the page title contains the specified text.
 
         Args:
-            text (str): The expected text that you want to assert for the page title ("#page-title") element.
+            text (str): The expected text that you want to assert for the page title element.
+        Page elements of interest:
+            self.bowel_cancer_screening_page_title
+            self.bowel_cancer_screening_ntsh_page_title
         """
-        expect(self.bowel_cancer_screening_page_title).to_contain_text(text)
-
-    def bowel_cancer_screening_ntsh_page_title_contains_text(self, text: str) -> None:
-        """Asserts that the page title contains the specified text.
-
-        Args:
-            text (str): The expected text that you want to assert for the page title ("#ntshPageTitle") element.
-        """
-        expect(self.bowel_cancer_screening_ntsh_page_title).to_contain_text(text)
+        self.page.wait_for_load_state("load")
+        self.page.wait_for_load_state("domcontentloaded")
+        if self.bowel_cancer_screening_page_title.is_visible():
+            expect(self.bowel_cancer_screening_page_title).to_contain_text(text)
+        else:
+            expect(self.bowel_cancer_screening_ntsh_page_title).to_contain_text(text)
 
     def go_to_contacts_list_page(self) -> None:
         self.click(self.contacts_list_page)

tests/test_organisations_page.py

@@ -36,21 +36,19 @@ def test_organisations_page_navigation(page: Page) -> None:
     """
     # Screening centre parameters page loads as expected
     OrganisationsPage(page).go_to_screening_centre_parameters_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Screening Centre Parameters"
     )
     BasePage(page).click_back_button()
 
     # Organisation parameters page loads as expected
     OrganisationsPage(page).go_to_organisation_parameters_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
-        "System Parameters"
-    )
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("System Parameters")
     BasePage(page).click_back_button()
 
     # Organisation and site details page loads as expected
     OrganisationsPage(page).go_to_organisations_and_site_details_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Organisation and Site Details"
     )
     BasePage(page).click_back_button()
@@ -61,13 +59,13 @@ def test_organisations_page_navigation(page: Page) -> None:
 
     # GP practice endorsement page loads as expected
     OrganisationsPage(page).go_to_gp_practice_endorsement_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "GP Practice Endorsement"
     )
 
     # Return to main menu
     BasePage(page).click_main_menu_link()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text("Main Menu")
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("Main Menu")
 
 
 def test_view_an_organisations_system_parameters(
@@ -81,6 +79,4 @@ def test_view_an_organisations_system_parameters(
 
     # View an Organisation
     page.get_by_role("link", name=general_properties["screening_centre_code"]).click()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
-        "System Parameters"
-    )
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("System Parameters")

tests/test_reports_page.py

@@ -39,28 +39,24 @@ def test_reports_page_navigation(page: Page) -> None:
 
     # Failsafe reports page opens as expected
     ReportsPage(page).go_to_failsafe_reports_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
-        "Failsafe Reports"
-    )
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("Failsafe Reports")
     BasePage(page).click_back_button()
 
     # Operational reports page opens as expected
     ReportsPage(page).go_to_operational_reports_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Operational Reports"
     )
     BasePage(page).click_back_button()
 
     # Strategic reports page opens as expected
     ReportsPage(page).go_to_strategic_reports_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
-        "Strategic Reports"
-    )
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("Strategic Reports")
     BasePage(page).click_back_button()
 
     # "Cancer waiting times reports" page opens as expected
     ReportsPage(page).go_to_cancer_waiting_times_reports_page()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Cancer Waiting Times Reports"
     )
     BasePage(page).click_back_button()
@@ -75,7 +71,7 @@ def test_reports_page_navigation(page: Page) -> None:
 
     # Return to main menu
     BasePage(page).click_main_menu_link()
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text("Main Menu")
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("Main Menu")
 
 
 # Failsafe Reports
@@ -93,7 +89,7 @@ def test_failsafe_reports_date_report_last_requested(page: Page) -> None:
     ReportsPage(page).go_to_date_report_last_requested_page()
 
     # Verify 'Date Report Last Requested' is the page title
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Date Report Last Requested"
     )
 
@@ -140,7 +136,7 @@ def test_failsafe_reports_screening_subjects_with_inactive_open_episode(
     nhs_number_link.click()
 
     # Verify "Subject Screening Summary" is the page title
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Subject Screening Summary"
     )
 
@@ -183,7 +179,7 @@ def test_failsafe_reports_subjects_ceased_due_to_date_of_birth_changes(
     nhs_number_link.click()
 
     # Verify page title is "Subject Demographic"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Subject Demographic"
     )
 
@@ -211,7 +207,7 @@ def test_failsafe_reports_allocate_sc_for_patient_movements_within_hub_boundarie
     failsafe_report_page.go_to_allocate_sc_for_patient_movements_within_hub_boundaries_page()
 
     # Verify page title is "Allocate SC for Patient Movements within Hub Boundaries"
-    failsafe_report_page.bowel_cancer_screening_ntsh_page_title_contains_text(
+    failsafe_report_page.bowel_cancer_screening_page_title_contains_text(
         "Allocate SC for Patient Movements within Hub Boundaries"
     )
 
@@ -226,7 +222,7 @@ def test_failsafe_reports_allocate_sc_for_patient_movements_within_hub_boundarie
     nhs_number_link.click()
 
     # Verify page title is "Set Patient's Screening Centre"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Set Patient's Screening Centre"
     )
 
@@ -262,7 +258,7 @@ def test_failsafe_reports_allocate_sc_for_patient_movements_into_your_hub(
     ReportsPage(page).go_to_allocate_sc_for_patient_movements_into_your_hub_page()
 
     # Verify page title is "Date Report Last Requested"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Allocate SC for Patient Movements into your Hub"
     )
 
@@ -302,7 +298,7 @@ def test_failsafe_reports_identify_and_link_new_gp(page: Page) -> None:
     ReportsPage(page).go_to_identify_and_link_new_gp_page()
 
     # Verify page title is "Identify and link new GP practices"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Identify and link new GP practices"
     )
 
@@ -324,7 +320,7 @@ def test_failsafe_reports_identify_and_link_new_gp(page: Page) -> None:
     nhs_number_cell_link.click()
 
     # Verify page title is "Link GP practice to Screening Centre"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Link GP practice to Screening Centre"
     )
 
@@ -354,7 +350,7 @@ def test_operational_reports_appointment_attendance_not_updated(
     ReportsPage(page).go_to_appointment_attendance_not_updated_page()
 
     # Verify page title is "Appointment Attendance Not Updated"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Appointment Attendance Not Updated"
     )
 
@@ -374,9 +370,7 @@ def test_operational_reports_appointment_attendance_not_updated(
     nhs_number_link.click()
 
     # Verify the page title is "Appointment Detail"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
-        "Appointment Detail"
-    )
+    BasePage(page).bowel_cancer_screening_page_title_contains_text("Appointment Detail")
 
 
 def test_operational_reports_fobt_kits_logged_but_not_read(page: Page) -> None:
@@ -453,7 +447,7 @@ def test_operational_reports_screening_practitioner_6_weeks_availability_not_set
     ).go_to_screening_practitioner_6_weeks_availability_not_set_up_report_page()
 
     # Verify page title is "Screening Practitioner 6 Weeks Availability Not Set Up"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Screening Practitioner 6 Weeks Availability Not Set Up"
     )
 
@@ -502,7 +496,7 @@ def test_operational_reports_screening_practitioner_appointments(
     ReportsPage(page).go_to_screening_practitioner_appointments_page()
 
     # Verify page title is "Screening Practitioner Appointments"
-    BasePage(page).bowel_cancer_screening_ntsh_page_title_contains_text(
+    BasePage(page).bowel_cancer_screening_page_title_contains_text(
         "Screening Practitioner Appointments"
     )