worked on review comments #6 (comment)

Author: mepr1

pages/batch_list_page.py

@@ -17,38 +17,38 @@ def __init__(self, page: Page):
         self.table_data = self.page.locator("td")
         self.batch_successfully_archived_msg = self.page.locator('text="Batch Successfully Archived and Printed"')
 
-    def verify_table_data(self, value):
+    def verify_table_data(self, value)->None:
         expect(self.table_data.filter(has_text=value)).to_be_visible()
 
-    def enter_id_filter(self, search_text: str):
+    def enter_id_filter(self, search_text: str)->None:
         self.id_filter.fill(search_text)
         self.id_filter.press("Enter")
 
-    def enter_type_filter(self, search_text: str):
+    def enter_type_filter(self, search_text: str)->None:
         self.type_filter.fill(search_text)
         self.type_filter.press("Enter")
 
-    def enter_original_filter(self, search_text: str):
+    def enter_original_filter(self, search_text: str)->None:
         self.original_filter.fill(search_text)
         self.original_filter.press("Enter")
 
-    def enter_event_code_filter(self, search_text: str):
+    def enter_event_code_filter(self, search_text: str)->None:
         self.event_code_filter.fill(search_text)
         self.event_code_filter.press("Enter")
 
-    def enter_description_filter(self, search_text: str):
+    def enter_description_filter(self, search_text: str)->None:
         self.description_filter.fill(search_text)
         self.description_filter.press("Enter")
 
-    def enter_batch_split_by_filter(self, search_text: str):
+    def enter_batch_split_by_filter(self, search_text: str)->None:
         self.batch_split_by_filter.fill(search_text)
         self.batch_split_by_filter.press("Enter")
 
-    def enter_screening_centre_filter(self, search_text: str):
+    def enter_screening_centre_filter(self, search_text: str)->None:
         self.screening_centre_filter.fill(search_text)
         self.screening_centre_filter.press("Enter")
 
-    def enter_count_filter(self, search_text: str):
+    def enter_count_filter(self, search_text: str)->None:
         self.count_filter.fill(search_text)
         self.count_filter.press("Enter")
 

pages/bcss_home_page.py

@@ -17,31 +17,31 @@ def __init__(self, page: Page):
         # Bowel Cancer Screening System header
         self.bowel_cancer_screening_system_header = self.page.locator("#ntshAppTitle")
 
-    def click_sub_menu_link(self):
+    def click_sub_menu_link(self)->None:
         click(self.page, self.sub_menu_link)
 
-    def click_hide_sub_menu_link(self):
+    def click_hide_sub_menu_link(self)->None:
         click(self.page, self.hide_sub_menu_link)
 
-    def click_select_org_link(self):
+    def click_select_org_link(self)->None:
         click(self.page, self.select_org_link)
 
-    def click_back_button(self):
+    def click_back_button(self)->None:
         click(self.page, self.back_button)
 
-    def click_release_notes_link(self):
+    def click_release_notes_link(self)->None:
         click(self.page, self.release_notes_link)
 
-    def click_refresh_alerts_link(self):
+    def click_refresh_alerts_link(self)->None:
         click(self.page, self.refresh_alerts_link)
 
-    def click_user_guide_link(self):
+    def click_user_guide_link(self)->None:
         click(self.page, self.user_guide_link)
 
-    def click_help_link(self):
+    def click_help_link(self)->None:
         click(self.page, self.help_link)
 
-    def bowel_cancer_screening_system_header_is_displayed(self):
+    def bowel_cancer_screening_system_header_is_displayed(self)->None:
         expect(self.bowel_cancer_screening_system_header).to_contain_text("Bowel Cancer Screening System")
 
 
@@ -62,38 +62,38 @@ def __init__(self, page: Page):
         self.screening_practitioner_appointments_page = self.page.get_by_role("link", name="Screening Practitioner")
         self.screening_subject_search_page = self.page.get_by_role("link", name="Screening Subject Search")
 
-    def go_to_contacts_list_page(self):
+    def go_to_contacts_list_page(self)->None:
         click(self.page, self.contacts_list_page)
 
-    def go_to_bowel_scope_page(self):
+    def go_to_bowel_scope_page(self)->None:
         click(self.page, self.bowel_scope_page)
 
-    def go_to_call_and_recall_page(self):
+    def go_to_call_and_recall_page(self)->None:
         click(self.page, self.call_and_recall_page)
 
-    def go_to_communications_production_page(self):
+    def go_to_communications_production_page(self)->None:
         click(self.page, self.communications_production_page)
 
-    def go_to_download_page(self):
+    def go_to_download_page(self)->None:
         click(self.page, self.download_page)
 
-    def go_to_fit_test_kits_page(self):
+    def go_to_fit_test_kits_page(self)->None:
         click(self.page, self.fit_test_kits_page)
 
-    def go_to_gfob_test_kits_page(self):
+    def go_to_gfob_test_kits_page(self)->None:
         click(self.page, self.gfob_test_kits_page)
 
-    def go_to_lynch_surveillance_page(self):
+    def go_to_lynch_surveillance_page(self)->None:
         click(self.page, self.lynch_surveillance_page)
 
-    def go_to_organisations_page(self):
+    def go_to_organisations_page(self)->None:
         click(self.page, self.organisations_page)
 
-    def go_to_reports_page(self):
+    def go_to_reports_page(self)->None:
         click(self.page, self.reports_page)
 
-    def go_to_screening_practitioner_appointments_page(self):
+    def go_to_screening_practitioner_appointments_page(self)->None:
         click(self.page, self.screening_practitioner_appointments_page)
 
-    def go_to_screening_subject_search_page(self):
+    def go_to_screening_subject_search_page(self)->None:
         click(self.page, self.screening_subject_search_page)

pages/call_and_recall_page.py

@@ -12,17 +12,17 @@ def __init__(self, page: Page):
         self.non_invitation_days_page = self.page.get_by_role("link", name="Non Invitation Days")
         self.age_extension_rollout_plans_page = self.page.get_by_role("link", name="Age Extension Rollout Plans")
 
-    def go_to_planning_and_monitoring_page(self):
+    def go_to_planning_and_monitoring_page(self)->None:
         click(self.page, self.planning_and_monitoring_page)
 
-    def go_to_generate_invitations_page(self):
+    def go_to_generate_invitations_page(self)->None:
         click(self.page, self.generate_invitations_page)
 
-    def go_to_invitation_generation_progress_page(self):
+    def go_to_invitation_generation_progress_page(self)->None:
         click(self.page, self.invitation_generation_progress_page)
 
-    def go_to_non_invitation_days_page(self):
+    def go_to_non_invitation_days_page(self)->None:
         click(self.page, self.non_invitation_days_page)
 
-    def go_to_age_extension_rollout_plans_page(self):
+    def go_to_age_extension_rollout_plans_page(self)->None:
         click(self.page, self.age_extension_rollout_plans_page)

pages/communications_production_page.py

@@ -12,17 +12,17 @@ def __init__(self, page: Page):
         self.letter_signatory_page = self.page.get_by_role("link", name="Letter Signatory")
         self.electronic_communication_management_page = self.page.get_by_role("link", name="Electronic Communication Management")
 
-    def go_to_active_batch_list_page(self):
+    def go_to_active_batch_list_page(self)->None:
         click(self.page, self.active_batch_list_page)
 
-    def go_to_archived_batch_list_page(self):
+    def go_to_archived_batch_list_page(self)->None:
         click(self.page, self.archived_batch_list_page)
 
-    def go_to_letter_library_index_page(self):
+    def go_to_letter_library_index_page(self)->None:
         click(self.page, self.letter_library_index_page)
 
-    def go_to_letter_signatory_page(self):
+    def go_to_letter_signatory_page(self)->None:
         click(self.page, self.letter_signatory_page)
 
-    def go_to_electronic_communication_management_page(self):
+    def go_to_electronic_communication_management_page(self)->None:
         click(self.page, self.electronic_communication_management_page)

pages/contacts_list_page.py

@@ -11,14 +11,14 @@ def __init__(self, page: Page):
         self.maintain_contacts_page = self.page.get_by_role("link", name="Maintain Contacts")
         self.my_preference_settings_page = self.page.get_by_role("link", name="My Preference Settings")
 
-    def go_to_view_contacts_page(self):
+    def go_to_view_contacts_page(self)->None:
         click(self.page, self.view_contacts_page)
 
-    def go_to_edit_my_contact_details_page(self):
+    def go_to_edit_my_contact_details_page(self)->None:
         click(self.page, self.edit_my_contact_details_page)
 
-    def go_to_maintain_contacts_details_page(self):
+    def go_to_maintain_contacts_details_page(self)->None:
         click(self.page, self.maintain_contacts_page)
 
-    def go_to_my_preference_settings_page(self):
+    def go_to_my_preference_settings_page(self)->None:
         click(self.page, self.my_preference_settings_page)

pages/create_a_plan_page.py

@@ -15,26 +15,26 @@ def __init__(self, page: Page):
         self.note_field = self.page.get_by_placeholder("Enter note")
         self.save_note_button = self.page.locator("#saveNote").get_by_role("button", name="Save")
 
-    def click_set_all_button(self):
+    def click_set_all_button(self)->None:
         click(self.page, self.set_all_button)
 
-    def fill_daily_invitation_rate_field(self, value: str):
+    def fill_daily_invitation_rate_field(self, value: str)->None:
         self.daily_invitation_rate_field.fill(value)
 
-    def fill_weekly_invitation_rate_field(self, value):
+    def fill_weekly_invitation_rate_field(self, value)->None:
         self.weekly_invitation_rate_field.fill(value)
 
-    def click_update_button(self):
+    def click_update_button(self)->None:
         click(self.page, self.update_button)
 
-    def click_confirm_button(self):
+    def click_confirm_button(self)->None:
         click(self.page, self.confirm_button)
 
-    def click_save_button(self):
+    def click_save_button(self)->None:
         click(self.page, self.save_button)
 
-    def fill_note_field(self, value):
+    def fill_note_field(self, value)->None:
         self.note_field.fill(value)
 
-    def click_save_note_button(self):
+    def click_save_note_button(self)->None:
         click(self.page, self.save_note_button)

pages/downloads_page.py

@@ -11,14 +11,14 @@ def __init__(self, page: Page):
         self.batch_download_request_and_page = self.page.get_by_role("link", name="Batch Download Request and")
         self.list_of_batch_downloads_page = self.page.get_by_role("cell", name="List of Batch Downloads", exact=True)
 
-    def go_to_individual_download_request_page(self):
+    def go_to_individual_download_request_page(self)->None:
         click(self.page, self.individual_download_request_page)
 
-    def go_to_list_of_individual_downloads_page(self):
+    def go_to_list_of_individual_downloads_page(self)->None:
         click(self.page, self.list_of_individual_downloads_page)
 
-    def go_to_batch_download_request_and_page(self):
+    def go_to_batch_download_request_and_page(self)->None:
         click(self.page, self.batch_download_request_and_page)
 
-    def go_to_list_of_batch_downloads_page(self):
+    def go_to_list_of_batch_downloads_page(self)->None:
         click(self.page, self.list_of_batch_downloads_page)

pages/fit_test_kits_page.py

@@ -18,35 +18,35 @@ def __init__(self, page: Page):
         self.maintain_analysers_page = self.page.get_by_role("link", name="Maintain Analysers")
         self.fit_device_id = self.page.get_by_role("textbox", name="FIT Device ID")
 
-    def go_to_fit_rollout_summary_page(self):
+    def go_to_fit_rollout_summary_page(self)->None:
         click(self.page, self.fit_rollout_summary_page)
 
-    def go_to_log_devices_page(self):
+    def go_to_log_devices_page(self)->None:
         click(self.page, self.log_devices_page)
 
-    def go_to_view_fit_kit_result(self):
+    def go_to_view_fit_kit_result(self)->None:
         click(self.page, self.view_fit_kit_result_page)
 
-    def go_to_kit_service_management(self):
+    def go_to_kit_service_management(self)->None:
         click(self.page, self.kit_service_management_page)
 
-    def go_to_kit_result_audit(self):
+    def go_to_kit_result_audit(self)->None:
         click(self.page, self.kit_result_audit_page)
 
-    def go_to_view_algorithm(self):
+    def go_to_view_algorithm(self)->None:
         click(self.page, self.view_algorithm_page)
 
-    def go_to_view_screening_centre_fit(self):
+    def go_to_view_screening_centre_fit(self)->None:
         click(self.page, self.view_screening_centre_fit_page)
 
-    def go_to_screening_incidents_list(self):
+    def go_to_screening_incidents_list(self)->None:
         click(self.page, self.screening_incidents_list_page)
 
-    def go_to_manage_qc_products(self):
+    def go_to_manage_qc_products(self)->None:
         click(self.page, self.manage_qc_products_page)
 
-    def go_to_maintain_analysers(self):
+    def go_to_maintain_analysers(self)->None:
         click(self.page, self.maintain_analysers_page)
 
-    def go_to_fit_device_id(self):
-        self.fit_device_id.enter()
+    def go_to_fit_device_id(self)->None:
+        click(self.page, self.fit_device_id)

pages/generate_invitations_page.py

@@ -14,10 +14,10 @@ def __init__(self, page: Page):
         self.planned_invitations_total = self.page.locator("#col8_total")
         self.self_referrals_total = self.page.locator("#col9_total")
 
-    def click_generate_invitations_button(self):
+    def click_generate_invitations_button(self)->None:
         click(self.page, self.generate_invitations_button)
 
-    def click_refresh_button(self):
+    def click_refresh_button(self)->None:
         click(self.page, self.refresh_button)
 
     def wait_for_invitation_generation_complete(self) -> bool:

pages/invitations_monitoring_page.py

@@ -5,5 +5,5 @@ class InvitationsMonitoring:
     def __init__(self, page: Page):
         self.page = page
 
-    def go_to_invitation_plan_page(self, sc_id):
+    def go_to_invitation_plan_page(self, sc_id)->None:
         self.page.get_by_role("link", name=sc_id).click()