Added POM for appointment detail page (#36)

<!-- markdownlint-disable-next-line first-line-heading -->
## Description

<!-- Describe your changes in detail. -->
Added a new POM for the appointment detail page and replaced hard coded
locators in compartment 5.

## Context

<!-- Why is this change required? What problem does it solve? -->
New POM that can be used across multiple tests without reusing locators

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [x] Refactoring (non-breaking change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [x] I have followed the code style of the project
- [ ] I have added tests to cover my changes (where appropriate)
- [ ] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

Author: adrianoaru-nhs

pages/screening_subject_search/appointment_detail_page.py

@@ -0,0 +1,28 @@
+from playwright.sync_api import Page, expect
+from pages.base_page import BasePage
+
+
+class AppointmentDetail(BasePage):
+    def __init__(self, page: Page):
+        super().__init__(page)
+        self.page = page
+        # Appointment Detail - page filters
+        self.attendance_radio = self.page.get_by_role("radio", name="Attendance")
+        self.attendented_check_box = self.page.locator("#UI_ATTENDED")
+        self.calendar_button = self.page.get_by_role("button", name="Calendar")
+        self.save_button = self.page.get_by_role("button", name="Save").click()
+
+    def check_attendance_radio(self) -> None:
+        self.attendance_radio.check()
+
+    def check_attendented_check_box(self) -> None:
+        self.attendented_check_box.check()
+
+    def click_calendar_button(self) -> None:
+        self.click(self.calendar_button)
+
+    def click_save_button(self) -> None:
+        self.click(self.save_button)
+
+    def verify_text_visible(self, text: str) -> None:
+        expect(self.page.get_by_text(text)).to_be_visible()

tests/smokescreen/test_compartment_5.py

@@ -14,6 +14,7 @@
 from pages.screening_practitioner_appointments.screening_practitioner_day_view import (
     ScreeningPractitionerDayView,
 )
+from pages.screening_subject_search.appointment_detail_page import AppointmentDetail
 from utils.user_tools import UserTools
 from utils.load_properties_file import PropertiesFile
 from utils.screening_subject_page_searcher import verify_subject_event_status_by_nhs_no
@@ -65,12 +66,12 @@ def test_compartment_5(page: Page, smokescreen_properties: dict) -> None:
     ScreeningPractitionerDayView(page).click_patient_link("STARLESS BLUSH")
 
     # Select Attendance radio button, tick Attended checkbox, set Attended Date to yesterday's (system) date and then press Save
-    page.get_by_role("radio", name="Attendance").check()
-    page.locator("#UI_ATTENDED").check()
-    page.get_by_role("button", name="Calendar").click()
+    AppointmentDetail(page).check_attendance_radio()
+    AppointmentDetail(page).check_attendented_check_box()
+    AppointmentDetail(page).click_calendar_button()
     CalendarPicker(page).v1_calender_picker(datetime.today() - timedelta(1))
-    page.get_by_role("button", name="Save").click()
-    expect(page.get_by_text("Record updated")).to_be_visible()
+    AppointmentDetail(page).click_save_button()
+    AppointmentDetail(page).verify_text_visible("Record updated")
 
     # Repeat for x Abnormal  patients