Skip to content

Commit c8dfc34

Browse files
As per PR # 98 review comments, code change is implemented.
1 parent 32aef6f commit c8dfc34

File tree

4 files changed

+6
-13
lines changed

4 files changed

+6
-13
lines changed

pages/organisations/organisations_page.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def go_to_bureau_page(self) -> None:
5353

5454

5555
class OrganisationSwitchPage:
56-
"""Organisation Switch Page locators and methods for interacting with the page."""
56+
"""Organisation Switch Page locators and methods for interacting with the page"""
5757

5858
def __init__(self, page: Page):
5959
self.page = page
@@ -67,8 +67,8 @@ def __init__(self, page: Page):
6767
def get_available_organisation_ids(self) -> list[str]:
6868
radios = self.page.locator(self.RADIO_SELECTOR)
6969
org_ids = []
70-
for i in range(radios.count()):
71-
org_id = radios.nth(i).get_attribute("id")
70+
for int in range(radios.count()):
71+
org_id = radios.nth(int).get_attribute("id")
7272
if org_id:
7373
org_ids.append(org_id)
7474
return org_ids

tests/regression/organisation_regression_tests_user/test_change_organisation_regression_user.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77

88
@pytest.mark.regression
9-
@pytest.mark.organisation_switch
109
def test_user_can_switch_between_organisations(page: Page) -> None:
1110
"""
1211
Feature: Change Organisation
@@ -17,7 +16,7 @@ def test_user_can_switch_between_organisations(page: Page) -> None:
1716
Then I will be logged in as the alternative organisation.
1817
"""
1918
# Log in as a user with multiple organisations
20-
UserTools.user_login(page, "Specialist Screening Practitioner at BCS009")
19+
UserTools.user_login(page, "Specialist Screening Practitioner at BCS009 & BCS001")
2120
org_switch_page = OrganisationSwitchPage(page)
2221

2322
# Get the list of available organisation IDs

tests/regression/subject_search_criteria/test_screening_subject_search_criteria_page_regression.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
)
1010

1111
@pytest.mark.regression
12-
@pytest.mark.subject_search
1312
def test_user_can_search_for_subject_and_results_are_returned(page: Page):
1413
"""
1514
Verify that User can log in to BCSS "England" as user role "Hub Manager - State Registered"

users.json

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,10 @@
3131
"Hub Manager, Southern Bowel Cancer Screening Programme Hub"
3232
]
3333
},
34-
"Specialist Screening Practitioner at BCS009": {
35-
"username": "BCSS120",
36-
"roles": [
37-
"Coventry and Warwickshire Bowel Cancer Screening Centre, MultiOrgUser"
38-
]
39-
},
40-
"Specialist Screening Practitioner at BCS001": {
34+
"Specialist Screening Practitioner at BCS009 & BCS001": {
4135
"username": "BCSS120",
4236
"roles": [
37+
"Coventry and Warwickshire Bowel Cancer Screening Centre, MultiOrgUser",
4338
"Wolverhampton Bowel Cancer Screening Centre, MultiOrgUser"
4439
]
4540
}

0 commit comments

Comments
 (0)