Selenium to Playwright non invitation days (#94)

<!-- markdownlint-disable-next-line first-line-heading -->
## Description

<!-- Describe your changes in detail. -->
This includes the migration of the call and recall (non invitation days)
tests from selenium to playwright and an additional date time utils
function to select a random date (weekday) in the future.

## Context

<!-- Why is this change required? What problem does it solve? -->
This is part of the selenium to playwright migration

## Type of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply. -->

- [x] Refactoring (non-breaking change)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would change existing
functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply. -->

- [x] I am familiar with the [contributing
guidelines](https://github.com/nhs-england-tools/playwright-python-blueprint/blob/main/CONTRIBUTING.md)
- [x] I have followed the code style of the project
- [x] I have added tests to cover my changes (where appropriate)
- [x] I have updated the documentation accordingly
- [ ] This PR is a result of pair or mob programming

---

## Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others
privacy, we kindly ask you to NOT including [PII (Personal Identifiable
Information) / PID (Personal Identifiable
Data)](https://digital.nhs.uk/data-and-information/keeping-data-safe-and-benefitting-the-public)
or any other sensitive data in this PR (Pull Request) and the codebase
changes. We will remove any PR that do contain any sensitive
information. We really appreciate your cooperation in this matter.

- [x] I confirm that neither PII/PID nor sensitive data are included in
this PR and the codebase changes.

Author: Andyg79

pages/call_and_recall/non_invitations_days_page.py

@@ -10,15 +10,17 @@ def __init__(self, page: Page):
         super().__init__(page)
         self.page = page
         # Non Invitation Days - page locators, methods
-        self.enter_note_field = self.page.get_by_role("textbox", name="note")
+        self.enter_note_field = self.page.locator("#note")
         self.enter_date_field = self.page.get_by_role("textbox", name="date")
         self.add_non_invitation_day_button = self.page.get_by_role(
             "button", name="Add Non-Invitation Day"
         )
         self.non_invitation_day_delete_button = self.page.get_by_role(
             "button", name="Delete"
         )
-        self.created_on_date_locator = self.page.locator("#displayRS")
+        self.created_on_date_locator = self.page.locator(
+            "tr.oddTableRow td:nth-child(4)"
+        )
 
     def verify_non_invitation_days_tile(self) -> None:
         """Verifies the page title of the Non Invitation Days page"""
@@ -46,18 +48,16 @@ def click_delete_button(self) -> None:
         """Clicks the Delete button for a non-invitation day"""
         self.click(self.non_invitation_day_delete_button)
 
-    def verify_date_is_visible(self) -> None:
+    def verify_created_on_date_is_visible(self) -> None:
         """Verifies that the specified date is visible on the page
         Args:
             date (str): The date to verify, formatted as 'dd/mm/yyyy'.
         """
-        date = DateTimeUtils.current_datetime("dd/mm/yyyy")
-        expect(self.created_on_date_locator).to_have_text(date)
+        today = DateTimeUtils.current_datetime("%d/%m/%Y")
+        expect(self.created_on_date_locator).to_have_text(today)
 
-    def verify_date_is_not_visible(self) -> None:
-        """Verifies that the specified date is not visible on the page
-        Args:
-            date (str): The date to verify, formatted as 'dd/mm/yyyy'.
+    def verify_created_on_date_is_not_visible(self) -> None:
+        """Verifies that the 'created on' date element is not visible on the page.
+        This is used to confirm that the non-invitation day has been successfully deleted.
         """
-        date = DateTimeUtils.current_datetime("dd/mm/yyyy")
-        expect(self.created_on_date_locator).not_to_have_text(date)
+        expect(self.created_on_date_locator).not_to_be_visible

tests/regression/call_and_recall/test_non_invitation_days_regression.py

@@ -4,6 +4,7 @@
 from pages.call_and_recall.call_and_recall_page import CallAndRecallPage
 from pages.call_and_recall.non_invitations_days_page import NonInvitationDaysPage
 from utils.user_tools import UserTools
+from utils.date_time_utils import DateTimeUtils
 
 
 @pytest.fixture(scope="function", autouse=True)
@@ -24,29 +25,32 @@ def test_add_then_delete_non_invitation_day(page: Page) -> None:
     """
     Verifies that a user can add and delete a non-invitation day.
     """
-    # Scenario: Add then delete a non invitation day
-    # And I go to "Non-Invitation Days"
+    test_date = DateTimeUtils().generate_unique_weekday_date()
+
+    # When I go to "Non-Invitation Days"
     CallAndRecallPage(page).go_to_non_invitation_days_page()
 
-    # # The date entered should be a week day, otherwise a warning message will pop up
-    # When I enter "14/11/2030" in the input box with id "date"
-    NonInvitationDaysPage(page).enter_date("14/11/2030")
-    # # Add a new non invitation day
+    # And I enter a date in the input box with id "date"
+    # (The date entered should be a week day, otherwise a warning message will pop up)
+    NonInvitationDaysPage(page).enter_date(test_date)
+
     # And I enter "Add a non invitation day for automated test" in the input box with id "note"
     NonInvitationDaysPage(page).enter_note(
         "Add a non-invitation day for automated test"
     )
 
     # And I click the "Add Non-Invitation Day" button
     NonInvitationDaysPage(page).click_add_non_invitation_day_button()
+
     # Then todays date is visible in the non-invitation days table
-    NonInvitationDaysPage(page).verify_date_is_visible()
+    NonInvitationDaysPage(page).verify_created_on_date_is_visible()
+
     # When I click the delete button for the non-invitation day
-    # NonInvitationDaysPage(page).click_delete_button() TODO: this step should be executed as part of the next step (delete this step once confirmed working)
     # And I press OK on my confirmation prompt
     BasePage(page).safe_accept_dialog(page.get_by_role("button", name="Delete"))
-    # Then todays date is not visible in the non-invitation days table
-    NonInvitationDaysPage(page).verify_date_is_not_visible()
+
+    # Then the non-invitation days has been successfully deleted
+    NonInvitationDaysPage(page).verify_created_on_date_is_not_visible()
 
 
 @pytest.mark.regression

tests_utils/test_date_time_utils.py

@@ -32,31 +32,26 @@ def test_add_days():
     assert new_date == date + timedelta(days=5)
 
 
-def test_get_day_of_week_for_today():
+# Valid weekdays for testing get_day_of_week
+VALID_WEEKDAYS = [
+    "Monday",
+    "Tuesday",
+    "Wednesday",
+    "Thursday",
+    "Friday",
+    "Saturday",
+    "Sunday",
+]
+
+
+def test_get_day_of_week_with_specific_date():
     dtu = utils.date_time_utils.DateTimeUtils()
-    date = datetime.now()
-    day_of_week = dtu.get_a_day_of_week(date)
-    assert day_of_week in [
-        "Monday",
-        "Tuesday",
-        "Wednesday",
-        "Thursday",
-        "Friday",
-        "Saturday",
-        "Sunday",
-    ]
-
-
-def test_get_a_day_of_week():
+    date = datetime(2023, 11, 8)  # Known Wednesday
+    day_of_week = dtu.get_day_of_week(date)
+    assert day_of_week in VALID_WEEKDAYS
+
+
+def test_get_day_of_week_with_default_today():
     dtu = utils.date_time_utils.DateTimeUtils()
-    date = datetime(2023, 11, 8)
-    day_of_week = dtu.get_a_day_of_week(date)
-    assert day_of_week in [
-        "Monday",
-        "Tuesday",
-        "Wednesday",
-        "Thursday",
-        "Friday",
-        "Saturday",
-        "Sunday",
-    ]
+    day_of_week = dtu.get_day_of_week()
+    assert day_of_week in VALID_WEEKDAYS

utils/date_time_utils.py

@@ -1,4 +1,6 @@
 from datetime import datetime, timedelta
+from typing import Optional
+import random
 
 
 class DateTimeUtils:
@@ -45,27 +47,18 @@ def add_days(date: datetime, days: float) -> datetime:
         return date + timedelta(days=days)
 
     @staticmethod
-    def get_day_of_week_for_today(date: datetime) -> str:
-        """Gets the day of the week (e.g., Monday, Tuesday) from the specified date.
-
-        Args:
-            date (datetime): The current date using the now function
-
-        Returns:
-            str: The day of the week relating to the specified date.
+    def get_day_of_week(date: Optional[datetime] = None) -> str:
         """
-        return date.strftime("%A")
-
-    @staticmethod
-    def get_a_day_of_week(date: datetime) -> str:
-        """Gets the day of the week (e.g., Monday, Tuesday) from the specified date.
+        Returns the day of the week (e.g., Monday, Tuesday) for the given date.
+        If no date is provided, uses today’s date.
 
         Args:
-            date (datetime): The date for which the day of the week will be returned.
+            date (Optional[datetime]): The date to inspect. Defaults to now.
 
         Returns:
-            str: The day of the week relating to the specified date.
+            str: Day of week corresponding to the date.
         """
+        date = date or datetime.now()
         return date.strftime("%A")
 
     @staticmethod
@@ -98,7 +91,8 @@ def screening_practitioner_appointments_report_timestamp_date_format() -> str:
 
         return DateTimeUtils.format_date(datetime.now(), "%d.%m.%Y at %H:%M:%S")
 
-    def month_string_to_number(self, string: str) -> int:
+    @staticmethod
+    def month_string_to_number(string: str) -> int:
         """
         This is used to convert a month from a string to an integer.
         It accepts the full month or the short version and is not case sensitive
@@ -123,4 +117,38 @@ def month_string_to_number(self, string: str) -> int:
             out = months[month_short]
             return out
         except Exception:
-            raise ValueError("Not a month")
+            raise ValueError(
+                f"'{string}' is not a valid month name. Accepted values are: {', '.join(months.keys())}"
+            )
+
+    @staticmethod
+    def generate_unique_weekday_date(start_year: int = 2025) -> str:
+        """
+        Returns a random future weekday (Mon–Fri) date from the given year onward.
+
+        The result is in 'dd/mm/yyyy' format and useful for automated tests needing
+        unique, non-weekend dates. Uses non-cryptographic randomness for variability between runs.
+
+        Args:
+            start_year (int): The minimum year from which the date may be generated. Defaults to 2025.
+
+        Returns:
+            str: A future weekday date in the format 'dd/mm/yyyy'.
+        """
+        # Start from tomorrow to ensure future date
+        base_date = datetime.now() + timedelta(days=1)
+
+        # Keep moving forward until we find a weekday in 2025 or later
+        while True:
+            if base_date.weekday() < 5 and base_date.year >= start_year:
+                break
+            base_date += timedelta(days=1)
+
+        # Add randomness to avoid repeated values across runs
+        base_date += timedelta(days=random.randint(0, 10))
+
+        # Re-check for weekday after shift
+        while base_date.weekday() >= 5:
+            base_date += timedelta(days=1)
+
+        return base_date.strftime("%d/%m/%Y")