Alterting method to avoid re using strings

Author: adrianoaru-nhs

pages/subject_screening_summary.py

@@ -28,8 +28,11 @@ def __init__(self, page: Page):
     def verify_result_contains_text(self, text) -> None:
         expect(self.display_rs).to_contain_text(text)
 
-    def verify_subject_search_results_title(self, text) -> None:
-        expect(self.subject_search_results_title).to_contain_text(text)
+    def verify_subject_search_results_title_subject_screening_summary(self) -> None:
+        expect(self.subject_search_results_title).to_contain_text("Subject Screening Summary")
+
+    def verify_subject_search_results_title_subject_search_results(self) -> None:
+        expect(self.subject_search_results_title).to_contain_text("Subject Search Results")
 
     def get_latest_event_status_cell(self, latest_event_status: str)-> Locator:
         return self.page.get_by_role("cell", name=latest_event_status, exact=True)

utils/screening_subject_page_searcher.py

@@ -29,7 +29,7 @@ def search_subject_by_nhs_number(page: Page, nhs_number) -> None:
     SubjectScreeningPage(page).nhs_number_filter.fill(nhs_number)
     SubjectScreeningPage(page).nhs_number_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Screening Summary")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_screening_summary()
 
 def search_subject_by_surname(page: Page, surname) -> None:
     """
@@ -39,7 +39,7 @@ def search_subject_by_surname(page: Page, surname) -> None:
     SubjectScreeningPage(page).surname_filter.fill(surname)
     SubjectScreeningPage(page).surname_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Screening Summary")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_screening_summary()
 
 def search_subject_by_forename(page: Page, forename) -> None:
     """
@@ -49,7 +49,7 @@ def search_subject_by_forename(page: Page, forename) -> None:
     SubjectScreeningPage(page).forename_filter.fill(forename)
     SubjectScreeningPage(page).forename_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Screening Summary")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_screening_summary()
 
 def search_subject_by_dob(page: Page, dob) -> None:
     """
@@ -59,7 +59,7 @@ def search_subject_by_dob(page: Page, dob) -> None:
     SubjectScreeningPage(page).date_of_birth_filter.fill(dob)
     SubjectScreeningPage(page).date_of_birth_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Screening Summary")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_screening_summary()
 
 def search_subject_by_postcode(page: Page, postcode) -> None:
     """
@@ -69,7 +69,7 @@ def search_subject_by_postcode(page: Page, postcode) -> None:
     SubjectScreeningPage(page).postcode_filter.fill(postcode)
     SubjectScreeningPage(page).postcode_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Search Results")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_search_results()
 
 def search_subject_by_episode_closed_date(page: Page, episode_closed_date) -> None:
     """
@@ -79,7 +79,7 @@ def search_subject_by_episode_closed_date(page: Page, episode_closed_date) -> No
     SubjectScreeningPage(page).episode_closed_date_filter.fill(episode_closed_date)
     SubjectScreeningPage(page).episode_closed_date_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Search Results")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_search_results()
     SubjectScreeningSummary(page).verify_result_contains_text(episode_closed_date)
 
 def search_subject_by_status(page: Page, status) -> None:
@@ -90,7 +90,7 @@ def search_subject_by_status(page: Page, status) -> None:
     SubjectScreeningPage(page).select_screening_status_options(status)
     SubjectScreeningPage(page).select_screening_status.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Search Results")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_search_results()
 
 def search_subject_by_latest_event_status(page: Page, status) -> None:
     """
@@ -100,7 +100,7 @@ def search_subject_by_latest_event_status(page: Page, status) -> None:
     SubjectScreeningPage(page).select_episode_status_option(status)
     SubjectScreeningPage(page).select_episode_status.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Search Results")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_search_results()
 
 def search_subject_by_search_area(page: Page, status, search_area, code = None, gp_practice_code = None) -> None:
     """
@@ -118,7 +118,7 @@ def search_subject_by_search_area(page: Page, status, search_area, code = None,
         SubjectScreeningPage(page).gp_practice_in_ccg_filter.fill(gp_practice_code)
         SubjectScreeningPage(page).gp_practice_in_ccg_filter.press("Tab")
     SubjectScreeningPage(page).click_search_button()
-    SubjectScreeningSummary(page).verify_subject_search_results_title("Subject Search Results")
+    SubjectScreeningSummary(page).verify_subject_search_results_title_subject_search_results()
 
 def check_clear_filters_button_works(page, nhs_number) -> None:
     """