[release/2024-11-22] add waits

Author: jaklinger

src/layers/domain/repository/cpm_product_repository/tests/v1/test_cpm_product_repository_keys_v1.py

@@ -1,3 +1,5 @@
+import time
+
 import pytest
 from domain.core.cpm_product import CpmProduct
 from domain.core.product_key import ProductKey, ProductKeyType
@@ -17,6 +19,7 @@ def test__product_repository__add_key(
     party_key = ProductKey(key_type=ProductKeyType.PARTY_KEY, key_value=PARTY_KEY)
     product.add_key(**party_key.dict())
     repository.write(product)
+    time.sleep(1)
 
     product_by_id = repository.read(
         product_team_id=product.product_team_id, id=product.id
@@ -31,13 +34,15 @@ def test__product_repository__add_key_then_delete(
     party_key = ProductKey(key_type=ProductKeyType.PARTY_KEY, key_value=PARTY_KEY)
     product.add_key(**party_key.dict())
     repository.write(product)
+    time.sleep(1)
 
     product_from_db = repository.read(
         product_team_id=product.product_team_id, id=product.id
     )
     assert product_from_db.keys == [party_key]
     product_from_db.delete()
     repository.write(product_from_db)
+    time.sleep(1)
 
     # No longer retrievable
     with pytest.raises(ItemNotFound):
@@ -53,6 +58,7 @@ def test__product_repository__cannot_add_duplicate_key(
     party_key = ProductKey(key_type=ProductKeyType.PARTY_KEY, key_value=PARTY_KEY)
     product.add_key(**party_key.dict())
     repository.write(product)
+    time.sleep(1)
 
     # Create a second unrelated product
     org = Root.create_ods_organisation(ods_code=CPM_PRODUCT_TEAM_NO_ID["ods_code"])

src/layers/domain/repository/cpm_product_repository/tests/v1/test_cpm_product_repository_v1.py

@@ -1,3 +1,5 @@
+import time
+
 import pytest
 from domain.core.cpm_product import CpmProduct
 from domain.core.cpm_system_id import ProductId
@@ -24,6 +26,7 @@ def _create_product_team(name: str = "FOOBAR Product Team", ods_code: str = "F5H
 @pytest.mark.integration
 def test__cpm_product_repository(product: CpmProduct, repository: CpmProductRepository):
     repository.write(product)
+    time.sleep(1)
     result = repository.read(product_team_id=product.product_team_id, id=product.id)
     assert result == product
 
@@ -82,6 +85,7 @@ def test__query_products_by_product_team():
         name="cpm-product-name-2", product_id=product_id.id
     )
     repo.write(cpm_product_2)
+    time.sleep(1)
     result = repo.search(product_team_id=product_team.id)
     assert len(result) == 2
     assert isinstance(result[0], CpmProduct)
@@ -114,6 +118,7 @@ def test__query_products_by_product_team_a():
         name="cpm-product-name-3", product_id=product_id.id
     )
     repo.write(cpm_product_3)
+    time.sleep(1)
     result = repo.search(product_team_id=product_team_a.id)
     assert len(result) == 2
     assert isinstance(result[0], CpmProduct)
@@ -154,6 +159,7 @@ def test__query_products_by_product_team_with_sk_prefix():
     client = dynamodb_client()
     client.put_item(**args)
 
+    time.sleep(1)
     result = repo.search(product_team_id=product_team.id)
     assert len(result) == 2
     assert isinstance(result[0], CpmProduct)

src/layers/domain/repository/cpm_product_repository/tests/v1/test_cpm_product_repository_v1_delete.py

@@ -1,3 +1,5 @@
+import time
+
 import pytest
 from domain.core.cpm_product import CpmProduct
 from domain.core.error import NotFoundError
@@ -10,11 +12,14 @@ def test__cpm_product_repository_delete(
     product: CpmProduct, repository: CpmProductRepository
 ):
     repository.write(product)  # Create product in DB
+    time.sleep(1)
+
     product_from_db = repository.read(
         product_team_id=product.product_team_id, id=product.id
     )
     product_from_db.delete()
     repository.write(product_from_db)
+    time.sleep(1)
 
     # No longer retrievable
     with pytest.raises(ItemNotFound):

src/layers/domain/repository/device_reference_data_repository/tests/test_device_reference_data_repository_v1.py

@@ -1,3 +1,5 @@
+import time
+
 import pytest
 from domain.core.device_reference_data import DeviceReferenceData
 from domain.repository.device_reference_data_repository import (
@@ -14,6 +16,7 @@ def test__cpm_device_reference_data_repository(
     repository: DeviceReferenceDataRepository,
 ):
     repository.write(device_reference_data)
+    time.sleep(1)
     result = repository.read(
         product_team_id=device_reference_data.product_team_id,
         product_id=device_reference_data.product_id,
@@ -28,6 +31,7 @@ def test__cpm_device_reference_data_repository_already_exists(
     repository: DeviceReferenceDataRepository,
 ):
     repository.write(device_reference_data)
+    time.sleep(1)
     with pytest.raises(AlreadyExistsError):
         repository.write(device_reference_data)
 
@@ -52,6 +56,7 @@ def test__cpm_product_repository_local(
     repository: DeviceReferenceDataRepository,
 ):
     repository.write(device_reference_data)
+    time.sleep(1)
     result = repository.read(
         product_team_id=device_reference_data.product_team_id,
         product_id=device_reference_data.product_id,
@@ -95,6 +100,7 @@ def test__cpm_device_reference_data_repository__search_not_empty(
     repository: DeviceReferenceDataRepository,
 ):
     repository.write(device_reference_data)
+    time.sleep(1)
     results = repository.search(
         product_team_id=device_reference_data.product_team_id,
         product_id=device_reference_data.product_id,

src/layers/domain/repository/device_repository/tests/v1/test_device_repository_keys_v1.py

@@ -1,3 +1,5 @@
+import time
+
 import pytest
 from domain.core.device import Device
 from domain.core.device_key import DeviceKey, DeviceKeyType
@@ -7,6 +9,8 @@
 @pytest.mark.integration
 def test__device_repository__add_two_keys(device: Device, repository: DeviceRepository):
     repository.write(device)
+    time.sleep(1)
+
     second_device = repository.read(
         product_team_id=device.product_team_id,
         product_id=device.product_id,
@@ -16,6 +20,7 @@ def test__device_repository__add_two_keys(device: Device, repository: DeviceRepo
         key_value="ABC:1234567890", key_type=DeviceKeyType.ACCREDITED_SYSTEM_ID
     )
     repository.write(second_device)
+    time.sleep(1)
 
     assert repository.read(
         product_team_id=device.product_team_id,
@@ -55,6 +60,7 @@ def test__device_repository__delete_key(
 ):
     # Persist model before deleting from model
     repository.write(device_with_asid)
+    time.sleep(1)
 
     # Retrieve the model and treat this as the initial state
     intermediate_device = repository.read(
@@ -66,6 +72,7 @@ def test__device_repository__delete_key(
         key_type=DeviceKeyType.ACCREDITED_SYSTEM_ID, key_value="ABC:1234567890"
     )
     repository.write(intermediate_device)
+    time.sleep(1)
 
     assert repository.read(
         product_team_id=device_with_asid.product_team_id,

src/layers/domain/repository/device_repository/tests/v1/test_device_repository_questionnaire_responses_v1.py

@@ -1,4 +1,5 @@
 import json
+import time
 
 import pytest
 from domain.core.device import Device
@@ -76,6 +77,8 @@ def test__device_repository__with_questionnaires(
     device: Device, repository: DeviceRepository
 ):
     repository.write(device)
+    time.sleep(1)
+
     assert (
         repository.read(
             product_team_id=device.product_team_id,
@@ -96,6 +99,8 @@ def test__device_repository__with_questionnaires_and_tags(
     """
     device.add_tag(foo="bar")
     repository.write(device)
+    time.sleep(1)
+
     assert (
         repository.read(
             product_team_id=device.product_team_id,

src/layers/domain/repository/device_repository/tests/v1/test_device_repository_tags_v1.py

@@ -15,6 +15,8 @@
 @pytest.mark.integration
 def test__device_repository__tags(device: Device, repository: DeviceRepository):
     repository.write(device)
+    time.sleep(1)
+
     (_device_123,) = repository.query_by_tag(abc=123)
     assert _device_123.dict(exclude=DONT_COMPARE_FIELDS) == device.dict(
         exclude=DONT_COMPARE_FIELDS
@@ -37,6 +39,8 @@ def test__device_repository__tag_does_not_exist(
     device: Device, repository: DeviceRepository
 ):
     repository.write(device)
+    time.sleep(1)
+
     results = repository.query_by_tag(abc=12)
     assert len(results) == 0
 
@@ -109,6 +113,8 @@ def _test_add_two_tags(
 @pytest.mark.integration
 def test__device_repository__add_two_tags(device: Device, repository: DeviceRepository):
     repository.write(device)
+    time.sleep(1)
+
     second_device = repository.read(
         product_team_id=device.product_team_id,
         product_id=device.product_id,
@@ -129,6 +135,8 @@ def test__device_repository__add_two_tags_at_once(
     device: Device, repository: DeviceRepository
 ):
     repository.write(device)
+    time.sleep(1)
+
     second_device = repository.read(
         product_team_id=device.product_team_id,
         product_id=device.product_id,
@@ -148,6 +156,8 @@ def test__device_repository__add_two_tags_and_then_clear(
     device: Device, repository: DeviceRepository
 ):
     repository.write(device)
+    time.sleep(1)
+
     second_device = repository.read(
         product_team_id=device.product_team_id,
         product_id=device.product_id,
@@ -222,6 +232,8 @@ def test__device_repository__drop_mandatory_fields(
     device: Device, repository: DeviceRepository
 ):
     repository.write(device)
+    time.sleep(1)
+
     (_device_123,) = repository.query_by_tag(abc=123)
     assert _device_123.dict(exclude=DONT_COMPARE_FIELDS) == device.dict(
         exclude=DONT_COMPARE_FIELDS