Skip to content

Commit 96c1c29

Browse files
committed
[feature/PI-618-bulk_etl_e2e] remove comment and rename placeholder file
1 parent a47fc58 commit 96c1c29

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

src/etl/sds/worker/bulk/load_bulk/tests/edge_cases/PLACEHOLDER renamed to src/etl/sds/worker/bulk/load_bulk/tests/edge_cases/.gitkeep

File renamed without changes.

src/etl/sds/worker/bulk/load_bulk/tests/test_load_bulk_worker.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def test_load_worker_pass(
220220
@pytest.mark.integration
221221
@pytest.mark.parametrize("path", (PATH_TO_HERE / "edge_cases").iterdir())
222222
def test_load_worker_edge_cases(path: Path):
223-
if path.name == "PLACEHOLDER":
223+
if path.name == ".gitkeep":
224224
pytest.skip()
225225

226226
s3_client = boto3.client("s3")

src/layers/domain/api/sds/query.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ def allowed_field_combinations(cls) -> list[set[str]]:
2727

2828

2929
class SearchSDSEndpointQueryParams(BaseModel, extra=Extra.forbid):
30-
# can effectively achieve these without tags now
31-
# if
32-
# 1. nhs_id_code and nhs_mhs_party_key -> only need party key
33-
# 2. nhs_id_code and nhs_mhs_svc_ia -> can retrieve all devices for org, and filter on nhs_mhs_svc_ia
34-
# 3. nhs_mhs_party_key and nhs_mhs_svc_ia -> can retrieve the mhs device for product, and filter on nhs_mhs_svc_ia --> possible that can read device directly by cpaid
35-
# 4. nhs_id_code and nhs_mhs_party_key and nhs_mhs_svc_ia -> same as 3.
36-
3730
nhs_id_code: str = None
3831
nhs_mhs_svc_ia: str = None
3932
nhs_mhs_party_key: str = None

0 commit comments

Comments
 (0)