[feature/PI-618-bulk_etl_e2e] remove comment and rename placeholder file

jaklinger · jaklinger · commit 96c1c2992810 · 2024-12-05T15:14:38.000Z
diff --git a/src/etl/sds/worker/bulk/load_bulk/tests/edge_cases/.gitkeep b/src/etl/sds/worker/bulk/load_bulk/tests/edge_cases/.gitkeep
diff --git a/src/etl/sds/worker/bulk/load_bulk/tests/test_load_bulk_worker.py b/src/etl/sds/worker/bulk/load_bulk/tests/test_load_bulk_worker.py
@@ -220,7 +220,7 @@ def test_load_worker_pass(
 @pytest.mark.integration
 @pytest.mark.parametrize("path", (PATH_TO_HERE / "edge_cases").iterdir())
 def test_load_worker_edge_cases(path: Path):
-    if path.name == "PLACEHOLDER":
+    if path.name == ".gitkeep":
         pytest.skip()
 
     s3_client = boto3.client("s3")
diff --git a/src/layers/domain/api/sds/query.py b/src/layers/domain/api/sds/query.py
@@ -27,13 +27,6 @@ def allowed_field_combinations(cls) -> list[set[str]]:
 
 
 class SearchSDSEndpointQueryParams(BaseModel, extra=Extra.forbid):
-    # can effectively achieve these without tags now
-    # if
-    # 1. nhs_id_code and nhs_mhs_party_key -> only need party key
-    # 2. nhs_id_code and nhs_mhs_svc_ia -> can retrieve all devices for org, and filter on nhs_mhs_svc_ia
-    # 3. nhs_mhs_party_key and nhs_mhs_svc_ia -> can retrieve the mhs device for product, and filter on nhs_mhs_svc_ia  --> possible that can read device directly by cpaid
-    # 4. nhs_id_code and nhs_mhs_party_key and nhs_mhs_svc_ia -> same as 3.
-
     nhs_id_code: str = None
     nhs_mhs_svc_ia: str = None
     nhs_mhs_party_key: str = None
