Skip to content

Commit ab43593

Browse files
committed
Remove Generic NotFound
1 parent 6250842 commit ab43593

File tree

2 files changed

+18
-13
lines changed

2 files changed

+18
-13
lines changed

infrastructure/swagger/05_paths.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ paths:
2929
responses:
3030
"200":
3131
$ref: "#/components/responses/StatusOK"
32-
"404":
33-
$ref: "#/components/responses/NotFound"
3432
parameters:
3533
- $ref: "#/components/parameters/HeaderVersion"
3634
- $ref: "#/components/parameters/HeaderRequestId"
@@ -424,7 +422,7 @@ paths:
424422
"200":
425423
$ref: "#/components/responses/ProductDelete"
426424
"404":
427-
$ref: "#/components/responses/NotFound"
425+
$ref: "#/components/responses/ProductDeleteNotFound"
428426
x-amazon-apigateway-integration:
429427
<<: *ApiGatewayIntegration
430428
uri: ${method_deleteCpmProduct}

infrastructure/swagger/12_components--responses.yaml

Lines changed: 17 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,6 @@ components:
2020
$ref: "#/components/schemas/StatusOK"
2121
headers:
2222
<<: *ResponseHeaders
23-
NotFound:
24-
description: Not found
25-
content:
26-
application/json:
27-
schema:
28-
$ref: "#/components/schemas/ErrorResponse"
29-
example:
30-
errors:
31-
- code: "RESOURCE_NOT_FOUND"
32-
message: "Could not find <ENTITY> for key ('<ID>')"
3323
ProductTeamNotFound:
3424
description: Product Team has not been found
3525
content:
@@ -50,6 +40,23 @@ components:
5040
errors:
5141
- code: "RESOURCE_NOT_FOUND"
5242
message: "Could not find CpmProduct for key ('P.XXX-YYY')"
43+
ProductDeleteNotFound:
44+
description: Product has not been found
45+
content:
46+
application/json:
47+
schema:
48+
$ref: "#/components/schemas/ErrorResponse"
49+
examples:
50+
ProductTeamNotFound:
51+
value:
52+
errors:
53+
- code: "RESOURCE_NOT_FOUND"
54+
message: "Could not find ProductTeam for key ('f9518c12-6c83-4544-97db-d9dd1d64da97')"
55+
ProductNotFound:
56+
value:
57+
errors:
58+
- code: "RESOURCE_NOT_FOUND"
59+
message: "Could not find CpmProduct for key ('f9518c12-6c83-4544-97db-d9dd1d64da97', 'P.XXX-YYY')"
5360
Conflict:
5461
description: Conflict
5562
content:

0 commit comments

Comments
 (0)