fix: [DTOSS-11762] remove circular dependency between the action group and key vault (#1775)

fix: add a dependency on the key vault in the action group module and data sources

Author: MacMur85

infrastructure/tf-core/data.tf

@@ -71,11 +71,19 @@ data "azurerm_key_vault" "infra" {
 
   name                = module.regions_config[each.key].names.key-vault
   resource_group_name = azurerm_resource_group.core[each.key].name
+
+  depends_on = [
+    module.key_vault
+  ]
 }
 
 data "azurerm_key_vault_secret" "monitoring_email_address" {
   for_each = var.features.alerts_enabled && var.key_vault != {} ? var.regions : {}
 
   name         = "monitoring-email-address"
   key_vault_id = data.azurerm_key_vault.infra[each.key].id
+
+  depends_on = [
+    module.key_vault
+  ]
 }

infrastructure/tf-core/monitor_action_group.tf

@@ -20,4 +20,8 @@ module "monitor_action_group_performance" {
       email_address = data.azurerm_key_vault_secret.monitoring_email_address[local.primary_region].value
     }
   }
+
+  depends_on = [
+    module.key_vault
+  ]
 }