feat: update lookups to be case insensitive (#1644)

Author: will-larkin-nhs

application/CohortManager/src/Functions/ScreeningValidationService/LookupValidation/Breast_Screening_lookupRules.json

@@ -17,11 +17,11 @@
         "LocalParams": [
           {
             "Name": "EnglishPostingCategory",
-            "Expression": "dbLookup.RetrievePostingCategory(newParticipant.CurrentPosting) == \"ENGLAND\""
+            "Expression": "string.Equals(dbLookup.RetrievePostingCategory(newParticipant.CurrentPosting), \"ENGLAND\", StringComparison.OrdinalIgnoreCase)"
           },
           {
             "Name": "InvalidPostingCategory",
-            "Expression": "!(EnglishPostingCategory || newParticipant.CurrentPosting == \"ENG\" || newParticipant.CurrentPosting == \"IM\" || newParticipant.CurrentPosting == \"DMS\")"
+            "Expression": "!(EnglishPostingCategory || string.Equals(newParticipant.CurrentPosting, \"ENG\", StringComparison.OrdinalIgnoreCase) || string.Equals(newParticipant.CurrentPosting, \"IM\", StringComparison.OrdinalIgnoreCase) || string.Equals(newParticipant.CurrentPosting, \"DMS\", StringComparison.OrdinalIgnoreCase))"
           },
           {
             "Name": "IsExcluded",
@@ -48,7 +48,7 @@
         "LocalParams": [
           {
             "Name": "reasonForRemoval",
-            "Expression": "newParticipant.ReasonForRemoval == \"RDI\" OR newParticipant.ReasonForRemoval == \"RDR\" OR newParticipant.ReasonForRemoval == \"RPR\""
+            "Expression": "string.Equals(newParticipant.ReasonForRemoval, \"RDI\", StringComparison.OrdinalIgnoreCase) OR string.Equals(newParticipant.ReasonForRemoval, \"RDR\", StringComparison.OrdinalIgnoreCase) OR string.Equals(newParticipant.ReasonForRemoval, \"RPR\", StringComparison.OrdinalIgnoreCase)"
           },
           {
             "Name": "postcode",

application/CohortManager/src/Functions/ScreeningValidationService/LookupValidation/DataLookupFacadeBreastScreening.cs

@@ -109,4 +109,4 @@ public string RetrievePostingCategory(string currentPosting)
         var result = _currentPostingClient.GetSingle(currentPosting).Result;
         return result.PostingCategory;
     }
-}
+}

application/CohortManager/src/Functions/Shared/Common/ValidationHelper.cs

@@ -107,8 +107,9 @@ public static bool ValidatePostcode(string postcode)
     /// </summary>
     /// <param name="postcode">a non-null string representing the postcode</param>
     /// <remarks>
-    /// Works for valid UK postcodes and dummy postcodes.
-    /// Works with or without a space separator between outcode and incode.
+    /// Works for valid UK postcodes and dummy postcodes with
+    /// or without a space separator between outcode and incode.
+    /// Returns the outcode in upper case.
     /// </remarks>
     public static string? ParseOutcode(string postcode)
     {
@@ -122,7 +123,7 @@ public static bool ValidatePostcode(string postcode)
         }
 
         string outcode = match.Groups[1].Value;
-        return outcode;
+        return outcode.ToUpper();
     }
 
     private static bool ParseInt32(char value, out int integerValue)