fix: Terraform Provider Updates (#975)

* terraform provider updates

* Remove NemsMeshRetrieval App Service Plan

* Update Pre Prod environment

* DevTest becomes Sandbox

* Update sandbox from dev

* Minor updates

* Update PreProd scaling to match current deployment

* Fix scaling

Author: rfk-nc

…elines/acr-image-promote-to-devtest.yaml …elines/acr-image-promote-to-sandbox.yaml.azuredevops/pipelines/acr-image-promote-to-devtest.yaml renamed to .azuredevops/pipelines/acr-image-promote-to-sandbox.yaml .azuredevops/pipelines/acr-image-promote-to-devtest.yaml renamed to .azuredevops/pipelines/acr-image-promote-to-sandbox.yaml

@@ -24,8 +24,8 @@ stages:
       name: private-pool-dev-uks
     displayName: Apply database changes
     variables:
-      - group: DEVTEST_core_backend
-      - group: DEVTEST_image_pipelines
+      - group: SBX_core_backend
+      - group: SBX_image_pipelines
     steps:
       - checkout: self
       - checkout: dtos-devops-templates
@@ -41,8 +41,8 @@ stages:
       name: private-pool-dev-uks
     displayName: Deploy Docker images to function apps
     variables:
-      - group: DEVTEST_core_backend
-      - group: DEVTEST_image_pipelines
+      - group: SBX_core_backend
+      - group: SBX_image_pipelines
     steps:
       - template: .azuredevops/templates/steps/deploy-images-from-acr.yaml@dtos-devops-templates
         parameters:
@@ -51,7 +51,7 @@ stages:
 - stage: post_deployment_tests_stage
   displayName: Post-deployment tests
   variables:
-  - group: DEVTEST_automation_testing_pipeline
+  - group: SBX_automation_testing_pipeline
   jobs:
   - job: post_deployment_tests
     displayName: Run post-deployment tests

.azuredevops/pipelines/cd-infrastructure-dev-core.yaml

@@ -13,15 +13,15 @@ resources:
     - repository: dtos-devops-templates
       type: github
       name: NHSDigital/dtos-devops-templates
-      ref: 2f8731f9c7d6b9d53b7044979e381377b2c85bcd
+      ref: c00889236a258a52a2f3131272427ce81d4da951
       endpoint: NHSDigital
 
 variables:
   - group: DEV_core_backend
   - group: DEV_audit_backend_remote_state
   - group: DEV_hub_backend_remote_state
   - name: TF_VERSION
-    value: 1.9.2
+    value: 1.11.4
   - name: TF_PLAN_ARTIFACT
     value: tf_plan_core_DEV
   - name: TF_DIRECTORY

.azuredevops/pipelines/cd-infrastructure-devtest-audit.yaml

@@ -13,15 +13,15 @@ resources:
     - repository: dtos-devops-templates
       type: github
       name: NHSDigital/dtos-devops-templates
-      ref: 2f8731f9c7d6b9d53b7044979e381377b2c85bcd
+      ref: c00889236a258a52a2f3131272427ce81d4da951
       endpoint: NHSDigital
 
 variables:
   - group: INT_core_backend
   - group: INT_audit_backend_remote_state
   - group: DEV_hub_backend_remote_state
   - name: TF_VERSION
-    value: 1.9.2
+    value: 1.11.4
   - name: TF_PLAN_ARTIFACT
     value: tf_plan_core_INT
   - name: TF_DIRECTORY

.azuredevops/pipelines/cd-infrastructure-devtest-core.yaml

@@ -13,15 +13,15 @@ resources:
     - repository: dtos-devops-templates
       type: github
       name: NHSDigital/dtos-devops-templates
-      ref: 2f8731f9c7d6b9d53b7044979e381377b2c85bcd
+      ref: c00889236a258a52a2f3131272427ce81d4da951
       endpoint: NHSDigital
 
 variables:
   - group: NFT_core_backend
   - group: NFT_audit_backend_remote_state
   - group: DEV_hub_backend_remote_state
   - name: TF_VERSION
-    value: 1.9.2
+    value: 1.11.4
   - name: TF_PLAN_ARTIFACT
     value: tf_plan_core_NFT
   - name: TF_DIRECTORY

.azuredevops/pipelines/cd-infrastructure-int-core.yaml

@@ -13,7 +13,7 @@ resources:
     - repository: dtos-devops-templates
       type: github
       name: NHSDigital/dtos-devops-templates
-      ref: 2f8731f9c7d6b9d53b7044979e381377b2c85bcd
+      ref: c00889236a258a52a2f3131272427ce81d4da951
       endpoint: NHSDigital
 
 variables:
@@ -23,7 +23,7 @@ variables:
   - name: TF_DIRECTORY
     value: $(System.DefaultWorkingDirectory)/$(System.TeamProject)/infrastructure/tf-core
   - name: TF_VERSION
-    value: 1.9.2
+    value: 1.11.4
   - name: TF_PLAN_ARTIFACT
     value: tf_plan_core_PRE
   - name: ENVIRONMENT

.azuredevops/pipelines/cd-infrastructure-nft-core.yaml

@@ -0,0 +1,104 @@
+---
+
+name: $(Build.SourceBranchName)-$(Date:yyyyMMdd)_$(Rev:r)
+trigger: none
+pr: none
+
+pool:
+  #vmImage: ubuntu-latest
+  name: private-pool-dev-uks
+
+resources:
+  repositories:
+    - repository: dtos-devops-templates
+      type: github
+      name: NHSDigital/dtos-devops-templates
+      ref: c00889236a258a52a2f3131272427ce81d4da951
+      endpoint: NHSDigital
+
+parameters:
+  - name: pipelineAction
+    displayName: 'Pipeline Action'
+    type: string
+    values:
+      - 'PlanOnly'
+      - 'Apply'
+      - 'Destroy'
+    default: 'Apply'
+
+variables:
+  - group: SBX_core_backend
+  - group: SBX_audit_backend_remote_state
+  - group: DEV_hub_backend_remote_state
+  - name: TF_VERSION
+    value: 1.11.4
+  - name: TF_PLAN_ARTIFACT
+    value: tf_plan_core_SANDBOX
+  - name: TF_DIRECTORY
+    value: $(System.DefaultWorkingDirectory)/$(System.TeamProject)/infrastructure/tf-core
+  - name: ENVIRONMENT
+    value: sandbox
+
+stages:
+  - stage: terraform_plan
+    displayName: Terraform Plan
+    condition: and(in('${{ parameters.pipelineAction }}', 'Apply', 'PlanOnly'), eq(variables['Build.Reason'], 'Manual'))
+    variables:
+      tfVarsFile: environments/$(ENVIRONMENT).tfvars
+    jobs:
+      - job: init_and_plan
+        displayName: Init, plan, store artifact
+        steps:
+          - checkout: self
+          - checkout: dtos-devops-templates
+          - template: .azuredevops/templates/steps/tf_plan.yaml@dtos-devops-templates
+
+  - stage: terraform_apply
+    displayName: Terraform Apply
+    dependsOn: [terraform_plan]
+    condition: and(eq('${{ parameters.pipelineAction }}', 'Apply'), eq(dependencies.terraform_plan.outputs['init_and_plan.TerraformPlan.changesPresent'], 'true'), eq(variables['Build.Reason'], 'Manual'))
+    jobs:
+      - deployment: terraform_apply
+        displayName: Init, get plan artifact, apply
+        environment: $(ENVIRONMENT)
+        strategy:
+          runOnce:
+            deploy:
+              steps:
+                - checkout: self
+                - checkout: dtos-devops-templates
+                - template: .azuredevops/templates/steps/tf_apply.yaml@dtos-devops-templates
+
+  - stage: terraform_destroy
+    displayName: Terraform Destroy
+    condition: and(eq('${{ parameters.pipelineAction }}', 'Destroy'), eq(variables['Build.Reason'], 'Manual'))
+    variables:
+      tfVarsFile: environments/$(ENVIRONMENT).tfvars
+    jobs:
+      - deployment: terraform_destroy
+        displayName: Terraform Destroy
+        environment: $(ENVIRONMENT)
+        strategy:
+          runOnce:
+            deploy:
+              steps:
+                - checkout: self
+                - checkout: dtos-devops-templates
+                - template: .azuredevops/templates/steps/tf_destroy.yaml@dtos-devops-templates
+
+                # - task: AzureCLI@2
+                #   displayName: Clean-up Backend
+                #   inputs:
+                #     azureSubscription: $(SERVICE_CONNECTION)
+                #     scriptLocation: inlineScript
+                #     scriptType: bash
+                #     workingDirectory: $(tfExecutionDir)
+                #     inlineScript: |
+                #       # Check if the backend configuration file exists and if it does, delete it:
+                #       container_exists=$(az storage container exists --name $(BACKEND_AZURE_STORAGE_ACCOUNT_CONTAINER_NAME) --account-name $(BACKEND_AZURE_STORAGE_ACCOUNT_NAME) --auth-mode login --output tsv)
+                #       if [ "$container_exists" == "True" ]; then
+                #         echo "##[debug] Container $(BACKEND_AZURE_STORAGE_ACCOUNT_CONTAINER_NAME) exists, deleting it..."
+                #         az storage container delete --name $(BACKEND_AZURE_STORAGE_ACCOUNT_CONTAINER_NAME) --account-name $(BACKEND_AZURE_STORAGE_ACCOUNT_NAME) --auth-mode login
+                #       else
+                #         echo "##[debug] Container $(BACKEND_AZURE_STORAGE_ACCOUNT_CONTAINER_NAME) does not exist."
+                #       fi

.azuredevops/pipelines/cd-infrastructure-preprod-core.yaml

@@ -62,6 +62,6 @@ data "azurerm_user_assigned_identity" "acr_mi" {
 data "azurerm_application_insights" "ai" {
   provider = azurerm.audit
 
-  name                = var.function_apps.app_insights_name
-  resource_group_name = var.function_apps.app_insights_rg_name
+  name                = data.terraform_remote_state.audit.outputs.application_insights.name
+  resource_group_name = data.terraform_remote_state.audit.outputs.application_insights.resource_group_name
 }