fix: fix the date formatting for date strings for DoB

Author: chrimesdev

application/CohortManager/src/Web/app/data/mockExceptions.json

@@ -15,7 +15,7 @@
       "ExceptionDetails": {
         "GivenName": "William",
         "FamilyName": "Taylor",
-        "DateOfBirth": "19830507",
+        "DateOfBirth": "1983-05-07",
         "ParticipantAddressLine1": "258 Willow Road",
         "ParticipantAddressLine2": "",
         "ParticipantAddressLine3": "Suburb",
@@ -47,7 +47,7 @@
       "ExceptionDetails": {
         "GivenName": "Alice",
         "FamilyName": "Smith",
-        "DateOfBirth": "19800101",
+        "DateOfBirth": "1980-01-01",
         "ParticipantAddressLine1": "123 Main Street",
         "ParticipantAddressLine2": "Flat 2B",
         "ParticipantAddressLine3": "Central District",
@@ -79,7 +79,7 @@
       "ExceptionDetails": {
         "GivenName": "Alice",
         "FamilyName": "Smith",
-        "DateOfBirth": "19800101",
+        "DateOfBirth": "1980-01-01",
         "ParticipantAddressLine1": "123 Main Street",
         "ParticipantAddressLine2": "Flat 2B",
         "ParticipantAddressLine3": "Central District",
@@ -111,7 +111,7 @@
       "ExceptionDetails": {
         "GivenName": "Bob",
         "FamilyName": "Johnson",
-        "DateOfBirth": "19751212",
+        "DateOfBirth": "1975-12-12",
         "ParticipantAddressLine1": "456 Oak Avenue",
         "ParticipantAddressLine2": "",
         "ParticipantAddressLine3": "West End",
@@ -143,7 +143,7 @@
       "ExceptionDetails": {
         "GivenName": "Alice",
         "FamilyName": "Smith",
-        "DateOfBirth": "19800101",
+        "DateOfBirth": "1980-01-01",
         "ParticipantAddressLine1": "123 Main Street",
         "ParticipantAddressLine2": "Flat 2B",
         "ParticipantAddressLine3": "Central District",
@@ -175,7 +175,7 @@
       "ExceptionDetails": {
         "GivenName": "Emma",
         "FamilyName": "Wilson",
-        "DateOfBirth": "19850315",
+        "DateOfBirth": "1985-03-15",
         "ParticipantAddressLine1": "789 Elm Street",
         "ParticipantAddressLine2": "Apt 5C",
         "ParticipantAddressLine3": "Downtown",
@@ -207,7 +207,7 @@
       "ExceptionDetails": {
         "GivenName": "Oliver",
         "FamilyName": "Brown",
-        "DateOfBirth": "19920628",
+        "DateOfBirth": "1992-06-28",
         "ParticipantAddressLine1": "321 Pine Road",
         "ParticipantAddressLine2": "",
         "ParticipantAddressLine3": "Northside",
@@ -239,7 +239,7 @@
       "ExceptionDetails": {
         "GivenName": "Sophia",
         "FamilyName": "Davis",
-        "DateOfBirth": "19781104",
+        "DateOfBirth": "1978-11-04",
         "ParticipantAddressLine1": "654 Cedar Lane",
         "ParticipantAddressLine2": "House 12",
         "ParticipantAddressLine3": "Eastside",
@@ -271,7 +271,7 @@
       "ExceptionDetails": {
         "GivenName": "James",
         "FamilyName": "Miller",
-        "DateOfBirth": "19880719",
+        "DateOfBirth": "1988-07-19",
         "ParticipantAddressLine1": "987 Maple Avenue",
         "ParticipantAddressLine2": "Floor 3",
         "ParticipantAddressLine3": "Westside",
@@ -303,7 +303,7 @@
       "ExceptionDetails": {
         "GivenName": "Charlotte",
         "FamilyName": "Anderson",
-        "DateOfBirth": "19901223",
+        "DateOfBirth": "1990-12-23",
         "ParticipantAddressLine1": "147 Birch Street",
         "ParticipantAddressLine2": "Unit B",
         "ParticipantAddressLine3": "City Centre",
@@ -335,7 +335,7 @@
       "ExceptionDetails": {
         "GivenName": "William",
         "FamilyName": "Taylor",
-        "DateOfBirth": "19830507",
+        "DateOfBirth": "1983-05-07",
         "ParticipantAddressLine1": "258 Willow Road",
         "ParticipantAddressLine2": "",
         "ParticipantAddressLine3": "Suburb",
@@ -367,7 +367,7 @@
       "ExceptionDetails": {
         "GivenName": "Isabella",
         "FamilyName": "Thomas",
-        "DateOfBirth": "19940812",
+        "DateOfBirth": "1994-08-12",
         "ParticipantAddressLine1": "369 Ash Grove",
         "ParticipantAddressLine2": "Flat 7A",
         "ParticipantAddressLine3": "Old Town",

application/CohortManager/src/Web/app/lib/utils.test.ts

@@ -30,7 +30,7 @@ describe("formatDate", () => {
 
 describe("formatCompactDate", () => {
   it("should format the date as 26 February 1993", () => {
-    const input = "19930226";
+    const input = "1993-02-26";
     const expectedOutput = "26 February 1993";
     expect(formatCompactDate(input)).toBe(expectedOutput);
   });

application/CohortManager/src/Web/app/lib/utils.ts

@@ -1,5 +1,5 @@
 export const formatNhsNumber = (nhsNumber: string | number): string => {
-  if (!nhsNumber) return '';
+  if (!nhsNumber) return "";
   const nhsString = String(nhsNumber);
   return nhsString.replace(/(\d{3})(\d{3})(\d{4})/, "$1 $2 $3");
 };
@@ -17,26 +17,14 @@ export const formatDate = (dateString: string): string => {
 export const formatCompactDate = (dateString: string): string => {
   if (!dateString) return "";
 
-  let year: string, month: string, day: string;
-
-  if (dateString.includes('-') || dateString.includes('/')) {
-    const parts = dateString.split(/[-/]/);
-    if (parts.length !== 3) return "";
-    [year, month, day] = parts;
-  } else {
-    if (dateString.length < 8) return "";
-    year = dateString.slice(0, 4);
-    month = dateString.slice(4, 6);
-    day = dateString.slice(6, 8);
-  }
+  const date = new Date(dateString);
 
-  const date = new Date(`${year}-${month}-${day}`);
-  if (isNaN(date.getTime())) return "";
   const options: Intl.DateTimeFormatOptions = {
-    year: "numeric",
-    month: "long",
     day: "numeric",
+    month: "long",
+    year: "numeric",
   };
+
   return date.toLocaleDateString("en-GB", options);
 };