wip

Author: patrickmoore-nc

infrastructure/modules/acme-certificate/README.md

@@ -9,7 +9,7 @@ A Terraform module to obtain a publicly trusted SSL certificate from the Let's E
 - Automates [DNS-01 challenges](https://letsencrypt.org/docs/challenge-types/) via the [Lego azuredns](https://go-acme.github.io/lego/dns/azuredns/) provider.
 - Handles Lego's requirement for authoritative NS records on the leaf zone. e.g. if you need a certificate for `www.private.example.com` but only have a zone for `example.com`, you can use CNAME redirection (see examples below).
 - CNAME redirection of DNS challenge records, including optional creation of corresponding CNAMEs in Azure Private DNS zones to satisfy Lego's local checks (wildcards supported).
-- Stores certificates in Azure Key Vault as Certificate objects.
+- Stores created certificate in Azure Key Vault as a Certificate object.
 - Also stores the certificate as a `.pfx` file in a base64-encoded Key Vault Secret with a strong randomised password, for compatibility with consumers that cannot use Certificate objects.
 - Supports multiple subscriptions (e.g. hub/spoke models).
 - Supports multiple Azure regions.

scripts/deployments/get-docker-names.sh

@@ -130,7 +130,7 @@ done
 
 if [ ${#non_matched_changes[@]} -ne 0 ]; then
     # Remove duplicates (non-matched items across several compose files)
-    unique_changes=("$(printf "%s\n" "${non_matched_changes[@]}" | sort -u)")
+    mapfile -t unique_changes < <(printf "%s\n" "${non_matched_changes[@]}" | sort -u)
 
     warning_message=$(
         cat <<EOF