[DTOSS-8589] Fix container app RG data source error (#179)

* Add lowercase virtual network name

New resources should be created with lowercase name

* Fix error container app error when the RG is not created

The data source was relying on the resource group existence and failing
when building an environment from scratch

Author: saliceti

infrastructure/modules/container-app-environment/data.tf

@@ -1,6 +1,6 @@
 resource "azurerm_container_app_environment" "main" {
   name                           = var.name
-  location                       = data.azurerm_resource_group.main.location
+  location                       = var.location
   resource_group_name            = var.resource_group_name
   log_analytics_workspace_id     = var.log_analytics_workspace_id
   infrastructure_subnet_id       = var.vnet_integration_subnet_id

infrastructure/modules/container-app-environment/main.tf

@@ -8,6 +8,12 @@ variable "resource_group_name" {
   type        = string
 }
 
+variable "location" {
+  type        = string
+  description = "The location/region where the container app environment is created."
+  default     = "UK South"
+}
+
 variable "log_analytics_workspace_id" {
   type        = string
   description = "ID of the log analytics workspace to send resource logging to via diagnostic settings"

infrastructure/modules/container-app-environment/variables.tf

@@ -4,7 +4,3 @@ data "azurerm_key_vault_secrets" "app" {
 
   key_vault_id = var.app_key_vault_id
 }
-
-data "azurerm_resource_group" "main" {
-  name = var.resource_group_name
-}

infrastructure/modules/container-app/data.tf

@@ -1,7 +1,7 @@
 module "container_app_identity" {
   source              = "../managed-identity"
   resource_group_name = var.resource_group_name
-  location            = data.azurerm_resource_group.main.location
+  location            = var.location
   uai_name            = "${var.name}-identity"
 }
 
@@ -11,7 +11,7 @@ module "key_vault_reader_role" {
 
   source = "../rbac-assignment"
 
-  scope                = data.azurerm_resource_group.main.id
+  scope                = var.app_key_vault_id
   role_definition_name = "Key Vault Secrets User"
   principal_id         = module.container_app_identity.principal_id
 }

infrastructure/modules/container-app/main.tf

@@ -3,6 +3,12 @@ variable "name" {
   type        = string
 }
 
+variable "location" {
+  type        = string
+  description = "The location/region where the container app is created."
+  default     = "UK South"
+}
+
 variable "container_app_environment_id" {
   description = "ID of the container app environment."
   type        = string

infrastructure/modules/container-app/variables.tf

@@ -157,6 +157,7 @@ locals {
     virtual-machine                     = lower("${var.env}-${var.application}")
     win-virtual-machine                 = lower("${var.env}-${var.application}")
     virtual-network                     = upper("VNET-${var.env}-${var.location_map[var.location]}-${var.application}")
+    virtual-network-lowercase           = lower("vnet-${var.env}-${var.location_map[var.location]}-${var.application}")
     vnet-gateway                        = lower("GWY-${var.env}-${var.location_map[var.location]}-${var.application}")
   }
 }

infrastructure/modules/shared-config/output.tf

@@ -97,4 +97,6 @@ variable "application" {
 variable "tags" {
   type        = map(string)
   description = "Default tags for the deployment"
+  default     = {}
+  nullable    = false
 }