Testing default registry host value in pipeline

Author: micjustus-nc

.azuredevops/templates/steps/tf_plan.yaml

@@ -2,13 +2,7 @@
 
 parameters:
   - name: tfCommandOptions
-    type: string
     default: ''
-  - name: imageHash
-    type: string
-    default: ''
-  - name: registryHost
-    type: string
 
 steps:
   - template: tf_init.yaml
@@ -32,8 +26,8 @@ steps:
       commandOptions: >
         -input=false
         -var-file=$(tfVarsFile)
-        -var="image_commit_hash=${{ parameters.imageHash }}"
-        -var="registry_host=${{ parameters.registryHost }}"
+        -var="image_commit_hash=$(imageHash)"
+        -var="registry_host=$(registryHost)"
         ${{ parameters.tfCommandOptions }}
         -out=$(Build.ArtifactStagingDirectory)/$(ENVIRONMENT).tfplan
       environmentServiceNameAzureRM: $(SERVICE_CONNECTION)

.github/workflows/stage-3-build.yaml

@@ -235,7 +235,7 @@ jobs:
         env:
           container_registry: ${{ env.REGISTRY_HOST }}
           docker_services: >-
-            ${{ join(fromJSON(needs.containers-to-build.outputs.docker_services || '[]'), ',') }}
+            ${{ needs.containers-to-build.outputs.docker_services && join(fromJSON(needs.containers-to-build.outputs.docker_services || '[]'), ',') }}
         run: |
           echo Running 'docker buildx imagetools' on remote repositories...
 
@@ -261,15 +261,15 @@ jobs:
 
       - name: Call deployment pipeline
         if: success()
+        env:
+          container_registry: ${{ env.REGISTRY_HOST }}
         run: |
           az pipelines run \
           --branch "main" \
           --name cd-infrastructure-dev-core \
           --org https://dev.azure.com/nhse-dtos \
           --project ${project_name} \
-          --parameters \
-              imageHash="${short_commit_hash}" \
-              registryHost="${REGISTRY_HOST}"
+          --parameters "imageHash=${short_commit_hash}" "registryHost=${container_registry,,}"
 
   aggregate-reports:
     name: Aggregate reports