Merge pull request #482 from NHSDigital/change-appointment-number-field-type

Alter Appointment#number field to CharField

Author: steventux

manage_breast_screening/notifications/migrations/0019_alter_appointment_number.py

@@ -0,0 +1,18 @@
+# Generated by Django 5.2.6 on 2025-10-02 09:31
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('notifications', '0018_alter_appointment_status'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='appointment',
+            name='number',
+            field=models.CharField(max_length=30, null=True),
+        ),
+    ]

manage_breast_screening/notifications/models.py

@@ -128,7 +128,7 @@ class Meta:
     booked_at = models.DateTimeField(null=True)
     cancelled_by = models.CharField(max_length=50)
     cancelled_at = models.DateTimeField(null=True)
-    number = models.IntegerField(null=True, default=1)
+    number = models.CharField(max_length=30, null=True)
     starts_at = models.DateTimeField(null=False)
     created_at = models.DateTimeField(null=False, auto_now_add=True)
     updated_at = models.DateTimeField(null=True, auto_now=True)

manage_breast_screening/notifications/tests/fixtures/ABC_20241202091221_APPT_106.dat

@@ -2,5 +2,5 @@
 "NBSSAPPT_FLDS"|"Sequence"|"BSO"|"Action"|"Clinic Code"|"Holding Clinic"|"Status"|"Attended Not Scr"|"Appointment ID"|"NHS Num"|"Epsiode Type"|"Episode Start"|"BatchID"|"Screen or Asses"|"Screen Appt num"|"Booked By"|"Cancelled By"|"Appt Date"|"Appt Time"|"Location"|"Clinic Name"|"Clinic Name (Let)"|"Clinic Address 1"|"Clinic Address 2"|"Clinic Address 3"|"Clinic Address 4"|"Clinic Address 5"|"Postcode"|"Action Timestamp"
 "NBSSAPPT_DATA"|"000001"|"KMK"|"C"|"BU003"|"N"|"C"|"N"|"BU003-67215-RA1-DN-Z2222-1"|"9449304424"|"S"|"20250102"|"KMKS02441"|"S"|""|"C"|"H"|"20250110"|"0845"|"MKGH"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"MILTON KEYNES HOSPITAL"|"STANDING WAY"|"MILTON KEYNES"|"MK6 5LD"|"MK6 5LD"|"20250123-121433"
 "NBSSAPPT_DATA"|"000002"|"KMK"|"B"|"BU011"|"N"|"B"|"N"|"BU011-67278-RA1-DN-Y1111-1"|"9449305552"|"S"|"20250128"|"KMK001326"|"S"|"1"|"H"|""|"20250314"|"1345"|"MKGH"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"MILTON KEYNES HOSPITAL"|"STANDING WAY"|"MILTON KEYNES"|"MK6 5LD"|"MK6 5LD"|"20250128-154003"
-"NBSSAPPT_DATA"|"000003"|"KMK"|"B"|"BU011"|"N"|"B"|"N"|"BU011-67278-RA1-DN-X0000-1"|"9449306621"|"F"|"20250128"|"KMK001326"|"A"|"3"|"H"|""|"20250314"|"1445"|"MKGH"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"MILTON KEYNES HOSPITAL"|"STANDING WAY"|"MILTON KEYNES"|"MK6 5LD"|"MK6 5LD"|"20250128-154004"
+"NBSSAPPT_DATA"|"000003"|"KMK"|"B"|"BU011"|"N"|"B"|"N"|"BU011-67278-RA1-DN-X0000-1"|"9449306621"|"F"|"20250128"|"KMK001326"|"A"|""|"H"|""|"20250314"|"1445"|"MKGH"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"BREAST CARE UNIT"|"MILTON KEYNES HOSPITAL"|"STANDING WAY"|"MILTON KEYNES"|"MK6 5LD"|"MK6 5LD"|"20250128-154004"
 "NBSSAPPT_END"|"00000013"|"20250128"|"17:09:22"|"000003"

manage_breast_screening/notifications/tests/management/commands/test_create_appointments.py

@@ -114,8 +114,8 @@ def test_handle_creates_records(self):
         assert appointments[0].clinic == clinics[1]
         assert appointments[1].clinic == clinics[1]
 
-        assert appointments[0].number == 1
-        assert appointments[1].number == 3
+        assert appointments[0].number == "1"
+        assert appointments[1].number == ""
 
         assert appointments[1].assessment is True