Handle stale deletes when appointment note doesn't exist

If a user clicks on a stale delete link for an appointment note that has
already been deleted, simply redirect them back to the note tab.

Author: malcolmbaig

manage_breast_screening/mammograms/tests/views/test_appointment_note_views.py

@@ -85,3 +85,36 @@ def test_users_can_update_note(self, request, client_fixture):
         updated_note = AppointmentNote.objects.get(pk=note.pk)
         assert updated_note.content == updated_content
         assert AppointmentNote.objects.count() == 1
+
+
+@pytest.mark.django_db
+class TestDeleteAppointmentNoteView:
+    def test_get_redirects_when_note_does_not_exist(self, clinical_user_client):
+        appointment = AppointmentFactory.create(
+            clinic_slot__clinic__setting__provider=clinical_user_client.current_provider
+        )
+        response = clinical_user_client.http.get(
+            reverse(
+                "mammograms:delete_appointment_note",
+                kwargs={"pk": appointment.pk},
+            )
+        )
+        assertRedirects(
+            response,
+            reverse("mammograms:appointment_note", kwargs={"pk": appointment.pk}),
+        )
+
+    def test_post_redirects_when_note_does_not_exist(self, clinical_user_client):
+        appointment = AppointmentFactory.create(
+            clinic_slot__clinic__setting__provider=clinical_user_client.current_provider
+        )
+        response = clinical_user_client.http.post(
+            reverse(
+                "mammograms:delete_appointment_note",
+                kwargs={"pk": appointment.pk},
+            )
+        )
+        assertRedirects(
+            response,
+            reverse("mammograms:appointment_note", kwargs={"pk": appointment.pk}),
+        )

manage_breast_screening/mammograms/views/appointment_note_views.py

@@ -78,3 +78,15 @@ def get_object(self):
 
     def get_success_url(self):
         return reverse("mammograms:appointment_note", kwargs={"pk": self.kwargs["pk"]})
+
+    def get(self, request, *args, **kwargs):
+        try:
+            return super().get(request, *args, **kwargs)
+        except AppointmentNote.DoesNotExist:
+            return redirect(self.get_success_url())
+
+    def post(self, request, *args, **kwargs):
+        try:
+            return super().post(request, *args, **kwargs)
+        except AppointmentNote.DoesNotExist:
+            return redirect(self.get_success_url())