more tests

Author: swebberuk

manage_breast_screening/mammograms/tests/forms/test_breast_augmentation_history_form.py

@@ -5,6 +5,7 @@
 from django.http import QueryDict
 from django.test import RequestFactory
 
+from manage_breast_screening.core.models import AuditLog
 from manage_breast_screening.participants.models.breast_augmentation_history_item import (
     BreastAugmentationHistoryItem,
 )
@@ -304,7 +305,7 @@ def test_removal_year_when_not_removed(self, clinical_user):
                         "procedure_year": 2010,
                         "removal_status": [],
                         "removal_year": 2025,
-                        "additional_details": "removal_year but no removal_status is empty",
+                        "additional_details": "removal_year provided but removal_status is empty",
                     },
                     doseq=True,
                 )
@@ -316,6 +317,7 @@ def test_removal_year_when_not_removed(self, clinical_user):
 
         obj = form.create(appointment=appointment, request=request)
 
+        obj.refresh_from_db()
         assert obj.appointment == appointment
         assert obj.right_breast_procedures == [
             BreastAugmentationHistoryItem.Procedure.BREAST_IMPLANTS
@@ -328,7 +330,10 @@ def test_removal_year_when_not_removed(self, clinical_user):
         assert not obj.implants_have_been_removed
         # confirm that removal_year is None, even though specified in request, as removal_status is empty
         assert obj.removal_year is None
-        assert obj.additional_details == "removal_year but no removal_status is empty"
+        assert (
+            obj.additional_details
+            == "removal_year provided but removal_status is empty"
+        )
 
     @pytest.mark.parametrize(
         "data",
@@ -424,8 +429,15 @@ def test_success(self, clinical_user, data):
 
         assert form.is_valid()
 
+        existing_log_count = AuditLog.objects.count()
         obj = form.create(appointment=appointment, request=request)
+        assert AuditLog.objects.count() == existing_log_count + 1
+        audit_log = AuditLog.objects.filter(
+            object_id=obj.pk, operation=AuditLog.Operations.CREATE
+        ).first()
+        assert audit_log.actor == clinical_user
 
+        obj.refresh_from_db()
         assert obj.appointment == appointment
         assert obj.left_breast_procedures == data.get("left_breast_procedures")
         assert obj.right_breast_procedures == data.get("right_breast_procedures")

manage_breast_screening/tests/system/clinical/test_breast_augmentation_history.py

@@ -18,7 +18,13 @@ def test_adding_breast_augmentation(self):
         self.when_i_click_on_add_breast_augmentation()
         self.then_i_see_the_add_breast_augmentation_form()
 
+        self.when_i_click_save_without_entering_details()
+        self.then_i_see_validation_errors_for_missing_benign_lump_details()
+
         self.when_i_select_procedures()
+        self.and_i_enter_the_procedure_year()
+        self.and_i_enter_the_removal_year()
+        self.and_i_enter_additional_details()
         self.and_i_click_save_augmentation()
         self.then_i_am_back_on_the_medical_information_page()
         self.and_the_augmentation_is_listed()
@@ -59,6 +65,18 @@ def then_i_see_the_add_breast_augmentation_form(self):
             "Add details of breast implants or augmentation"
         )
 
+    def then_i_see_validation_errors_for_missing_benign_lump_details(self):
+        self.expect_validation_error(
+            error_text="Select procedures for the right breast",
+            fieldset_legend="Right breast",
+            field_label="Breast implants (silicone or saline)",
+        )
+        self.expect_validation_error(
+            error_text="Select procedures for the left breast",
+            fieldset_legend="Left breast",
+            field_label="Breast implants (silicone or saline)",
+        )
+
     def when_i_select_procedures(self):
         self.page.get_by_role("group", name="Right breast").get_by_label(
             "Breast implants (silicone or saline)", exact=True
@@ -67,6 +85,21 @@ def when_i_select_procedures(self):
             "Other augmentation", exact=True
         ).click()
 
+    def and_i_enter_the_procedure_year(self):
+        self.page.get_by_label("Year of procedure (optional)", exact=True).fill("2000")
+
+    def and_i_enter_the_removal_year(self):
+        self.page.get_by_text("Implants have been removed").click()
+        self.page.get_by_label("Year removed (if available)", exact=True).fill("2025")
+
+    def and_i_enter_additional_details(self):
+        self.page.get_by_label("Additional details (optional)", exact=True).fill(
+            "additional details for test of breast augmentation history"
+        )
+
+    def when_i_click_save_without_entering_details(self):
+        self.and_i_click_save_augmentation()
+
     def and_i_click_save_augmentation(self):
         self.page.get_by_text("Save").click()
 
@@ -82,7 +115,12 @@ def and_the_augmentation_is_listed(self):
         expect(row).to_contain_text(
             "Right breast: Breast implants (silicone or saline)"
         )
-        expect(row).to_contain_text("Other augmentation")
+        expect(row).to_contain_text("Left breast: Other augmentation")
+        expect(row).to_contain_text("2000")
+        expect(row).to_contain_text("Yes (2025)")
+        expect(row).to_contain_text(
+            "additional details for test of breast augmentation history"
+        )
 
     def and_the_message_says_augmentation_added(self):
         alert = self.page.get_by_role("alert")