Handle multiple user edge case for medical info review

If a user submits a stale 'mark as reviewed' for a medical info section,
and it has already been reviewed by someone else, do nothing in the
database and simply display a warning flash message informing the user.

Author: malcolmbaig

manage_breast_screening/mammograms/tests/views/test_appointment_views.py

@@ -2,9 +2,13 @@
 from django.urls import reverse
 from pytest_django.asserts import assertContains, assertRedirects
 
+from manage_breast_screening.auth.tests.factories import UserFactory
 from manage_breast_screening.core.models import AuditLog
 from manage_breast_screening.participants.models import MedicalInformationReview
-from manage_breast_screening.participants.tests.factories import AppointmentFactory
+from manage_breast_screening.participants.tests.factories import (
+    AppointmentFactory,
+    MedicalInformationReviewFactory,
+)
 
 
 @pytest.mark.django_db
@@ -204,3 +208,31 @@ def test_creates_medical_information_review(self, clinical_user_client):
             appointment=appointment, section="SYMPTOMS"
         )
         assert review.reviewed_by == clinical_user_client.user
+
+    def test_does_not_update_reviewed_by_if_already_reviewed(
+        self, clinical_user_client
+    ):
+        appointment = AppointmentFactory.create(
+            clinic_slot__clinic__setting__provider=clinical_user_client.current_provider
+        )
+        original_user = UserFactory.create(first_name="Jane", last_name="Doe")
+        MedicalInformationReviewFactory.create(
+            appointment=appointment, section="SYMPTOMS", reviewed_by=original_user
+        )
+
+        response = clinical_user_client.http.post(
+            reverse(
+                "mammograms:mark_section_reviewed",
+                kwargs={"pk": appointment.pk, "section": "SYMPTOMS"},
+            ),
+            follow=True,
+        )
+
+        review = MedicalInformationReview.objects.get(
+            appointment=appointment, section="SYMPTOMS"
+        )
+        assert review.reviewed_by == original_user
+        assertContains(
+            response,
+            "This section has already been reviewed by Jane Doe",
+        )

manage_breast_screening/mammograms/views/appointment_views.py

@@ -1,5 +1,6 @@
 import logging
 
+from django.contrib import messages
 from django.http import Http404
 from django.shortcuts import redirect, render
 from django.urls import reverse, reverse_lazy
@@ -296,9 +297,23 @@ def post(self, request, *args, **kwargs):
         if section not in valid_sections:
             raise Http404("Invalid section")
 
-        self.appointment.medical_information_reviews.get_or_create(
+        existing_review = self.appointment.medical_information_reviews.filter(
+            section=section
+        ).first()
+
+        if existing_review:
+            messages.add_message(
+                request,
+                messages.WARNING,
+                f"This section has already been reviewed by {existing_review.reviewed_by.get_full_name()}",
+            )
+            return redirect(
+                "mammograms:record_medical_information", pk=self.appointment.pk
+            )
+
+        self.appointment.medical_information_reviews.create(
             section=section,
-            defaults={"reviewed_by": request.user},
+            reviewed_by=request.user,
         )
 
         return redirect("mammograms:record_medical_information", pk=self.appointment.pk)