Merge pull request #802 from NHSDigital/DTOSS-11767

Removed send_message_batch functionality

Author: dnimmo

docs/diagrams/workspace.dsl

@@ -42,10 +42,6 @@ workspace {
               technology "Event driven container app job"
               tags job
           }
-          send_message_batch = component "Send message batch / Retry failed message batch" "2 separate jobs" {
-              technology "Event driven container app job"
-              tags job
-          }
           create_appointments = component "Create appointments" {
               technology "Event driven container app job"
               tags job
@@ -126,10 +122,6 @@ workspace {
     store_mesh_messages -> mesh "Fetches appointments from" {
       tags store_mesh
     }
-    send_message_batch -> notify "Sends message requests"
-    send_message_batch -> retry_queue "Sends failed batches" {
-      tags send_retry
-    }
     create_appointments -> mesh_blob_container "Gets MESH messages"
     store_mesh_messages -> mesh_blob_container "Stores MESH messages"
     create_report -> reports_blob_container "Stores message status reports"

infrastructure/modules/container-apps/jobs.tf

@@ -16,18 +16,6 @@ locals {
       job_short_name     = "cap"
       job_container_args = "create_appointments"
     }
-    send_message_batch = {
-
-      # cron_expression = "0,30 9 * * 1-5"
-      cron_expression = null
-      environment_variables = {
-        API_OAUTH_TOKEN_URL              = var.api_oauth_token_url
-        NHS_NOTIFY_API_MESSAGE_BATCH_URL = var.nhs_notify_api_message_batch_url
-        RETRY_QUEUE_NAME                 = "notifications-message-batch-retries"
-      }
-      job_short_name     = "smb"
-      job_container_args = "send_message_batch"
-    }
     save_message_status = {
       # cron_expression = "0,30 * * * *"
       cron_expression = null

manage_breast_screening/notifications/README.md

@@ -73,9 +73,8 @@ The test performs the following steps:
 1. Uploads test data to a non-production MESH inbox
 2. Calls the `store_mesh_messages` Django admin command via the deployed container app job.
 3. Calls the `create_appointments` command which processes the test data and creates 1 clinic and 1 appointment.
-4. Calls `send_message_batch` which sends an appointment invite via integration NHS Notify API
-5. Calls `create_reports --smoke-test` which generates a smoke test specific report for the test data.
-6. Downloads the report from blob storage and verifies the contents.
+4. Calls `create_reports --smoke-test` which generates a smoke test specific report for the test data.
+5. Downloads the report from blob storage and verifies the contents.
 
 To run the smoke test on a deployed environment: