Merge pull request #778 from NHSDigital/11529-update-benign-lumps

Medical history — update benign lumps history

Author: malcolmbaig

manage_breast_screening/mammograms/forms/benign_lump_history_item_form.py

@@ -105,13 +105,33 @@ class BenignLumpHistoryItemForm(FormWithConditionalFields):
     )
 
     def __init__(self, *args, **kwargs):
+        self.instance = kwargs.pop("instance", None)
+
+        if self.instance:
+            kwargs["initial"] = self.initial_values(self.instance)
+
         super().__init__(*args, **kwargs)
 
         for location, detail_field in self.LOCATION_DETAIL_FIELDS.items():
             self.given_field_value("procedure_location", location).require_field(
                 detail_field
             )
 
+    def initial_values(self, instance):
+        initial = {
+            "left_breast_procedures": instance.left_breast_procedures,
+            "right_breast_procedures": instance.right_breast_procedures,
+            "procedure_year": instance.procedure_year,
+            "procedure_location": instance.procedure_location,
+            "additional_details": instance.additional_details,
+        }
+
+        detail_field = self.LOCATION_DETAIL_FIELDS.get(instance.procedure_location)
+        if detail_field:
+            initial[detail_field] = instance.procedure_location_details
+
+        return initial
+
     def create(self, appointment, request):
         auditor = Auditor.from_request(request)
 
@@ -131,6 +151,27 @@ def create(self, appointment, request):
 
         return benign_lump_history_item
 
+    def update(self, request):
+        auditor = Auditor.from_request(request)
+
+        self.instance.left_breast_procedures = self.cleaned_data.get(
+            "left_breast_procedures", []
+        )
+        self.instance.right_breast_procedures = self.cleaned_data.get(
+            "right_breast_procedures", []
+        )
+        self.instance.procedure_year = self.cleaned_data.get("procedure_year")
+        self.instance.procedure_location = self.cleaned_data["procedure_location"]
+        self.instance.procedure_location_details = self._get_selected_location_details()
+        self.instance.additional_details = self.cleaned_data.get(
+            "additional_details", ""
+        )
+
+        self.instance.save()
+        auditor.audit_update(self.instance)
+
+        return self.instance
+
     @property
     def location_detail_fields(self):
         return tuple(self.LOCATION_DETAIL_FIELDS.items())

manage_breast_screening/mammograms/jinja2/mammograms/record_medical_information.jinja

@@ -95,6 +95,7 @@
   {% set benign_lump_history_html %}
     {% for presented_item in presenter.benign_lump_history %}
       {{ summaryList(presented_item.summary_list_params) }}
+      <p><a href="{{ presented_item.change_link.href }}" class="nhsuk-link nhsuk-link--no-visited-state">{{ presented_item.change_link.text }}</a></p>
     {% endfor %}
     <a href="{{ presenter.add_benign_lump_history_link.href }}" class="nhsuk-link nhsuk-link--no-visited-state">{{ presenter.add_benign_lump_history_link.text }}</a><br>
   {% endset %}

manage_breast_screening/mammograms/presenters/benign_lump_history_item_presenter.py

@@ -1,3 +1,5 @@
+from django.urls import reverse
+
 from manage_breast_screening.core.template_helpers import multiline_content, nl2br
 from manage_breast_screening.participants.models.benign_lump_history_item import (
     BenignLumpHistoryItem,
@@ -20,7 +22,6 @@ def __init__(self, benign_lump_history_item):
 
     @property
     def summary_list_params(self):
-        # This is a placeholder until we have a properly formatted table.
         return {
             "rows": [
                 {
@@ -48,7 +49,20 @@ def summary_list_params(self):
                     "key": {"text": "Additional details"},
                     "value": {"html": self.additional_details},
                 },
-            ],
+            ]
+        }
+
+    @property
+    def change_link(self):
+        return {
+            "href": reverse(
+                "mammograms:change_benign_lump_history_item",
+                kwargs={
+                    "pk": self._item.appointment_id,
+                    "history_item_pk": self._item.id,
+                },
+            ),
+            "text": "Change",
         }
 
     def _format_multiple_choices(self, choices, ChoiceClass):

manage_breast_screening/mammograms/tests/forms/test_benign_lump_history_item_form.py

@@ -5,14 +5,16 @@
 from django.http import QueryDict
 from django.test import RequestFactory
 
-from manage_breast_screening.core.models import AuditLog
 from manage_breast_screening.mammograms.forms.benign_lump_history_item_form import (
     BenignLumpHistoryItemForm,
 )
 from manage_breast_screening.participants.models.benign_lump_history_item import (
     BenignLumpHistoryItem,
 )
-from manage_breast_screening.participants.tests.factories import AppointmentFactory
+from manage_breast_screening.participants.tests.factories import (
+    AppointmentFactory,
+    BenignLumpHistoryItemFactory,
+)
 
 
 def _form_data(data):
@@ -85,7 +87,7 @@ def test_procedure_year_must_be_within_range(
         assert not form.is_valid()
         assert form.errors.get("procedure_year") == [expected_message]
 
-    def test_create_persists_data_and_audits(self, clinical_user):
+    def test_create_persists_data(self, clinical_user):
         appointment = AppointmentFactory()
         request = RequestFactory().post("/test-form")
         request.user = clinical_user
@@ -110,13 +112,7 @@ def test_create_persists_data_and_audits(self, clinical_user):
         form = BenignLumpHistoryItemForm(_form_data(data))
         assert form.is_valid()
 
-        existing_log_count = AuditLog.objects.count()
         obj = form.create(appointment=appointment, request=request)
-        assert AuditLog.objects.count() == existing_log_count + 1
-        audit_log = AuditLog.objects.filter(
-            object_id=obj.pk, operation=AuditLog.Operations.CREATE
-        ).first()
-        assert audit_log.actor == clinical_user
 
         obj.refresh_from_db()
         assert obj.appointment == appointment
@@ -132,3 +128,75 @@ def test_create_persists_data_and_audits(self, clinical_user):
         )
         assert obj.procedure_location_details == "St Thomas' Hospital"
         assert obj.additional_details == "Additional details."
+
+    def test_initial_values_populated_from_instance(self):
+        instance = BenignLumpHistoryItemFactory(
+            left_breast_procedures=[
+                BenignLumpHistoryItem.Procedure.NEEDLE_BIOPSY,
+                BenignLumpHistoryItem.Procedure.LUMP_REMOVED,
+            ],
+            right_breast_procedures=[BenignLumpHistoryItem.Procedure.NO_PROCEDURES],
+            procedure_year=2020,
+            procedure_location=BenignLumpHistoryItem.ProcedureLocation.OUTSIDE_UK,
+            procedure_location_details="Hospital in France",
+            additional_details="Some additional notes",
+        )
+
+        form = BenignLumpHistoryItemForm(instance=instance)
+
+        assert form.initial["left_breast_procedures"] == [
+            BenignLumpHistoryItem.Procedure.NEEDLE_BIOPSY,
+            BenignLumpHistoryItem.Procedure.LUMP_REMOVED,
+        ]
+        assert form.initial["right_breast_procedures"] == [
+            BenignLumpHistoryItem.Procedure.NO_PROCEDURES
+        ]
+        assert form.initial["procedure_year"] == 2020
+        assert form.initial["procedure_location"] == (
+            BenignLumpHistoryItem.ProcedureLocation.OUTSIDE_UK
+        )
+        assert form.initial["outside_uk_details"] == "Hospital in France"
+        assert form.initial["additional_details"] == "Some additional notes"
+
+    def test_update_persists_changes(self, clinical_user):
+        instance = BenignLumpHistoryItemFactory(
+            left_breast_procedures=[BenignLumpHistoryItem.Procedure.NEEDLE_BIOPSY],
+            right_breast_procedures=[BenignLumpHistoryItem.Procedure.NO_PROCEDURES],
+            procedure_year=2020,
+            procedure_location=BenignLumpHistoryItem.ProcedureLocation.NHS_HOSPITAL,
+            procedure_location_details="Original Hospital",
+            additional_details="Original details",
+        )
+        request = RequestFactory().post("/test-form")
+        request.user = clinical_user
+
+        data = [
+            ("left_breast_procedures", BenignLumpHistoryItem.Procedure.LUMP_REMOVED),
+            (
+                "right_breast_procedures",
+                BenignLumpHistoryItem.Procedure.NEEDLE_BIOPSY,
+            ),
+            ("procedure_year", 2021),
+            (
+                "procedure_location",
+                BenignLumpHistoryItem.ProcedureLocation.PRIVATE_CLINIC_UK,
+            ),
+            ("private_clinic_uk_details", "Private Hospital Updated"),
+            ("additional_details", "Updated details"),
+        ]
+        form = BenignLumpHistoryItemForm(_form_data(data), instance=instance)
+        assert form.is_valid()
+        updated_obj = form.update(request=request)
+        assert updated_obj.pk == instance.pk
+        assert updated_obj.left_breast_procedures == [
+            BenignLumpHistoryItem.Procedure.LUMP_REMOVED
+        ]
+        assert updated_obj.right_breast_procedures == [
+            BenignLumpHistoryItem.Procedure.NEEDLE_BIOPSY
+        ]
+        assert updated_obj.procedure_year == 2021
+        assert updated_obj.procedure_location == (
+            BenignLumpHistoryItem.ProcedureLocation.PRIVATE_CLINIC_UK
+        )
+        assert updated_obj.procedure_location_details == "Private Hospital Updated"
+        assert updated_obj.additional_details == "Updated details"

manage_breast_screening/mammograms/tests/presenters/test_benign_lump_history_item_presenter.py

@@ -25,7 +25,8 @@ def test_summary_list_params(self):
 
         presenter = BenignLumpHistoryItemPresenter(item)
 
-        assert presenter.summary_list_params == {
+        result = presenter.summary_list_params
+        assert result == {
             "rows": [
                 {
                     "key": {"text": "Procedures"},
@@ -52,3 +53,13 @@ def test_summary_list_params(self):
                 },
             ],
         }
+
+    def test_change_link(self):
+        item = BenignLumpHistoryItemFactory.build()
+        presenter = BenignLumpHistoryItemPresenter(item)
+
+        result = presenter.change_link
+        assert result == {
+            "href": f"/mammograms/{item.appointment_id}/record-medical-information/benign-lump-history/{item.id}/",
+            "text": "Change",
+        }

manage_breast_screening/mammograms/urls.py

@@ -175,6 +175,11 @@
         benign_lump_history_item_views.AddBenignLumpHistoryItemView.as_view(),
         name="add_benign_lump_history_item",
     ),
+    path(
+        "<uuid:pk>/record-medical-information/benign-lump-history/<uuid:history_item_pk>/",
+        benign_lump_history_item_views.UpdateBenignLumpHistoryItemView.as_view(),
+        name="change_benign_lump_history_item",
+    ),
     path(
         "<uuid:pk>/record-medical-information/mastectomy-or-lumpectomy-history/",
         mastectomy_or_lumpectomy_history_view.AddMastectomyOrLumpectomyHistoryView.as_view(),

manage_breast_screening/mammograms/views/benign_lump_history_item_views.py

@@ -1,29 +1,28 @@
+import logging
+from typing import Any
+
 from django.contrib import messages
+from django.http import Http404
+from django.shortcuts import redirect
 from django.urls import reverse
 from django.views.generic import FormView
 
 from manage_breast_screening.mammograms.forms.benign_lump_history_item_form import (
     BenignLumpHistoryItemForm,
 )
+from manage_breast_screening.participants.models.benign_lump_history_item import (
+    BenignLumpHistoryItem,
+)
 
 from .mixins import InProgressAppointmentMixin
 
+logger = logging.getLogger(__name__)
 
-class AddBenignLumpHistoryItemView(InProgressAppointmentMixin, FormView):
+
+class BaseBenignLumpHistoryItemView(InProgressAppointmentMixin, FormView):
     form_class = BenignLumpHistoryItemForm
     template_name = "mammograms/medical_information/medical_history/forms/benign_lump_history_item_form.jinja"
 
-    def form_valid(self, form):
-        form.create(appointment=self.appointment, request=self.request)
-
-        messages.add_message(
-            self.request,
-            messages.SUCCESS,
-            "Benign lump history added",
-        )
-
-        return super().form_valid(form)
-
     def get_success_url(self):
         return reverse(
             "mammograms:record_medical_information", kwargs={"pk": self.appointment.pk}
@@ -48,9 +47,80 @@ def get_context_data(self, **kwargs):
                 "back_link_params": self.get_back_link_params(),
                 "caption": participant.full_name,
                 "participant_first_name": participant.first_name,
+            },
+        )
+
+        return context
+
+
+class AddBenignLumpHistoryItemView(BaseBenignLumpHistoryItemView):
+    def form_valid(self, form):
+        form.create(appointment=self.appointment, request=self.request)
+
+        messages.add_message(
+            self.request,
+            messages.SUCCESS,
+            "Benign lumps added",
+        )
+
+        return super().form_valid(form)
+
+    def get_context_data(self, **kwargs):
+        context = super().get_context_data(**kwargs)
+        context.update(
+            {
                 "heading": "Add details of benign lumps",
                 "page_title": "Add details of benign lumps",
             },
         )
+        return context
+
+
+class UpdateBenignLumpHistoryItemView(BaseBenignLumpHistoryItemView):
+    def get_instance(self):
+        try:
+            return BenignLumpHistoryItem.objects.get(
+                pk=self.kwargs["history_item_pk"],
+                appointment_id=self.kwargs["pk"],
+            )
+        except BenignLumpHistoryItem.DoesNotExist:
+            logger.exception("History item does not exist for kwargs=%s", self.kwargs)
+            return None
+
+    def get(self, request, *args, **kwargs):
+        self.instance = self.get_instance()
+        if self.instance is None:
+            return redirect(self.get_success_url())
+        return super().get(request, *args, **kwargs)
+
+    def post(self, request, *args, **kwargs):
+        self.instance = self.get_instance()
+        if self.instance is None:
+            raise Http404
+        return super().post(request, *args, **kwargs)
+
+    def get_form_kwargs(self) -> dict[str, Any]:
+        kwargs = super().get_form_kwargs()
+        kwargs["instance"] = self.instance
+        return kwargs
+
+    def form_valid(self, form):
+        form.update(request=self.request)
+
+        messages.add_message(
+            self.request,
+            messages.SUCCESS,
+            "Benign lumps updated",
+        )
 
+        return super().form_valid(form)
+
+    def get_context_data(self, **kwargs):
+        context = super().get_context_data(**kwargs)
+        context.update(
+            {
+                "heading": "Change details of benign lumps",
+                "page_title": "Change details of benign lumps",
+            },
+        )
         return context