Merge pull request #740 from NHSDigital/fix-notifications-smoke-test-conditional

Fix `RUN_NOTIFICATIONS_SMOKE_TEST` variable check

Author: steventux

infrastructure/modules/container-apps/jobs.tf

@@ -110,7 +110,7 @@ module "scheduled_jobs" {
   source = "../dtos-devops-templates/infrastructure/modules/container-app-job"
   for_each = {
     for k, v in local.scheduled_jobs : k => v
-    if var.run_notifications_smoke_test
+    if(var.run_notifications_smoke_test || k != "smoke_test")
   }
 
   name                         = "${var.app_short_name}-${each.value.job_short_name}-${var.environment}"

scripts/terraform/terraform.mk

@@ -76,8 +76,9 @@ terraform-validate: terraform-init-no-backend # Validate Terraform changes - mak
 	terraform -chdir=infrastructure/terraform validate
 
 notifications-smoke-test:
-	$(if ${TF_VAR_run_notifications_smoke_test}, \
-		pip install pytest mesh-client \
-		pytest -vv scripts/python/smoke_test/notifications_smoke_test.py, \
-		echo "Notifications smoke test skipped." \
-	)
+	if test "${RUN_NOTIFICATIONS_SMOKE_TEST}" == "true"; then
+		pip install pytest mesh-client
+		pytest -vv scripts/python/smoke_test/notifications_smoke_test.py
+	else
+		echo "Skipping notifications smoke test"
+	fi