Apply role=alert to all notification banners

Without this, info/warning banners (ie - any type other than 'success')
will not have autofocus on page load. We apply this change on the basis
that we want to autofocus all banners in the service. If a need arises
to disable this behaviour, we can use the disable_autofocus param.

Author: malcolmbaig

manage_breast_screening/core/template_helpers.py

@@ -109,6 +109,7 @@ def get_notification_banner_params(
         params["html"] = Markup(message)
     else:
         params["text"] = message
+    params["role"] = "alert"
     return params
 
 

manage_breast_screening/core/tests/test_template_helpers.py

@@ -80,15 +80,15 @@ def dummy_request(self):
 
     def test_info_banner_with_text_message(self, dummy_request):
         result = get_notification_banner_params(dummy_request, "info")
-        assert result == {"text": "abc", "type": "info"}
+        assert result == {"text": "abc", "type": "info", "role": "alert"}
 
     def test_success_banner_with_text_message(self, dummy_request):
         result = get_notification_banner_params(dummy_request, "success")
-        assert result == {"text": "def", "type": "success"}
+        assert result == {"text": "def", "type": "success", "role": "alert"}
 
     def test_warning_banner_with_text_message(self, dummy_request):
         result = get_notification_banner_params(dummy_request, "warning")
-        assert result == {"text": "warning!", "type": "warning"}
+        assert result == {"text": "warning!", "type": "warning", "role": "alert"}
 
     def test_invalid_message_type(self, dummy_request):
         with pytest.raises(
@@ -101,7 +101,12 @@ def test_autofocus_can_be_disabled(self, dummy_request):
         result = get_notification_banner_params(
             dummy_request, "info", disable_auto_focus=True
         )
-        assert result == {"text": "abc", "type": "info", "disableAutoFocus": True}
+        assert result == {
+            "text": "abc",
+            "type": "info",
+            "disableAutoFocus": True,
+            "role": "alert",
+        }
 
 
 class TestNotificationBannerParamsForHTMLMessages:
@@ -116,8 +121,8 @@ def dummy_request(self):
 
     def test_info_banner_with_html_message(self, dummy_request):
         result = get_notification_banner_params(dummy_request, "info")
-        assert result == {"html": mark_safe("abc"), "type": "info"}
+        assert result == {"html": mark_safe("abc"), "type": "info", "role": "alert"}
 
     def test_success_banner_with_html_message(self, dummy_request):
         result = get_notification_banner_params(dummy_request, "success")
-        assert result == {"html": mark_safe("def"), "type": "success"}
+        assert result == {"html": mark_safe("def"), "type": "success", "role": "alert"}

manage_breast_screening/tests/system/clinical/test_appointment_tabs.py

@@ -180,14 +180,14 @@ def then_i_should_see_the_demographic_banner(self):
         expect(self.page.get_by_text("NHS Number")).to_be_visible()
 
     def and_the_message_says_in_progress_with_someone_else(self):
-        alert = self.page.get_by_role("region")
+        alert = self.page.get_by_role("alert")
         expect(alert).to_contain_text("Important")
         expect(alert).to_contain_text(
             "This appointment is currently being run by F. Lastname."
         )
 
     def and_no_message_says_in_progress_with_someone_else(self):
-        expect(self.page.get_by_role("region")).not_to_be_attached()
+        expect(self.page.get_by_role("alert")).not_to_be_attached()
 
     def when_i_change_to_the_participant_details_tab(self):
         self.when_i_change_to_an_appointment_tab("Participant")