testing refactoring

Author: cameronhargreaves1-nhs

manage_breast_screening/notifications/tests/management/commands/test_create_appointments.py

@@ -9,7 +9,6 @@
 
 from manage_breast_screening.notifications.management.commands.create_appointments import (
     Command,
-    ExtractValidationError,
 )
 from manage_breast_screening.notifications.models import (
     ZONE_INFO,
@@ -60,6 +59,25 @@ def stored_blob_data(prefix_dir: str, filenames: list[str]):
             mock_blob_contents
         )
         yield
+        
+@contextmanager
+def mocked_blob_storage_contents(prefix_dir: str, filename: str, contents: str):
+    with mocked_blob_storage() as mock_blob_storage:
+        mock_container_client = (
+            mock_blob_storage.return_value.find_or_create_container.return_value
+        )
+        mock_blobs = []
+        mock_blob_contents = []
+        mock_blob = Mock(spec=BlobProperties)
+        mock_blob.name = f"{prefix_dir}/{filename}"
+        mock_blobs.append(mock_blob)
+        mock_blob_contents = contents
+
+        mock_container_client.list_blobs.return_value = mock_blobs
+        mock_container_client.get_blob_client().download_blob().readall.side_effect = (
+            mock_blob_contents
+        )
+        yield
 
 @pytest.mark.django_db
 class TestCreateAppointments:
@@ -396,18 +414,20 @@ def test_extract_id_not_sequential_previous(self, mock_insights_logger):
         """ Test when an extract is not sequential to the previous extract, a warning is logged """
         today_dirname = datetime.now().strftime("%Y-%m-%d")
 
-        filename = f"{today_dirname}/{VALID_DATA_FILE}"
+        first_filename = f"{today_dirname}/{VALID_DATA_FILE}"
 
         raw_data = '"NBSSAPPT_HDR"|"00000013"|"20250128"|"170922"|"000001"'
 
         previous_raw_data = '"NBSSAPPT_HDR"|"00000012"|"20250128"|"170922"|"000001"'
 
-        Command().create_extract(filename, raw_data)
-        
-        with pytest.raises(ExtractValidationError) as error:
-            Command().validate_extract(filename, previous_raw_data)
-            assert str(error.value) == "Extract ID 12 is not sequential to last extract ID 13."
-        
+        # add previous extract so we can test the non sequential extract
+        Command().create_extract(first_filename, raw_data)
+
+        with mocked_blob_storage_contents(today_dirname, "ANOTHER_FILE_NAME.dat", previous_raw_data):
+            with pytest.raises(CommandError) as error:
+                Command().handle(**{"date_str": today_dirname})
+                assert str(error.value) == "Extract ID 12 is not sequential to last extract ID 13."
+
         assert Extract.objects.count() == 1
 
 
@@ -421,9 +441,10 @@ def test_extract_same_bso_and_extract_id(self, mock_insights_logger):
 
         same_bso_and_extract_id_raw_data = '"NBSSAPPT_HDR"|"00000013"|"20250128"|"170922"|"000001"'
 
-        with pytest.raises(ExtractValidationError) as error:
-            Command().validate_extract(filename, same_bso_and_extract_id_raw_data)
-            assert str(error.value) == "Extract ID 13 is not sequential to last extract ID 13."
+        with mocked_blob_storage_contents(today_dirname, "ANOTHER_FILE_NAME.dat", same_bso_and_extract_id_raw_data):
+            with pytest.raises(CommandError) as error:
+                Command().handle(**{"date_str": today_dirname})
+                assert str(error.value) == "Extract ID 13 is not sequential to last extract ID 13."
 
     def test_extract_not_sequential_skipped_extract(self, mock_insights_logger):
         """ Test when an extract is not the next extract in order (i.e. skipped an extract), a warning is logged """
@@ -436,9 +457,7 @@ def test_extract_not_sequential_skipped_extract(self, mock_insights_logger):
 
         skip_extract_raw_data = '"NBSSAPPT_HDR"|"00000025"|"20250128"|"170922"|"000001"'
 
-        with pytest.raises(ExtractValidationError) as error:
-            Command().validate_extract(filename, skip_extract_raw_data)
-            assert str(error.value) == "Extract ID 25 is not sequential to last extract ID 13."
-        
-        assert Extract.objects.count() == 1
-        
+        with mocked_blob_storage_contents(today_dirname, "ANOTHER_FILE_NAME.dat", skip_extract_raw_data):
+            with pytest.raises(CommandError) as error:
+                Command().handle(**{"date_str": today_dirname})
+                assert str(error.value) == "Extract ID 25 is not sequential to last extract ID 13."