Merge pull request #760 from NHSDigital/DTOSS-11525-update-history-of-cysts

Medical history - update history of cysts

Author: MatMoore

manage_breast_screening/mammograms/forms/cyst_history_form.py

@@ -2,16 +2,13 @@
 from django.forms.widgets import Textarea
 
 from manage_breast_screening.core.services.auditor import Auditor
-from manage_breast_screening.nhsuk_forms.fields import (
-    CharField,
-    ChoiceField,
-)
+from manage_breast_screening.nhsuk_forms.fields import CharField, ChoiceField
 from manage_breast_screening.participants.models.cyst_history_item import (
     CystHistoryItem,
 )
 
 
-class CystHistoryForm(Form):
+class CystHistoryBaseForm(Form):
     def __init__(self, *args, participant, **kwargs):
         super().__init__(*args, **kwargs)
 
@@ -38,6 +35,8 @@ def model_values(self):
             additional_details=self.cleaned_data.get("additional_details", ""),
         )
 
+
+class CystHistoryForm(CystHistoryBaseForm):
     def create(self, appointment, request):
         auditor = Auditor.from_request(request)
         field_values = self.model_values()
@@ -50,3 +49,25 @@ def create(self, appointment, request):
         auditor.audit_create(cyst_history)
 
         return cyst_history
+
+
+class CystHistoryUpdateForm(CystHistoryBaseForm):
+    def __init__(self, instance, *args, **kwargs):
+        self.instance = instance
+
+        kwargs["participant"] = instance.participant
+        kwargs["initial"] = {
+            "treatment": instance.treatment,
+            "additional_details": instance.additional_details,
+        }
+
+        super().__init__(*args, **kwargs)
+
+    def update(self, request):
+        self.instance.treatment = self.cleaned_data["treatment"]
+        self.instance.additional_details = self.cleaned_data["additional_details"]
+        self.instance.save()
+
+        Auditor.from_request(request).audit_update(self.instance)
+
+        return self.instance

manage_breast_screening/mammograms/jinja2/mammograms/record_medical_information.jinja

@@ -69,6 +69,9 @@
 
   {% set cyst_history_html %}
     {% for presented_item in presenter.cyst_history %}
+      <a style="float: right" class="nhsuk-link nhsuk-link--no-visited-state" href="{{ presented_item.change_link.href}}">
+        {{ presented_item.change_link.text }}<span class="nhsuk-u-visually-hidden">{{ presented_item.change_link.visually_hidden_text }}</span>
+      </a><br>
       {{ summaryList(presented_item.summary_list_params) }}
     {% endfor %}
     <a href="{{ presenter.add_cyst_history_link.href }}" class="nhsuk-link nhsuk-link--no-visited-state">{{ presenter.add_cyst_history_link.text }}</a><br>

manage_breast_screening/mammograms/presenters/cyst_history_item_presenter.py

@@ -1,10 +1,16 @@
+from django.urls import reverse
+
 from manage_breast_screening.core.template_helpers import nl2br
 
 
 class CystHistoryItemPresenter:
-    def __init__(self, breast_cancer_history_item):
+    def __init__(self, breast_cancer_history_item, counter=None):
         self._item = breast_cancer_history_item
 
+        # If there are more than one of these items, we add a counter to the
+        # visually hidden text
+        self.counter = counter
+
         self.treatment = self._item.get_treatment_display()
         self.additional_details = nl2br(self._item.additional_details)
 
@@ -23,3 +29,19 @@ def summary_list_params(self):
                 },
             ],
         }
+
+    @property
+    def change_link(self):
+        return {
+            "href": reverse(
+                "mammograms:change_cyst_history_item",
+                kwargs={
+                    "pk": self._item.appointment_id,
+                    "history_item_pk": self._item.pk,
+                },
+            ),
+            "text": "Change",
+            "visually_hidden_text": (
+                f" cyst item {self.counter}" if self.counter else " cyst item"
+            ),
+        }

manage_breast_screening/mammograms/presenters/medical_information_presenter.py

@@ -60,10 +60,15 @@ def __init__(self, appointment):
             BenignLumpHistoryItemPresenter(item)
             for item in appointment.benign_lump_history_items.all()
         ]
-        self.cyst_history = [
-            CystHistoryItemPresenter(item)
-            for item in appointment.cyst_history_items.all()
-        ]
+
+        cyst_history_items = list(appointment.cyst_history_items.all())
+        if len(cyst_history_items) == 1:
+            self.cyst_history = [CystHistoryItemPresenter(cyst_history_items[0])]
+        else:
+            self.cyst_history = [
+                CystHistoryItemPresenter(item, counter=counter)
+                for counter, item in enumerate(cyst_history_items, 1)
+            ]
         self.existing_symptom_type_ids = {
             symptom.symptom_type_id for symptom in symptoms
         }

manage_breast_screening/mammograms/tests/forms/test_cyst_history_form.py

@@ -7,18 +7,25 @@
 from manage_breast_screening.participants.models.cyst_history_item import (
     CystHistoryItem,
 )
-from manage_breast_screening.participants.tests.factories import AppointmentFactory
+from manage_breast_screening.participants.tests.factories import (
+    AppointmentFactory,
+    CystHistoryItemFactory,
+)
+
+from ...forms.cyst_history_form import CystHistoryForm, CystHistoryUpdateForm
+
 
-from ...forms.cyst_history_form import CystHistoryForm
+@pytest.fixture
+def dummy_request(clinical_user):
+    request = RequestFactory().get("/test-form")
+    request.user = clinical_user
+    return request
 
 
 @pytest.mark.django_db
-class TestCystHistoryItemForm:
-    def test_no_data(self, clinical_user):
+class TestCystHistoryForm:
+    def test_no_data(self):
         appointment = AppointmentFactory()
-        request = RequestFactory().get("/test-form")
-        request.user = clinical_user
-
         form = CystHistoryForm(QueryDict(), participant=appointment.participant)
 
         assert not form.is_valid()
@@ -43,20 +50,64 @@ def test_no_data(self, clinical_user):
             },
         ],
     )
-    def test_success(self, clinical_user, data):
+    def test_success(self, data, dummy_request):
         appointment = AppointmentFactory()
-        request = RequestFactory().get("/test-form")
-        request.user = clinical_user
-
         form = CystHistoryForm(
             QueryDict(urlencode(data, doseq=True)),
             participant=appointment.participant,
         )
 
         assert form.is_valid()
 
-        obj = form.create(appointment=appointment, request=request)
+        obj = form.create(appointment=appointment, request=dummy_request)
 
         assert obj.appointment == appointment
         assert obj.treatment == data.get("treatment")
         assert obj.additional_details == data.get("additional_details", "")
+
+
+@pytest.mark.django_db
+class TestCystHistoryUpdateForm:
+    @pytest.fixture
+    def instance(self):
+        return CystHistoryItemFactory(
+            treatment=CystHistoryItem.Treatment.DRAINAGE_OR_REMOVAL
+        )
+
+    def test_no_data(self, instance):
+        form = CystHistoryUpdateForm(instance, QueryDict())
+
+        assert not form.is_valid()
+        assert form.errors == {"treatment": ["Select the treatment type"]}
+
+    @pytest.mark.parametrize(
+        "data",
+        [
+            {
+                "treatment": CystHistoryItem.Treatment.NO_TREATMENT,
+            },
+            {
+                "treatment": CystHistoryItem.Treatment.DRAINAGE_OR_REMOVAL,
+            },
+            {
+                "treatment": CystHistoryItem.Treatment.NO_TREATMENT,
+                "additional_details": "Some additional details",
+            },
+            {
+                "treatment": CystHistoryItem.Treatment.DRAINAGE_OR_REMOVAL,
+                "additional_details": "Some additional details",
+            },
+        ],
+    )
+    def test_success(self, instance, data, dummy_request):
+        form = CystHistoryUpdateForm(
+            instance,
+            QueryDict(urlencode(data, doseq=True)),
+        )
+
+        assert form.is_valid()
+
+        obj = form.update(request=dummy_request)
+        assert obj.appointment == instance.appointment
+        assert obj.treatment == data.get("treatment")
+        assert obj.additional_details == data.get("additional_details", "")

manage_breast_screening/mammograms/tests/presenters/test_cyst_history_item_presenter.py

@@ -4,9 +4,7 @@
 from manage_breast_screening.participants.models.cyst_history_item import (
     CystHistoryItem,
 )
-from manage_breast_screening.participants.tests.factories import (
-    CystHistoryItemFactory,
-)
+from manage_breast_screening.participants.tests.factories import CystHistoryItemFactory
 
 
 class TestCystHistoryItemPresenter:
@@ -37,3 +35,29 @@ def test_single(self):
                 },
             ],
         }
+
+    def test_change_link(self):
+        item = CystHistoryItemFactory.build(
+            treatment=CystHistoryItem.Treatment.NO_TREATMENT,
+            additional_details="Some additional details",
+        )
+
+        presenter = CystHistoryItemPresenter(item)
+        assert presenter.change_link == {
+            "href": f"/mammograms/{item.appointment_id}/record-medical-information/cyst-history/{item.pk}",
+            "text": "Change",
+            "visually_hidden_text": " cyst item",
+        }
+
+    def test_change_link_with_counter(self):
+        item = CystHistoryItemFactory.build(
+            treatment=CystHistoryItem.Treatment.NO_TREATMENT,
+            additional_details="Some additional details",
+        )
+
+        presenter = CystHistoryItemPresenter(item, counter=2)
+        assert presenter.change_link == {
+            "href": f"/mammograms/{item.appointment_id}/record-medical-information/cyst-history/{item.pk}",
+            "text": "Change",
+            "visually_hidden_text": " cyst item 2",
+        }

manage_breast_screening/mammograms/tests/presenters/test_medical_information_presenter.py

@@ -9,6 +9,7 @@
 )
 from manage_breast_screening.participants.tests.factories import (
     AppointmentFactory,
+    CystHistoryItemFactory,
     SymptomFactory,
 )
 
@@ -124,6 +125,28 @@ def test_add_breast_cancer_history_link(self):
             "text": "Add breast cancer history",
         }
 
+    def test_cyst_history_items_have_a_counter(self):
+        appointment = AppointmentFactory()
+        CystHistoryItemFactory.create_batch(2, appointment=appointment)
+
+        counters = [
+            item.counter
+            for item in MedicalInformationPresenter(appointment).cyst_history
+        ]
+
+        assert counters == [1, 2]
+
+    def test_single_cyst_history_item_has_no_counter(self):
+        appointment = AppointmentFactory()
+        CystHistoryItemFactory.create(appointment=appointment)
+
+        counters = [
+            item.counter
+            for item in MedicalInformationPresenter(appointment).cyst_history
+        ]
+
+        assert counters == [None]
+
     def test_implanted_medical_device_history_link(self):
         appointment = AppointmentFactory()
 

manage_breast_screening/mammograms/tests/views/test_cyst_history_views.py

@@ -8,6 +8,7 @@
 )
 from manage_breast_screening.participants.tests.factories import (
     AppointmentFactory,
+    CystHistoryItemFactory,
 )
 
 
@@ -75,3 +76,59 @@ def test_invalid_post_renders_response_with_errors(self, clinical_user_client):
             """,
             response.text,
         )
+
+
+@pytest.mark.django_db
+class TestChangeCystHistoryView:
+    @pytest.fixture
+    def appointment(self, clinical_user_client):
+        return AppointmentFactory.create(
+            clinic_slot__clinic__setting__provider=clinical_user_client.current_provider
+        )
+
+    @pytest.fixture
+    def history_item(self, appointment):
+        return CystHistoryItemFactory.create(
+            appointment=appointment, treatment=CystHistoryItem.Treatment.NO_TREATMENT
+        )
+
+    def test_renders_response(self, clinical_user_client, history_item):
+        response = clinical_user_client.http.get(
+            reverse(
+                "mammograms:change_cyst_history_item",
+                kwargs={
+                    "pk": history_item.appointment.pk,
+                    "history_item_pk": history_item.pk,
+                },
+            )
+        )
+        assert response.status_code == 200
+
+    def test_valid_post_redirects_to_appointment(
+        self, clinical_user_client, appointment, history_item
+    ):
+        response = clinical_user_client.http.post(
+            reverse(
+                "mammograms:change_cyst_history_item",
+                kwargs={"pk": appointment.pk, "history_item_pk": history_item.pk},
+            ),
+            {
+                "treatment": CystHistoryItem.Treatment.DRAINAGE_OR_REMOVAL,
+            },
+        )
+        assertRedirects(
+            response,
+            reverse(
+                "mammograms:record_medical_information",
+                kwargs={"pk": appointment.pk},
+            ),
+        )
+        assertMessages(
+            response,
+            [
+                messages.Message(
+                    level=messages.SUCCESS,
+                    message="Details of cysts updated",
+                )
+            ],
+        )

manage_breast_screening/mammograms/urls.py

@@ -140,6 +140,11 @@
         cyst_history_view.AddCystHistoryView.as_view(),
         name="add_cyst_history_item",
     ),
+    path(
+        "<uuid:pk>/record-medical-information/cyst-history/<uuid:history_item_pk>",
+        cyst_history_view.ChangeCystHistoryView.as_view(),
+        name="change_cyst_history_item",
+    ),
     path(
         "<uuid:pk>/record-medical-information/breast-augmentation-history/",
         breast_augmentation_history_view.AddBreastAugmentationHistoryView.as_view(),

manage_breast_screening/mammograms/views/breast_augmentation_history_view.py

@@ -2,9 +2,7 @@
 from django.urls import reverse
 from django.views.generic import FormView
 
-from ..forms.breast_augmentation_history_form import (
-    BreastAugmentationHistoryForm,
-)
+from ..forms.breast_augmentation_history_form import BreastAugmentationHistoryForm
 from .mixins import InProgressAppointmentMixin