Merge pull request #809 from NHSDigital/DTOSS-11768

removed create_status endpoint

Author: Harriethw

docs/diagrams/workspace.dsl

@@ -38,10 +38,6 @@ workspace {
 
         jobs = container "Functions" "Process events asynchronously" {
           technology "Event driven container app jobs"
-          save_message_status = component "Save message status" {
-              technology "Event driven container app job"
-              tags job
-          }
           create_appointments = component "Create appointments" {
               technology "Event driven container app job"
               tags job
@@ -118,23 +114,19 @@ workspace {
     user -> cis2 "Authenticates via"
     cis2 -> webApplication "Provides authentication token to"
 
-    save_message_status -> queue "Gets updates to save"
     store_mesh_messages -> mesh "Fetches appointments from" {
       tags store_mesh
     }
     create_appointments -> mesh_blob_container "Gets MESH messages"
     store_mesh_messages -> mesh_blob_container "Stores MESH messages"
     create_report -> reports_blob_container "Stores message status reports"
-    notify -> webApplication "Sends status updates to"
-    webApplication -> queue "Save message status"
 
     # Commented to avoid cluttering - Grouped with send_message_batch
     # retry_failed_message_batch -> retry_queue "Gets failed batches"
     # retry_failed_message_batch -> notify "Retry messages"
 
     # Commented to avoid cluttering - DB connection in view title
     # store_mesh_messages -> azurePostgres "Store messages to"
-    # save_message_status -> azurePostgres "Save message status"
     # send_message_batch -> azurePostgres "Gets appointments from"
     # create_appointments -> azurePostgres "Converts to appointments and clinic"
     # create_report -> azurePostgres "Gets message statuses from"

infrastructure/environments/dev/variables.tfvars

@@ -8,4 +8,3 @@ postgres_geo_redundant_backup_enabled = false
 protect_keyvault                      = false
 vnet_address_space                    = "10.128.0.0/16"
 seed_demo_data                        = true
-nhs_notify_api_message_batch_url      = "https://int.api.service.nhs.uk/comms/v1/message-batches"

infrastructure/environments/preprod/variables.tfvars

@@ -8,9 +8,7 @@ postgres_geo_redundant_backup_enabled = true
 protect_keyvault                      = true
 deploy_database_as_container          = false
 vnet_address_space                    = "10.10.0.0/16"
-nhs_notify_api_message_batch_url      = "https://int.api.service.nhs.uk/comms/v1/message-batches"
 seed_demo_data                        = false
-allowed_paths                         = ["/notifications/message-status/create"]
 enable_alerting                       = true
 enable_notifications_jobs_schedule    = true
 min_replicas                          = 2

infrastructure/environments/prod/variables.tfvars

@@ -8,8 +8,6 @@ postgres_sku_name                     = "GP_Standard_D2ds_v5"
 postgres_enable_high_availability     = true
 protect_keyvault                      = true
 vnet_address_space                    = "10.11.0.0/16"
-nhs_notify_api_message_batch_url      = "https://api.service.nhs.uk/comms/v1/message-batches"
-allowed_paths                         = ["/notifications/message-status/create"]
 enable_alerting                       = true
 use_apex_domain                       = true
 cae_zone_redundancy_enabled           = true

infrastructure/modules/container-apps/jobs.tf

@@ -16,16 +16,6 @@ locals {
       job_short_name     = "cap"
       job_container_args = "create_appointments"
     }
-    save_message_status = {
-      # cron_expression = "0,30 * * * *"
-      cron_expression = null
-      environment_variables = {
-        STATUS_UPDATES_QUEUE_NAME = "notifications-message-status-updates"
-        ENVIRONMENT               = var.environment
-      }
-      job_short_name     = "sms"
-      job_container_args = "save_message_status"
-    }
     create_reports = {
       # cron_expression = "0 21 * * 1-5"
       cron_expression = null