Merge pull request #634 from NHSDigital/DTOSS-11313-validation-exception

DTOSS-11313: Log to Insights if validation fails on create_message_status

Author: Harriethw

manage_breast_screening/notifications/tests/test_views.py

@@ -54,7 +54,7 @@ def test_create_message_status_with_valid_request():
         queue_instance.add.assert_called_once_with(json.dumps(body))
 
 
-def test_create_message_status_with_invalid_request():
+def test_create_message_status_with_invalid_request(mock_insights_logger):
     req = RequestFactory().post(
         "/notifications/message-status/create",
         {"some": "data"},
@@ -68,3 +68,7 @@ def test_create_message_status_with_invalid_request():
 
     assert response.status_code == expected_response.status_code
     assert response.text == expected_response.text
+
+    mock_insights_logger.assert_called_once_with(
+        "Request validation failed: Signature does not match"
+    )

manage_breast_screening/notifications/views.py

@@ -1,5 +1,3 @@
-import logging
-
 from django.contrib.auth.decorators import login_not_required
 from django.http import JsonResponse
 from django.views.decorators.csrf import csrf_exempt
@@ -8,6 +6,9 @@
 from manage_breast_screening.core.decorators import (
     basic_auth_exempt,
 )
+from manage_breast_screening.notifications.services.application_insights_logging import (
+    ApplicationInsightsLogging,
+)
 from manage_breast_screening.notifications.services.queue import Queue
 from manage_breast_screening.notifications.validators.request_validator import (
     RequestValidator,
@@ -22,7 +23,9 @@ def create_message_status(request):
     valid, message = RequestValidator(request).valid()
 
     if not valid:
-        logging.error("Request validation failed: %s", message)
+        ApplicationInsightsLogging().exception(
+            (f"Request validation failed: {message}")
+        )
         return JsonResponse({"error": {"message": message}}, status=400)
 
     Queue.MessageStatusUpdates().add(request.body.decode("ASCII"))