Export ENVIRONMENT prior to running smoke test

The review environment exports ENVIRONMENT and the smoke test defaults to dev when looking up this environment variable. So the smoke test passes for these environments but fails on preprod as the variable is not set. Ensure we export it prior to running the test.

Author: steventux

scripts/python/smoke_test/notifications_smoke_test.py

@@ -44,7 +44,6 @@ def configure():
     storage_account = f"stmanbrs{environment}uks"
 
     if pr_number != "":
-        environment = f"pr-{pr_number}"
         storage_account = f"stmanbrspr{pr_number}uks"
 
     resource_group_name = f"rg-manbrs-{environment}-container-app-uks"

scripts/terraform/terraform.mk

@@ -77,6 +77,8 @@ terraform-validate: terraform-init-no-backend # Validate Terraform changes - mak
 
 notifications-smoke-test:
 	if test "${RUN_NOTIFICATIONS_SMOKE_TEST}" == "true"; then
+		export PR_NUMBER=${PR_NUMBER}
+		export ENVIRONMENT=${ENVIRONMENT}
 		pip install pytest mesh-client
 		pytest -vv scripts/python/smoke_test/notifications_smoke_test.py
 	else