add ClinicSlot clean function

Because clinic and clinic slot start times are both datetime, it is currently possible to have a clinic slot that starts on a different day to the clinic. This adds a validation function which checks the clinic slot date and the clinic start_date are the same

Author: cameronhargreaves1-nhs

manage_breast_screening/clinics/models.py

@@ -4,6 +4,7 @@
 
 from django.conf import settings
 from django.contrib.postgres.fields import ArrayField
+from django.core.exceptions import ValidationError
 from django.core.validators import MinLengthValidator
 from django.db import models
 from django.db.models import OuterRef, Subquery
@@ -186,6 +187,12 @@ def __str__(self):
             self.clinic.setting.name + " " + self.starts_at.strftime("%Y-%m-%d %H:%M")
         )
 
+    def clean(self):
+        if self.starts_at.date() != self.clinic.starts_at.date():
+            raise ValidationError(
+                "Clinic slot must start on the same date as the clinic"
+            )
+
 
 class ClinicStatus(models.Model):
     SCHEDULED = "SCHEDULED"

manage_breast_screening/clinics/tests/test_models.py

@@ -3,13 +3,15 @@
 
 import pytest
 import time_machine
+from django.core.exceptions import ValidationError
 from pytest_django.asserts import assertQuerySetEqual
 
 from manage_breast_screening.auth.models import Role
 from manage_breast_screening.clinics import models
 
 from .factories import (
     ClinicFactory,
+    ClinicSlotFactory,
     ProviderFactory,
     UserAssignmentFactory,
     UserFactory,
@@ -87,6 +89,18 @@ def test_completed_ordering_by_ends_at():
     assertQuerySetEqual(completed, [clinic1, clinic2, clinic3])
 
 
+@pytest.mark.django_db
+def test_clean_clinic_slots():
+    clinic = ClinicFactory.build(starts_at=datetime(2024, 12, 29, 9, tzinfo=tz.utc))
+    clinic_slot = ClinicSlotFactory.build(
+        starts_at=datetime(2024, 12, 26, 9, tzinfo=tz.utc),
+        duration_in_minutes=30,
+        clinic=clinic,
+    )
+    with pytest.raises(ValidationError):
+        clinic_slot.clean()
+
+
 class TestUserAssignment:
     def test_str(self):
         user = UserFactory.build(first_name="John", last_name="Doe")