Skip to content

Removed send_message_batch functionality #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnimmo merged 1 commit into from
Dec 4, 2025
Merged

Removed send_message_batch functionality #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions docs/diagrams/workspace.dsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ workspace {
technology "Event driven container app job"
tags job
}
send_message_batch = component "Send message batch / Retry failed message batch" "2 separate jobs" {
technology "Event driven container app job"
tags job
}
create_appointments = component "Create appointments" {
technology "Event driven container app job"
tags job
Expand Down Expand Up @@ -126,10 +122,6 @@ workspace {
store_mesh_messages -> mesh "Fetches appointments from" {
tags store_mesh
}
send_message_batch -> notify "Sends message requests"
send_message_batch -> retry_queue "Sends failed batches" {
tags send_retry
}
create_appointments -> mesh_blob_container "Gets MESH messages"
store_mesh_messages -> mesh_blob_container "Stores MESH messages"
create_report -> reports_blob_container "Stores message status reports"
Expand Down
12 changes: 0 additions & 12 deletions infrastructure/modules/container-apps/jobs.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,6 @@ locals {
job_short_name = "cap"
job_container_args = "create_appointments"
}
send_message_batch = {

# cron_expression = "0,30 9 * * 1-5"
cron_expression = null
environment_variables = {
API_OAUTH_TOKEN_URL = var.api_oauth_token_url
NHS_NOTIFY_API_MESSAGE_BATCH_URL = var.nhs_notify_api_message_batch_url
RETRY_QUEUE_NAME = "notifications-message-batch-retries"
}
job_short_name = "smb"
job_container_args = "send_message_batch"
}
save_message_status = {
# cron_expression = "0,30 * * * *"
cron_expression = null
Expand Down
5 changes: 2 additions & 3 deletions manage_breast_screening/notifications/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,8 @@ The test performs the following steps:
1. Uploads test data to a non-production MESH inbox
2. Calls the `store_mesh_messages` Django admin command via the deployed container app job.
3. Calls the `create_appointments` command which processes the test data and creates 1 clinic and 1 appointment.
4. Calls `send_message_batch` which sends an appointment invite via integration NHS Notify API
5. Calls `create_reports --smoke-test` which generates a smoke test specific report for the test data.
6. Downloads the report from blob storage and verifies the contents.
4. Calls `create_reports --smoke-test` which generates a smoke test specific report for the test data.
5. Downloads the report from blob storage and verifies the contents.

To run the smoke test on a deployed environment:

Expand Down
97 changes: 0 additions & 97 deletions manage_breast_screening/notifications/management/commands/send_message_batch.py
View file
Open in desktop

This file was deleted.

Loading