Clinic show page snagging updates #863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmbaig
reviewed
Jan 5, 2026
manage_breast_screening/mammograms/presenters/appointment_presenters.py
Outdated
Show resolved
Hide resolved
malcolmbaig
reviewed
Jan 5, 2026
cameronhargreaves1-nhs
changed the title
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11867-clinic-show-snagging-updates
branch
from
7115104 to
532ebcf
Compare
gpeng
previously requested changes
Jan 7, 2026
Contributor
gpeng
left a comment
gpeng
left a comment
There was a problem hiding this comment.
Looking good. A couple of small comments. Also noticed that the last commit has a lot of fixes other than just adding testing. We should split that up and add them into the commits where the original work happened so as they make sense. We can pair and do the rebase together if that would help.
manage_breast_screening/tests/system/clinical/test_clinic_show_page.py
Outdated
Show resolved
Hide resolved
gpeng
force-pushed
the
DTOSS-11867-clinic-show-snagging-updates
branch
from
ddd671f to
2c2d8dd
Compare
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11867-clinic-show-snagging-updates
branch
3 times, most recently
from
1d918ad to
4125f7f
Compare
malcolmbaig
reviewed
Jan 12, 2026
manage_breast_screening/tests/system/clinical/test_clinic_show_page.py
Outdated
Show resolved
Hide resolved
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11867-clinic-show-snagging-updates
branch
2 times, most recently
from
3339d31 to
c09972d
Compare
malcolmbaig
reviewed
Jan 12, 2026
manage_breast_screening/tests/system/clinical/test_clinic_show_page.py
Outdated
Show resolved
Hide resolved
malcolmbaig
reviewed
Jan 12, 2026
* Add (you) to the appointment user attribution in the clinic list if the appointment is attributed to the current logged in user
* User attribution colour has been changed to grey. * Change NHS Number colour to grey.
* Change 'go back' text to 'clinics' for clarity.
cameronhargreaves1-nhs
force-pushed
the
DTOSS-11867-clinic-show-snagging-updates
branch
from
c09972d to
a9b1b31
Compare
|
malcolmbaig
approved these changes
Jan 12, 2026
malcolmbaig
dismissed
gpeng’s stale review
Have read gpeng's PR feedback and can confirm requested changes have been made.
cameronhargreaves1-nhs
deleted the
DTOSS-11867-clinic-show-snagging-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some clinic show page /clinic/ minor fixes:
User attribution in the appointment column should be grey (same styling as DOB age)
If the user is the current user the attribution name should be followed by "(you)"
NHS number should also be grey
"Go back" link should be "Clinics"
Jira link
[DTOSS-11867](url)
Review notes
Review checklist