Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.
CI/CD pull request

fix: remove TODO comment resolved by DTOSS-9159 #424

Sign in to view logs

fix: remove TODO comment resolved by DTOSS-9159

fix: remove TODO comment resolved by DTOSS-9159 #424

Triggered via pull request June 3, 2025 10:06
@ianfnelsonianfnelson
opened #44
fix/resolve-sonarqube-warnings
Status Success
Total duration 7m 27s
Artifacts 6

cicd-1-pull-request.yaml

on: pull_request
Set CI/CD metadata
8s
Set CI/CD metadata
Validate PR title
3s
Validate PR title
Commit stage  /  Scan secrets
6s
Commit stage / Scan secrets
Commit stage  /  Check file format
5s
Commit stage / Check file format
Commit stage  /  Check Markdown format
3s
Commit stage / Check Markdown format
Commit stage  /  Check English usage
9s
Commit stage / Check English usage
Commit stage  /  Lint Terraform
5s
Commit stage / Lint Terraform
Commit stage  /  Count lines of code
10s
Commit stage / Count lines of code
Test stage  /  Linting
4s
Test stage / Linting
Test stage  /  Unit tests
56s
Test stage / Unit tests
Test stage  /  Perform static analysis
2m 22s
Test stage / Perform static analysis
Image build stage  /  get-functions
7s
Image build stage / get-functions
Matrix: Image build stage / build-and-push
Image build stage  /  Append short commit hash to images
0s
Image build stage / Append short commit hash to images
Image build stage  /  aggregate-json
23s
Image build stage / aggregate-json
Acceptance stage  /  Environment set up
5s
Acceptance stage / Environment set up
Acceptance stage  /  Contract test
4s
Acceptance stage / Contract test
Acceptance stage  /  Security test
4s
Acceptance stage / Security test
Acceptance stage  /  UI test
3s
Acceptance stage / UI test
Acceptance stage  /  UI performance test
5s
Acceptance stage / UI performance test
Acceptance stage  /  Integration test
4s
Acceptance stage / Integration test
Acceptance stage  /  Accessibility test
4s
Acceptance stage / Accessibility test
Acceptance stage  /  Load test
3s
Acceptance stage / Load test
Acceptance stage  /  Environment tear down
3s
Acceptance stage / Environment tear down
Fit to window
Zoom out
Zoom in

Annotations

20 warnings
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L25
Non-nullable property 'RecipientOrgCode' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L23
Non-nullable property 'RecipientOdsCode' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L21
Non-nullable property 'RecipientName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L19
Non-nullable property 'Recipient' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L17
Non-nullable property 'UploadTimestamp' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L15
Non-nullable property 'ExpiryTime' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L13
Non-nullable property 'FileName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Models/Response/OutboxService/TrackOutboxResponse.cs#L7
Non-nullable property 'MessageId' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Configuration/MailboxConfigurationResolver.cs#L14
Converting null literal or possible null value to non-nullable type.
Test stage / Unit tests: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Configuration/MeshConnectConfiguration.cs#L51
Non-nullable property 'ProxyAddress' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshInboxService.cs#L125
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshInboxService.cs#L69
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshOperationService.cs#L73
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshOutboxService.cs#L195
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshOutboxService.cs#L151
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshOutboxService.cs#L137
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshOutboxService.cs#L107
Possible null reference return.
Test stage / Perform static analysis: src/dotnet-mesh-client/application/DotNetMeshClient/NHS.Mesh.Client/Services/MeshOutboxService.cs#L67
Possible null reference return.
Test stage / Perform static analysis: src/ServiceLayer.Shared/Data/Migrations/20250521094738_AddNbssAppointmentEventTable.cs#L41
Define a constant instead of using this literal 'varchar(30)' 5 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
Test stage / Perform static analysis: src/ServiceLayer.Shared/Data/Migrations/20250521094738_AddNbssAppointmentEventTable.cs#L23
Define a constant instead of using this literal 'char(1)' 8 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)

Artifacts

Produced during runtime
Name Size Digest
aggregated-sbom-repository-report-pr44.zip Expired
713 KB
sha256:2e735a0d9e7875b03733ea8f8a8e267c628fc6cb4802272702e5e1ed863eba75
aggregated-vulnerabilities-repository-report-pr44.zip Expired
426 KB
sha256:5bb326d7d3a43edb9cbb73d7e020e959a60d812d0dd4165f80ec9f48bcd7d469
lines-of-code-report.json.zip Expired
841 Bytes
sha256:bc2b6f8432ef335863a1efcb035173fc8ec36330bf5105ddf639c3359f1b9180
sbom-mesh-ingest-repository-report.json.zip Expired
713 KB
sha256:7825d85ff2b5382a4db7880be93a0b20d2bd1bd8a77199e5f31805e948474980
service-layer-mesh-ingest-vulnerabilities-summary.txt Expired
1005 Bytes
sha256:df1b791ebac468fb479dd7346842b13f9a517a268a6b63705dfec2c0d3b30908
vulnerabilities-mesh-ingest-repository-report.json.zip Expired
425 KB
sha256:4631db215b6c13790e24a163b39561335aba7f47cc952be5e455023fac1bd6dc